| Message ID | 1699594629-3816-1-git-send-email-hyeongtak.ji@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/damon/core.c: avoid unintentional filtering out of schemes | expand |
Hello Hyueongtak, On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@gmail.com> wrote: > The function '__damos_filter_out()' causes DAMON to always filter out > schemes whose filter type is anon or memcg if its matching value is set > to false. > > This commit addresses the issue by ensuring that '__damos_filter_out()' > no longer applies to filters whose type is 'anon' or 'memcg'. Nice catch, thank you! checkpatch.pl shows one warning, though: WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@gmail.com>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com>' > > Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > mm/damon/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index bcd2bd9d6c10..d5ef8945a343 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -920,7 +920,7 @@ static bool __damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, > matched = true; > break; > default: > - break; > + return false; > } > > return matched == filter->matching; > -- > 2.7.4 > >
On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park <sj@kernel.org> wrote: > Hello Hyueongtak, > > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@gmail.com> wrote: > > > The function '__damos_filter_out()' causes DAMON to always filter out > > schemes whose filter type is anon or memcg if its matching value is set > > to false. > > > > This commit addresses the issue by ensuring that '__damos_filter_out()' > > no longer applies to filters whose type is 'anon' or 'memcg'. > > Nice catch, thank you! > > checkpatch.pl shows one warning, though: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@gmail.com>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com>' This can be addressed by including an explicit From: line at start of changelog. Which should we use? > > > > Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com> > > Reviewed-by: SeongJae Park <sj@kernel.org> I'll add Fixes: ab9bda001b681 ("mm/damon/core: introduce address range type damos filter") Cc: <stable@vger.kernel.org>
On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park <sj@kernel.org> wrote: > Hello Hyueongtak, > > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@gmail.com> wrote: > > > The function '__damos_filter_out()' causes DAMON to always filter out > > schemes whose filter type is anon or memcg if its matching value is set > > to false. > > > > This commit addresses the issue by ensuring that '__damos_filter_out()' > > no longer applies to filters whose type is 'anon' or 'memcg'. > > Nice catch, thank you! > > checkpatch.pl shows one warning, though: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@gmail.com>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com>' > Also, I think we need to add below? Fixes: ab9bda001b68 ("mm/damon/core: introduce address range type damos filter") Cc: <stable@vger.kernel.org> # 6.6.y > > > > Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com> > > Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ [...]
On Sat, Nov 11, 2023 at 3:31 AM Andrew Morton <akpm@linux-foundation.org> wrote: > > On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park <sj@kernel.org> wrote: > > > Hello Hyueongtak, > > > > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji <hyeongtak.ji@gmail.com> wrote: > > > > > The function '__damos_filter_out()' causes DAMON to always filter out > > > schemes whose filter type is anon or memcg if its matching value is set > > > to false. > > > > > > This commit addresses the issue by ensuring that '__damos_filter_out()' > > > no longer applies to filters whose type is 'anon' or 'memcg'. > > > > Nice catch, thank you! > > > > checkpatch.pl shows one warning, though: > > > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji <hyeongtak.ji@gmail.com>' != 'Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com>' > > This can be addressed by including an explicit From: line at start of > changelog. Which should we use? Please use <hyeongtak.ji@sk.com> if it's possible. > > > > > > > Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com> > > > > Reviewed-by: SeongJae Park <sj@kernel.org> > > I'll add > > Fixes: ab9bda001b681 ("mm/damon/core: introduce address range type damos filter") > Cc: <stable@vger.kernel.org> >
diff --git a/mm/damon/core.c b/mm/damon/core.c index bcd2bd9d6c10..d5ef8945a343 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -920,7 +920,7 @@ static bool __damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, matched = true; break; default: - break; + return false; } return matched == filter->matching;
The function '__damos_filter_out()' causes DAMON to always filter out schemes whose filter type is anon or memcg if its matching value is set to false. This commit addresses the issue by ensuring that '__damos_filter_out()' no longer applies to filters whose type is 'anon' or 'memcg'. Signed-off-by: Hyeongtak Ji <hyeongtak.ji@sk.com> --- mm/damon/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)