From patchwork Sat Jan 25 06:19:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ge Yang X-Patchwork-Id: 13950161 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36EF0C02182 for ; Sat, 25 Jan 2025 06:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12CE42800CC; Sat, 25 Jan 2025 01:20:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B6B92800CA; Sat, 25 Jan 2025 01:20:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E991D2800CC; Sat, 25 Jan 2025 01:20:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CC7BA2800CA for ; Sat, 25 Jan 2025 01:20:03 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7A36B81B3D for ; Sat, 25 Jan 2025 06:20:03 +0000 (UTC) X-FDA: 83044973886.28.2244C41 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.6]) by imf09.hostedemail.com (Postfix) with ESMTP id 8C326140008 for ; Sat, 25 Jan 2025 06:20:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=LJ3oRveP; spf=pass (imf09.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.6 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737786001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=N0K64Frkc5azdmOFrR3OtjB88tg3/Za3nPywPrHcrEY=; b=RrQw8vbYhxVgsutbaSbYiChP/ToFmV8EL2EgKJbrM4qMicA0pwEctRi2KVNm/g1HXSOijO +J9JcVfrSozBkr+GE/q/b88aMJvoSzhS3+BrgCv0l+U2Ygc5MD+jNUu8q/K6dsCdGbzRQt fgsXocHkgOMXBllyyXQ17rSDFHkDhcA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=LJ3oRveP; spf=pass (imf09.hostedemail.com: domain of yangge1116@126.com designates 117.135.210.6 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737786001; a=rsa-sha256; cv=none; b=gZebpXVmZIS9kYZAnY92RPR7F2Oo9bak4qzcAOh2cHv8x9XD+JLM4lawfFF2Kiv7fXQx8H CoSA9fSLOAa+5eTdK9J0dB1fGSDj0V1u1QreXXUOLXGIjhPD4nHXLr0DquXnvcPjAGy7li qV0kIk8pOeS+Llpyaxrxh8BntRCcVZU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=N0K64Frkc5azdmOFrR 3OtjB88tg3/Za3nPywPrHcrEY=; b=LJ3oRvePutzFEbAn7BrwdVamCucJnDLbHC 2LJDV1KZQ5AquQmXspj7XtS6s1gUaHmMwJuCUr8b1bwx4WJy3a5q8fyeR/ZQ72PY wRoZcvvucUIaIBCux2XBngnndSHOg8wzIS6aksmGU11phChSQTj5TSFIioKruonZ reLLSLFE8= Received: from hg-OptiPlex-7040.hygon.cn (unknown []) by gzsmtp5 (Coremail) with SMTP id QCkvCgDnzxaEgpRn662xAA--.6031S2; Sat, 25 Jan 2025 14:19:49 +0800 (CST) From: yangge1116@126.com To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, hannes@cmpxchg.org, vbabka@suse.cz, liuzixing@hygon.cn, yangge Subject: [PATCH V3] mm: compaction: use the actual allocation context to determine the watermarks for costly order during async memory compaction Date: Sat, 25 Jan 2025 14:19:47 +0800 Message-Id: <1737785987-7883-1-git-send-email-yangge1116@126.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: QCkvCgDnzxaEgpRn662xAA--.6031S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxZrW3CFyxAFy5Cr13Kr1DGFg_yoW7JF1fpa y8uw13C395XF43uF4xta1kuF1Ygw4xJF1UJFyIyw18Zw4akFn2v3WDta45AF4UXry3JFWj vFZ09F1DCanxAaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRoKZXUUUUU= X-Originating-IP: [112.64.138.194] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbifhTeG2eTdfUPBAABsR X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8C326140008 X-Stat-Signature: eqaxrsdw9im93odmpmza1nporgs9okp6 X-Rspam-User: X-HE-Tag: 1737786000-511284 X-HE-Meta: U2FsdGVkX1++ZftpgJanOU+aJGHJV2Vpdvt/6YcqdXga+NJ542JjKzGVFxvgqYf8uzCMr7XON294uaniCMKqL3mKGdc6VMGHOBtFJ+onNssi08Xcmw223e3d2GdV812FLvKyLoGWqROBHd/AwH/XsgUW8hTmJqI5NPLhR576dARw6p7KrUcpRMU+d8lxvw93Lb8KTnKHXkq+prKpuaRi2kfIgg+iBUdHMzuNcycifV05ztf8ZyVlaHVFVf9IsMKqPERHgKuzJEDl+saeLKPRNnYg5+RSyLa9lTzDhPcyTK2zfFio7xwHg2mw4lc1ojurq3Flp+YOo2VrPVwKywYsOGPwnKHtSQRQpAsu5SOLsUbbg6BClIb/+KExrhQryd/jtG3n2q6QVfsqcRQo0CcfCAdCOXN/syuqWfuFmJJCo8AfG3F7r6QDLk/KT0nOPMCpw3LjD49a2x6iFAEwDfZDO7glhaSmZMEUd83Y0N9qCBzX/Hm3eGUEXSjo1FrUSNJIT4/CydpXLAULul6LkPUoPu25DdGM3sZ5yJaGifmE/YaadmSb1Y683PSil8R5n/AiqChtpJErF5eR40KfEEiYq0MKWrybycYujq0JtP4g7lO1pf/JNdlkau1He4uJ9Je3g/1N+/yxaeKKDH6x2TnBrW/l/FZpzDu8cWN56vyMQR10XPOhDsfKSLix4QpdQ+atWvOqRhEK9iukZuWg0E5PYYIRXviOZk4NjoRyQbGoJhib0zFdzw8ZHYwCZi0a9XMNYAFCoWHi6Iv/QaC0KjA8RBSrBipdciZEhn/XVUSrnhHScUaRnoqTqpsQn9U7jKlIZgxK8vN6zdCw88WVGX45ol95jGBW8OkB4u1Fp6ME+0m8uwTQze+APdGjsu7YQhAM+ASGUXy/fYySL6WH+EUSFxriqih3nqFKFsm0WdWxd2E6RQaYGu0bTGfi1b1tTT6K89ahKeVGRMD4qwVGFhz FahGbvM4 P3dhN2F0bR8zlwOUulzsfbPHCUevhRkFDkjDRfhn69J3YIJ9gpTBtLFnz3bRyFlBGKZKzwH5D/24nRGO9ApIxJL9CrhGgzqD1mSGYhkHRQk2Vj7ueB8kyMbKmzWMbtHgUNOVDGwuu1RW79RTOXswQOy139iZl/PfWeMPtCUbOLTsZNiVsg3+dbBQ04fpObqpI1wdZAM04mrNn4zcV1/ZM8TauyESdzCmczLnjGUy4rE8FZ12eDeBrfe82L0d+i6ClhOkKlw/9eEw7cIMbtV55YzzEq/0jI0taNwoSy1NoodxP+K1f+jj9Mj+0g60aSMOvI7/OmPUbi6C3KB859UXXT4UPB6c49ESY6o3fRdEZRQjtZrURwK4cft1m0vpEtUDv4lIfMRxv0pDtsH/FGvmJ1bHaHOnybX5RJCAA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: yangge There are 4 NUMA nodes on my machine, and each NUMA node has 32GB of memory. I have configured 16GB of CMA memory on each NUMA node, and starting a 32GB virtual machine with device passthrough is extremely slow, taking almost an hour. Long term GUP cannot allocate memory from CMA area, so a maximum of 16 GB of no-CMA memory on a NUMA node can be used as virtual machine memory. There is 16GB of free CMA memory on a NUMA node, which is sufficient to pass the order-0 watermark check, causing the __compaction_suitable() function to consistently return true. For costly allocations, if the __compaction_suitable() function always returns true, it causes the __alloc_pages_slowpath() function to fail to exit at the appropriate point. This prevents timely fallback to allocating memory on other nodes, ultimately resulting in excessively long virtual machine startup times. Call trace: __alloc_pages_slowpath if (compact_result == COMPACT_SKIPPED || compact_result == COMPACT_DEFERRED) goto nopage; // should exit __alloc_pages_slowpath() from here We could use the real unmovable allocation context to have __zone_watermark_unusable_free() subtract CMA pages, and thus we won't pass the order-0 check anymore once the non-CMA part is exhausted. There is some risk that in some different scenario the compaction could in fact migrate pages from the exhausted non-CMA part of the zone to the CMA part and succeed, and we'll skip it instead. But only __GFP_NORETRY allocations should be affected in the immediate "goto nopage" when compaction is skipped, others will attempt with DEF_COMPACT_PRIORITY anyway and won't fail without trying to compact-migrate the non-CMA pageblocks into CMA pageblocks first, so it should be fine. After this fix, it only takes a few tens of seconds to start a 32GB virtual machine with device passthrough functionality. Link: https://lore.kernel.org/lkml/1736335854-548-1-git-send-email-yangge1116@126.com/ Signed-off-by: yangge Acked-by: Vlastimil Babka Reviewed-by: Baolin Wang Acked-by: Johannes Weiner --- V3: - collect Baolin's reviewed-by and Johannes's acked-by, thanks! V2: - update code and message suggested by Vlastimil mm/compaction.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 07bd227..3de7b67 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2490,7 +2490,8 @@ bool compaction_zonelist_suitable(struct alloc_context *ac, int order, */ static enum compact_result compaction_suit_allocation_order(struct zone *zone, unsigned int order, - int highest_zoneidx, unsigned int alloc_flags) + int highest_zoneidx, unsigned int alloc_flags, + bool async) { unsigned long watermark; @@ -2499,6 +2500,23 @@ compaction_suit_allocation_order(struct zone *zone, unsigned int order, alloc_flags)) return COMPACT_SUCCESS; + /* + * For unmovable allocations (without ALLOC_CMA), check if there is enough + * free memory in the non-CMA pageblocks. Otherwise compaction could form + * the high-order page in CMA pageblocks, which would not help the + * allocation to succeed. However, limit the check to costly order async + * compaction (such as opportunistic THP attempts) because there is the + * possibility that compaction would migrate pages from non-CMA to CMA + * pageblock. + */ + if (order > PAGE_ALLOC_COSTLY_ORDER && async && + !(alloc_flags & ALLOC_CMA)) { + watermark = low_wmark_pages(zone) + compact_gap(order); + if (!__zone_watermark_ok(zone, 0, watermark, highest_zoneidx, + 0, zone_page_state(zone, NR_FREE_PAGES))) + return COMPACT_SKIPPED; + } + if (!compaction_suitable(zone, order, highest_zoneidx)) return COMPACT_SKIPPED; @@ -2534,7 +2552,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) if (!is_via_compact_memory(cc->order)) { ret = compaction_suit_allocation_order(cc->zone, cc->order, cc->highest_zoneidx, - cc->alloc_flags); + cc->alloc_flags, + cc->mode == MIGRATE_ASYNC); if (ret != COMPACT_CONTINUE) return ret; } @@ -3037,7 +3056,8 @@ static bool kcompactd_node_suitable(pg_data_t *pgdat) ret = compaction_suit_allocation_order(zone, pgdat->kcompactd_max_order, - highest_zoneidx, ALLOC_WMARK_MIN); + highest_zoneidx, ALLOC_WMARK_MIN, + false); if (ret == COMPACT_CONTINUE) return true; } @@ -3078,7 +3098,8 @@ static void kcompactd_do_work(pg_data_t *pgdat) continue; ret = compaction_suit_allocation_order(zone, - cc.order, zoneid, ALLOC_WMARK_MIN); + cc.order, zoneid, ALLOC_WMARK_MIN, + false); if (ret != COMPACT_CONTINUE) continue;