From patchwork Wed Sep 20 09:38:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: liwenyu X-Patchwork-Id: 13392434 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5154CE79AB for ; Wed, 20 Sep 2023 09:40:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C65686B011C; Wed, 20 Sep 2023 05:40:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C15956B0130; Wed, 20 Sep 2023 05:40:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B04856B013B; Wed, 20 Sep 2023 05:40:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A0E4C6B011C for ; Wed, 20 Sep 2023 05:40:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7677140E44 for ; Wed, 20 Sep 2023 09:40:15 +0000 (UTC) X-FDA: 81256479990.27.2BB1C32 Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by imf10.hostedemail.com (Postfix) with ESMTP id 56775C0016 for ; Wed, 20 Sep 2023 09:40:10 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wenyuli@ex.bilibili.com designates 54.207.22.56 as permitted sender) smtp.mailfrom=wenyuli@ex.bilibili.com; dmarc=pass (policy=none) header.from=bilibili.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695202813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=DzUcwGSG//LnUKgm34Crts4yKOn0WaQ5z6foqW1ZWB8=; b=1sKEk0DJDW4bZmVVGDLqUxmw0jlVC/+X1zZZ/r3K4WYS2al7V4nhF8Jij5JP/U8d5wUUjy OGdlTx+0aCOT7AjRLl6FJU1vcnxAWGzEW7ZEpUtiFwfD/4ur/1CRDBr9iiWFsYBG5grmYE CcyDm88tFALL/BQOktyiISyhoVefRJY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695202813; a=rsa-sha256; cv=none; b=zwAxSAtRAZTLn3EzOoa368Tf210iVnc7XB++3UddsbjU0I/2ppeM/E3/48CkgJ1Lu8vwzf 8jlUtV0MYKO6kzoH2d87WemPDiDGDBMG+lOkPF/5oSGyvHri+WwrduxUl/YzVeJ/RFX63i 4kWMpDRQkzpCY/r/D8M12rgISg0Ew8U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wenyuli@ex.bilibili.com designates 54.207.22.56 as permitted sender) smtp.mailfrom=wenyuli@ex.bilibili.com; dmarc=pass (policy=none) header.from=bilibili.com X-QQ-mid: bizesmtp74t1695202772tn02677e Received: from [10.23.230.53] ( [121.46.247.130]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 20 Sep 2023 17:38:50 +0800 (CST) X-QQ-SSF: 01400000000000101000000A0000000 X-QQ-FEAT: vrqOr+ppv0sOrG/PUzmadjlzcJfWoUqZsFhBWAm5zn1sikR/Q/rd4MGQJXch0 cuoSfOXHIBii+lU45P553185ZJk8s7C6HwrhMjnhpImBMzsZ+KT6DTBYTUH7MS+ftXfZPIM tZ5MW5OUVUwOKcE1PajYjUC+5eQVTQHHmzZkpU6fdu1fXOsyi1Oe86QOrt9sm0fP+8+Ti/d giXrZ7BRYEwW0dP0yJapC40qVmQz7KpyWa6tuL81KiBzBlKcLTY/ONaTPfBxBQhV2xAO4kq NVPBN3grP/71hu0vf5sh5DzKt8W75N6kEgezJ90Mf6OtgPd1WV5D+EHSukSl55Vbhi8TVJw sYvrIYIzXO/C5w815zRkkRSc9YbplMReWY10q9EzP/A2h6HcEi1GtmSKi6iYw== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 17908884623268010789 Message-ID: <181C946095F0252B+7cc60eca-1abf-4502-aad3-ffd8ef89d910@ex.bilibili.com> Date: Wed, 20 Sep 2023 17:38:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: liwenyu Subject: [PATCH] delayacct: add memory reclaim delay in get_page_from_freelist Organization: bilibili To: akpm@linux-foundation.org Cc: bsingharora@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangyun@bilibili.com X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:ex.bilibili.com:qybglogicsvrsz:qybglogicsvrsz3a-0 X-Stat-Signature: 3s9tdgnw5iyryhsi5yndtkuihwbafte9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 56775C0016 X-Rspam-User: X-HE-Tag: 1695202810-738223 X-HE-Meta: U2FsdGVkX18yitKjVrewV9X1KoaWGM6Ar8SRlNZ6QuLpqnvAg5bF1RRE1APjf7rxu1bDV7D2pxjGj4sBeb/IOaTvH0RC1msx7GbYqiim6aIHY4x+jC3gAL2tmyNQzLWazyxl3tijU/xjvSx53FWy8Xz0A+ULo7WxC/+nHA8/XX+a2lnySHb1qRmwWRavxliV2H8TyCYGZDrbikht6MM93Vo57meI0sfbkZDT80+sBttj/DaX5dxfCj+zyk6G8HBwC1+SD7LKaHw5cq2okFD/2+d/cpyI/+A6PzciJoOG13bKtPfOs7/g8elnmbb0X+rPhSGcEfQtz6bf4Q2Q7Sy3uo9YRk3LxS9KeDGKwaEsGlvvp8A++kEE3C3xRsTQIY2aCc13Mc0Q1Judv62jiKXPY8IDSmH0zjQXt+hprty98PEAA4BgGWyNzv9d/fG4RU71qlit25tD2YdeU0eWpNa67wUHc3D/Qzx4WE12d2PcinzRqzk+sH0Asms+F1/bQ7aHbLxaJdDj1O5JxsOHauLJVU7KdqjooA0yYHLEkHLu73ZEVu2YS08VwSCfkYzNod41AreBIWz953ifNkFX+1EXqXwryp44hgrtlsVcpOeUTh4gpGK2zN3DsWLbtHGQPw/PzyRtVWPC1E6ZFVrwknOcUwkF/XX0DQhxUf84Lbza1O9Mz4OgfB8U3tZd8+TVI0cO16Yz1MQmJAzOXBJTge97P0A939AnJxgHGJg0F0zKKrGL1onvRDadDxPn5y6rhqFMabuAMcT+4vvtjf18pnpnM4skiYh/XSmZ2tqQngj9mR3erTG1wDWRtLJVOr3uPwECBbPR58uMmPTzHsi9qnCaowLWd2I1a99k5QWEKf9Q4Y9IXGEbjgtvn76sa3a0kPtpO/gvvyXnUx8AEUlRr8ymKkWUFYWZZftsT5vNJRJpAk2KsLSSvb3EXpn3bCSYLzub+JmpAr7e7YiUfrCOJp2 /+HnMM3B oYTfr00IywR1f/lh+vjJmlpRA+tH7/BUr+SUO0IShk7xFnKqvLt+mobCPTn9A1fZ4fGjxB+DMwrmrkCfPFab4XtQeWSxj5S4Qor4VHfQzpzTVceifcyIxS1h2XPDlKPAfqfauAzCInvIx6xSI+aMhKQTKXl6fp0TzX27e2iQIt82avlG/8mQskfzzhGyJG04qakaEHYJDmthCB/YO1TTM6tuejr+KMf5UOp79Yeaerb71Qt6g7r3D1bE8U1PQ32sf/PfnS6DtYazVUt/UzJuPqR4xhC/EltETJZQLcZAa9Oe3b8SlC+QvvQwDzFIjAOAgpwXMOZUzWRl0R8xKjUUwXusom3u4HgIn2ygUwXTOV0iFi03Qy9DBMOJN5ZBhxVsnpd/TPpYc7lLFo7V4pG0fg5tjXToj7ZtV6KDS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The current memory reclaim delay statistics only count the direct memory reclaim of the task in do_try_to_free_pages(). In systems with NUMA open, some tasks occasionally experience slower response times, but the total count of reclaim does not increase, using ftrace can show that node_reclaim has occurred. The memory reclaim occurring in get_page_from_freelist() is also due to heavy memory load. To get the impact of tasks in memory reclaim, this patch adds the statistics of the memory reclaim delay statistics for __node_reclaim(). Signed-off-by: Wen Yu Li --- mm/vmscan.c | 2 ++ 1 file changed, 2 insertions(+) * We need to be able to allocate from the reserves for RECLAIM_UNMAP @@ -8048,6 +8049,7 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in memalloc_noreclaim_restore(noreclaim_flag); fs_reclaim_release(sc.gfp_mask); psi_memstall_leave(&pflags); + delayacct_freepages_end(); trace_mm_vmscan_node_reclaim_end(sc.nr_reclaimed); diff --git a/mm/vmscan.c b/mm/vmscan.c index 6f13394b112e..88be3dedc584 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -8026,6 +8026,7 @@ static int __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned in cond_resched(); psi_memstall_enter(&pflags); + delayacct_freepages_start(); fs_reclaim_acquire(sc.gfp_mask); /*