From patchwork Thu Mar 30 10:43:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13193871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3E1EC6FD1D for ; Thu, 30 Mar 2023 10:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46825900007; Thu, 30 Mar 2023 06:44:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 422FF900003; Thu, 30 Mar 2023 06:44:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B8BB900007; Thu, 30 Mar 2023 06:44:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1DC5A900003 for ; Thu, 30 Mar 2023 06:44:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E91021C6348 for ; Thu, 30 Mar 2023 10:44:44 +0000 (UTC) X-FDA: 80625231288.12.35C91CF Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf17.hostedemail.com (Postfix) with ESMTP id DBCA040018 for ; Thu, 30 Mar 2023 10:44:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=RgdmFY8p; spf=pass (imf17.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680173083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9N1nbrpzeskxzY8j0FOtrl+cQrtbVwT0+sKnvHUTqGU=; b=TYIzNKb1zai3YPIR+fhwmYqRkTUiHO49kinIQcslgjjAiYJ1qylxbANU8mQyebOEbKNalw ctoZJh1PcqbEEtmkCUywbmVik64TQrlKWC3YNZSUTyb+6i0rAL8/EMkRTlOFbtZrY0Sdyg gPXUjuBCAnkV29Po+GuISDAMEb0MmZo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=RgdmFY8p; spf=pass (imf17.hostedemail.com: domain of "prvs=446327cdf=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=446327cdf=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680173083; a=rsa-sha256; cv=none; b=S9ZVwaQpCuybBx2OkFX7HvkAskRxMMG2S/2IDNRgH862j7Up7pyXhReSx/TJe0NvB/p4t5 SPLfxuNrpVsIjhWumnHkid5XpqqN5Pew1KGrRY6CWq2Emh+vUf02bAxv6z1hd17Oo/EvtR KLG4Su4IOtofcrcd+uP26Js5s+2OK14= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680173083; x=1711709083; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EUpgRxBtOLFJ91CyJDOvQQnrN1sWY+otarb8WY7sZkU=; b=RgdmFY8pGkWDrmhsWNfK+NIa4G69GM6rvC/VYbUbR6KmSHANW6RKFbjy 7thgKfzyGg3VWpibv+fTly1mwLHoQDw2mj7YKn8SrXjzDauAyhveno/Tl wR4QLFK0IrwTsBHuZ/DywGF+U9UmwKVvAeWK0jJG4emxpjsgArI9uSrzW DKdAfHX2OcGBVz+R/9rj4ASvTieVj3QWrDSPVMcr4b6f91mB9bUkaahcD eklwADSwG0kUqMijm1xXhLKhtFzXJLNpeIEUebi87Hr6UDnC5r3DumPA+ 7aAIeI7GnwqTvAjLsEpGfbzWvGHmeCTl/7o/nqdItlQLOQDCQ0i+ZmNdD Q==; X-IronPort-AV: E=Sophos;i="5.98,303,1673884800"; d="scan'208";a="231853949" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 18:44:41 +0800 IronPort-SDR: ExvrOWGxh+JKM/YJ3oY/ufx3CWU99En9pdJS2znYTik04SQQ7JzT/eWzU1pPjlgwfTDgINDDAc t1MXSfkjWhNHReAF5LwjqOlzsleuSZrmncIixfjCwHzJ1QCNEgEkCguD5CQ/Z6VemKF3PUKtFr fZskoIVdlAVHdBzr6ZxZ2NDkirvC2S3xOPdea8+5+uOkIuCvPrP7S6Eq1V7v/swxuI6XTaYYzG Ojm5vuYkONpmsZ/Dza+8ukvw9vTUnidqKJR5Y726ckBG4CHQ6GmNtz4Rk4I1BM29NpJQ1XjP21 +Vk= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Mar 2023 02:55:08 -0700 IronPort-SDR: VYA9BgUUDr4sRMMfeFHmoTvJAnU8njSRM2w2NjoxJH3Cs70Kv8EJ/NbwobjN2EMuJHAYNPSu+2 Nv24R+meZtBuzWBLMI2rGIlIum+FZJ3DzLLEATptDFEbE2+Hak6NpQWmS1jl66KjmWQRpANrQO SJDRkUryKsiMGPqt9zUBSBJ1Bi1cbUurM7jtK569mscScXqA2oFbNgVwXqIwxlQ2MR+O4fo2VQ EV+jUSVXErWdsRYtr4iObYolOTAsYF/RWA3lThvvL1VeJ33ahhyJvlra7p2jf2qsTPNoO6Xbj7 kMw= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.72]) by uls-op-cesaip01.wdc.com with ESMTP; 30 Mar 2023 03:44:39 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v2 12/19] zonefs: use __bio_add_page for adding single page to bio Date: Thu, 30 Mar 2023 03:43:54 -0700 Message-Id: <1b1bdd842de5f699d76191565fb2b6659aa38922.1680172791.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 9dti3ns4yf9pjfbbkwdsdqba1kc7thu4 X-Rspamd-Queue-Id: DBCA040018 X-HE-Tag: 1680173082-965985 X-HE-Meta: U2FsdGVkX18P06AUhjSahQMW949aqrBDKgq3kePMePrq675LJooe2kPxwXbpUDNWaJyXwYRudjtBaLB0wuyUer4Gqore1pFg5B0ScmxGOYX0S5bBGtHOKWXZrir+nNkY35kiq0hYaEOKlzAvFmQsyieZAiA6qcwDv8vTsrkb3qnroddWh8D7ZHduJCfYxb9ccIpFJS0elETM/lOyxYIvP3v3ynJNnDSoh2xdkCCHisQ7uQfCKQ+FunNl3b64LgE95zr7bJQGJO+QVXK0vPhhcLqVIi3pIJYzU4Vzl+1hpnID0YjNlBKWuz0VCJdPrzsW0gkfxmiAp+1KtJ97J9VTyOcGFuupUtFdIN8TPaHDjayd14QtQP9jpNhdq4D7iL0dBERdL13Fx87ymQrqzOnEkXH50ffXSEqAnYTEHJIwH09Rdrt2GlPsIRWEzUk0s4GjYP8iLD2T6MFdcZU9I8qm0Pr4P2GLD/DMVLlDqjToGAQnWZbMlLQzBJGh12u4YYhi3f/VjZ9MhtDbGoR04FnfsAqHXYr6/NS/5vCW8Kh4kaeGCCmCuKX07+CF/1bawBDw1CiGZmuwzzCblYsCPQQoRGI4+sielTOu01t1cvmjKARLULmvmcLn6j5VyCvrYhZiZX5kroEr7aNDe8WIQwtEoGGZc0A4XMUo6Y2CgvFEjWWA8L65RIPY1ThHzl6/2U8/rgQJuuWLCVV2ZSY1Vn99IuEEvdAqZBLAiWRmNZSIeK1a94HrFI42oROIeTe26TmlNPkz7nS3fgWHS/xvPRh3KkzvN7rJSq1VSgHyQjeUZRoBmD7uNWkge7pqHGhvP8k2YOT16pKQYlNnA6do99kj4gabnx4YIuo5UPgDAMaWhpyiKdU7/q/xwo48VpXZdQkC8uRsPmfcXaoebtaBGtfKXBQGodlA7nUjdtvExt+26XO/hNi6v7NeY1q2Ps5rkyGXRm5rodt366gIGqelWu5 ktK6r25Z zoFqkkcBv5Jemz328teJBxmkuGnSsHmxyMDgAowtU4uarfxhvW16I5kYs6hgnzfG4dFOW09LfdDqZzD8loF8QnBw9YeADdLR5cxZIp2fJh+AQhkxYIXjVFBPY/S2ieC+XPBzMvlbCynAydu6oNSSpeZkmVF0oQ5mrPgX3DvmwJaOrRbvFbsPYpMEYiHYcw3JAJntX+1C915OBWLMFrdbM681rDoX7woMhOAWjoYrl4gLhSQifBC76e/bLyR5ZUPopZHZS63j9SVKcQx8lemTBjYy8lDpCJRF6Qmy/G1VIA72mI+T5urxOumXbIKQtv994YowISqOV4UavYV5ce4J8JSukqHiWF5/1efbDOUWLuOJiVf0QkM/v8pDvlpZYbTcbBSvc/qV9Gm7nD5oNEmI9WneFxozZ1fIqVeqV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The zonefs superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn Acked-by: Damien Le Moal --- fs/zonefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index 23b8b299c64e..9350221abfc5 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb) bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ); bio.bi_iter.bi_sector = 0; - bio_add_page(&bio, page, PAGE_SIZE, 0); + __bio_add_page(&bio, page, PAGE_SIZE, 0); ret = submit_bio_wait(&bio); if (ret)