From patchwork Fri May 4 15:45:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 10380903 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EC61860353 for ; Fri, 4 May 2018 15:46:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D830529434 for ; Fri, 4 May 2018 15:46:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CCCBF294D6; Fri, 4 May 2018 15:46:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4994329434 for ; Fri, 4 May 2018 15:46:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B35596B026C; Fri, 4 May 2018 11:45:58 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AE5D26B026D; Fri, 4 May 2018 11:45:58 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AFEB6B026E; Fri, 4 May 2018 11:45:58 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 3D3F86B026C for ; Fri, 4 May 2018 11:45:58 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id l6-v6so14376371wrn.17 for ; Fri, 04 May 2018 08:45:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=NQ0McJc2k1y+KJqUOFLLCCSOk0hhDPsfh1nI4EBfANE=; b=rEQOTfYvLNVN9oKqF4cenw5ZGP3AETTuyK7co64Ik1XdIrHeftc6wzkeWJ7CxJMBc+ hF64FbYqM0FRIzk2N4mdYJHxmK8yP38GK6XMirwnDPpdKR0ZuqOvQUcHsaKeWRoqbLDI tSTs4DPU1kMmroWeqZSeFIUjuLuSlG3auhWu5Th2IHfGh4C/2bSJaJbYRSs2bKtlY6VR jn/nr6CDR/PSXFeE1S1nRP+iQe97OF/93dIUGwfBUiQTKecHgXmqSumTO2ELEUFSDGhW ZRj9tZrZX02J/xOHuSFVa8ZvV+cCI2K5Rq5yTbP5onD1HQZGaicg+wWLzWdChwuUkILt PI4w== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de X-Gm-Message-State: ALQs6tCwOyWZvtOb5jKUn7e4lgHTdx9u8Ea84BCDaDkk80Pw9Ok5NqX7 1zswYtFRFdRCjfzFBcPDq1NWsdfxPVDNXVkBVQVBE3tDXZQ77taN63IzHUqFYf6PpVXpmRCwHJ5 RsWDPfQcfA8KeUnauvDlTr2YFTBlFmWR84k6wX1z1HqSR5jIDe+bpSCSLZh+jKIpXkw== X-Received: by 2002:adf:e447:: with SMTP id t7-v6mr21984245wrm.143.1525448757801; Fri, 04 May 2018 08:45:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZogjARnKAdSd3Oh3V15GFsH0paHqBmoPyh8z/T2Tsc239Sk4p+4WkSr44sWbvurvU4JxtqU X-Received: by 2002:adf:e447:: with SMTP id t7-v6mr21984222wrm.143.1525448757145; Fri, 04 May 2018 08:45:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525448757; cv=none; d=google.com; s=arc-20160816; b=HkdQkgjqAlT87/GlkBI8v/rr4vBi4tkY7996s+nkSk35jCGAzCRl4IlLNKQI0f8i40 EDoCgavU0ZQMfbJ6VjJ/BF+b2RCufbp8ZIp81maUtA9ChGAvM1ib+cS3or8eCxXjZgrR m1OerXwAIMQW51ndN7hTxlGyZNg2sUL4o3gRJiZxgqjByoxVft80ZhrhK1AxO0W2+N96 ESg5ZwPlGc1XtBlKBLDiY6zT3jNjXHwGAPxUICLwzAihJl3bfhBRWzN065NaCLaZXLll l/nbo5aOeYydpnSGs6ZX5yJtTKqIMz/jjtU0D9I8cdYYYfaLwrc8tMlm+7pO6BVaD/6u GVnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=NQ0McJc2k1y+KJqUOFLLCCSOk0hhDPsfh1nI4EBfANE=; b=Vg0cDW9BTeuN9spJdv1MtLNbO3kon2ORcXssKjcMESV23iAQ+ZPyh0kAbSw8IxhNA8 5bpyQ0SoohFHUf7AV4BtAI0337TGuHqLE2g+bdqtYmnecnnLijubbGtRvqhal5uk+Sbv YWRosOEy+QGKgzeJ3g1dztN7s913m9zvtIpYKLJVrtd4GrSXlqb0XOfYLHsAcasDsZkN rpXwVoFsEvCaIO+HOKSU4s7Z0osyh4K8kog4eRJ+wIM4ocz1cE7OFfNBYh9e3KtOkqu1 ym5lvTe8TNUHnm88WnosKjPWQBHRK/W9oEPa++PzaghT0x1waq/vB8/S48cGD6mxx9Xu ZQwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id f8-v6si14785534wra.156.2018.05.04.08.45.56 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 04 May 2018 08:45:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1fEcu9-0006lh-9l; Fri, 04 May 2018 17:45:53 +0200 From: Sebastian Andrzej Siewior To: linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, Peter Zijlstra , Ingo Molnar , linux-mm@kvack.org, Shaohua Li , linux-raid@vger.kernel.org, Anna-Maria Gleixner , Sebastian Andrzej Siewior Subject: [PATCH 5/5] drivers/md/raid5: Do not disable irq on release_inactive_stripe_list() call Date: Fri, 4 May 2018 17:45:33 +0200 Message-Id: <20180504154533.8833-6-bigeasy@linutronix.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180504154533.8833-1-bigeasy@linutronix.de> References: <20180504154533.8833-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Anna-Maria Gleixner There is no need to invoke release_inactive_stripe_list() with interrupts disabled. All call sites, except raid5_release_stripe(), unlock ->device_lock and enable interrupts before invoking the function. Make it consistent. Signed-off-by: Anna-Maria Gleixner Signed-off-by: Sebastian Andrzej Siewior --- drivers/md/raid5.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 0a5e6f5d271d..5ee974fcd42e 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -414,9 +414,8 @@ void raid5_release_stripe(struct stripe_head *sh) INIT_LIST_HEAD(&list); hash = sh->hash_lock_index; do_release_stripe(conf, sh, &list); - spin_unlock(&conf->device_lock); + spin_unlock_irqrestore(&conf->device_lock, flags); release_inactive_stripe_list(conf, &list, hash); - local_irq_restore(flags); } }