From patchwork Tue May 8 14:05:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Weiner X-Patchwork-Id: 10386223 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E64B9602C2 for ; Tue, 8 May 2018 14:04:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D02772580E for ; Tue, 8 May 2018 14:04:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1B7B20174; Tue, 8 May 2018 14:04:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56BD220174 for ; Tue, 8 May 2018 14:03:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0BBE6B0283; Tue, 8 May 2018 10:03:57 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B92316B0284; Tue, 8 May 2018 10:03:57 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5BCA6B0285; Tue, 8 May 2018 10:03:57 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 435516B0283 for ; Tue, 8 May 2018 10:03:57 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id b192-v6so5243786wmb.1 for ; Tue, 08 May 2018 07:03:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:references:mime-version:content-disposition:in-reply-to :user-agent; bh=oyJQmBpzqh5ewuafcNHrhg6XsQdnMkilUl342uCnO24=; b=jI4AHyGsa3AvURuTkhbdV3bAxQnTNEuE8jMG5demY3v+DzBF0a5lPg0UdGo/Azp/Mj ldVY4pLEj93yy+ee/6U5Ot5I84n7sVDZlgI7wZh0nU3VDXAvymtEc0TbZtUVa874RkYy z9J6gANtHJ0rM8i4ZIT95tDOXfVVEaYxwR4KL11GFLPSiZwvyjLdPxBX0NV/dXL9TR12 dJWHZimHtyKxUkCluVdJRRufIcRk86bUL+6oZJbi7HkcFtBRk8o9N13I/jPJv9YlPlHj pb5a7M5jCwuEjOhKfa/diLXa4fKTaBTwB8zijQ8eiLM+sVdOMIjZhxZwdcGd4ybwkU4N B2VQ== X-Gm-Message-State: ALQs6tCVpG2lutAuj2gv2BNba/7troPDLxM925l7ExnZvV1TQxhOXwZ9 CsUZHmklFBuG3AXVoUrARibfscU0UveJOYbb2FrTfeAPpQxirbD6nJTrMgcgtqvrpfrB4N4L64X m2GstEm8fsPFw5GgP+gLZam3mqXNWDvIXQpR/sTErzhjOX0wbRahZqyQKyWa3Gewu9w== X-Received: by 2002:a50:8b26:: with SMTP id l35-v6mr54366593edl.224.1525788236594; Tue, 08 May 2018 07:03:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpF3p1J1EluPAfVvZ1Xfjrip8+3KQenCv9YlhqsRfk9iq36a7jv/yC26Eiq+K5vTKmRtw4a X-Received: by 2002:a50:8b26:: with SMTP id l35-v6mr54366511edl.224.1525788235567; Tue, 08 May 2018 07:03:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525788235; cv=none; d=google.com; s=arc-20160816; b=KYUmBX4Tk6T8qbsMdjmDe2tOsJcy8xdM/0DwSq4tIBX/KGMmR7NzArF3unWVhNuBpw EXi80JdsuwiGtyUxtkvfXA6/PIcSj7UokgmPkaGsdOZ2StQ7YkfkWVZwh7aXKqP2NXEO G76GnIsSxAXVlErrRnzVu6T0aSKGeANis379Y3c1tMNcVf9HEPa4QisDVUS6I06FvYpN 6oo+uNRRJfd1wu40fINs4QnoYNoW6EGzxi5RcvW0uFHeOZNRwnzbbq44aGU6/hNx/SF/ Y0/58GEdON9IrWDgnQi5wnQG2eCEFwHVI6OHY70ybSx5WUMJJIR3WIUpJ++0IageRc+2 RI9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=oyJQmBpzqh5ewuafcNHrhg6XsQdnMkilUl342uCnO24=; b=e4K3+SvubS/uQK2ALex2pylulzdfHGvBCJ8lJiNAfBq+Q1+9WXe8tcYHR0adM33EQD +jea7PFHxsAuvZ73OhFQWKD7vHsMXbcl5y+Ew9nPOZYmegUdJ6apG4g0tj2Ud9DXwS2P Wv8vBZtchJgoOkxrcFaTXsdTYBgCfN5ODlYZk+UVBHVPxNDESjWKKR/7mSJf098Ek7ol N0c7r2+7RlI8T7vN1Qe1DcgvC2C0sP+GYus1VCcyxJGGHZcHO5nfRcIdJFEYi8IE+HTq zhuLdIxziRglaEDPKtqgpnLBr01ubqd4jzlo15U12W9ZXmjfOuDGiAYSmlRLGgX6mrld QNMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg.org header.s=x header.b=tZIJudIy; spf=pass (google.com: domain of hannes@cmpxchg.org designates 85.214.110.215 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id u91-v6si861446edc.270.2018.05.08.07.03.55 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 07:03:55 -0700 (PDT) Received-SPF: pass (google.com: domain of hannes@cmpxchg.org designates 85.214.110.215 as permitted sender) client-ip=85.214.110.215; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg.org header.s=x header.b=tZIJudIy; spf=pass (google.com: domain of hannes@cmpxchg.org designates 85.214.110.215 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oyJQmBpzqh5ewuafcNHrhg6XsQdnMkilUl342uCnO24=; b=tZIJudIyDaghcK0DG591UAqXrv C2PJF1TDAS6RfcfpmAdFlky+bJO9rV4TAdAON/surU5tZ144pcZ11zsfpRtwFeX3RkoNYCoczsdHb 95RVO/GNW8K9/+Hn7svn52/vgBh8Epj6mX1RPoDgbph/z7xyg3pR2nHcK82XFtFU3EPs=; Date: Tue, 8 May 2018 10:05:33 -0400 From: Johannes Weiner To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, cgroups@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , Tejun Heo , Balbir Singh , Mike Galbraith , Oliver Yang , Shakeel Butt , xxx xxx , Taras Kondratiuk , Daniel Walker , Vinayak Menon , Ruslan Ruslichenko , kernel-team@fb.com Subject: Re: [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO Message-ID: <20180508140533.GA2900@cmpxchg.org> References: <20180507210135.1823-7-hannes@cmpxchg.org> <201805080952.2yQWmzU2%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201805080952.2yQWmzU2%fengguang.wu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 08, 2018 at 11:04:09AM +0800, kbuild test robot wrote: > 118 #else /* CONFIG_PSI */ > 119 static inline void psi_enqueue(struct task_struct *p, u64 now) > 120 { > 121 } > 122 static inline void psi_dequeue(struct task_struct *p, u64 now) > 123 { > 124 } > 125 static inline void psi_ttwu_dequeue(struct task_struct *p) {} > > 126 { > 127 } Stupid last-minute cleanup reshuffling. v2 will have: diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h index cb4a68bcf37a..ff6256b3d216 100644 --- a/kernel/sched/stats.h +++ b/kernel/sched/stats.h @@ -122,7 +122,7 @@ static inline void psi_enqueue(struct task_struct *p, u64 now) static inline void psi_dequeue(struct task_struct *p, u64 now) { } -static inline void psi_ttwu_dequeue(struct task_struct *p) {} +static inline void psi_ttwu_dequeue(struct task_struct *p) { } #endif /* CONFIG_PSI */