From patchwork Wed May 9 07:48:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10388453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8992602C2 for ; Wed, 9 May 2018 07:50:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB1B328DA9 for ; Wed, 9 May 2018 07:50:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF73F28E74; Wed, 9 May 2018 07:50:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50FFB28E08 for ; Wed, 9 May 2018 07:50:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA9096B0364; Wed, 9 May 2018 03:50:04 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D55F76B0368; Wed, 9 May 2018 03:50:04 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD2316B0369; Wed, 9 May 2018 03:50:04 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f69.google.com (mail-pl0-f69.google.com [209.85.160.69]) by kanga.kvack.org (Postfix) with ESMTP id 770BE6B0364 for ; Wed, 9 May 2018 03:50:04 -0400 (EDT) Received: by mail-pl0-f69.google.com with SMTP id h32-v6so3305732pld.15 for ; Wed, 09 May 2018 00:50:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=kiPracHkUqfk1EQjDjNOp0CKxUyEP755SPg+D9Zk70Q=; b=nRrlKVw3ktsCCJJk44E+s7tdrJMmqVa7qPr1cg7hJJAKIqqMMAIKlBzin8Rp9vAG6W s+ThjUgXLuBkx9tikI2fPQL3Mbm9+F3HDmzFqySEFUv0xGb7BKAPIbxJ1UdS/vqXkQQv DFkNLKcb53VV7e0lRzk9gPtJvjOghnYLf6HRFeDD6MrcUVkIEB10dNWuLgnafmbbJa1p qldHnPWl9kcZ91vicYnMTHuZc9C5NSx+SPSTvaOgxhknLF//hwbAJ6mVDJMxO7GLyZYN AygeuYUjcjzuzPOPQ3628RtUztpTU4sz7TgW6uqpiNPM1CEMGZY7Ve0ovzHL0NyuOTn3 o7iA== X-Gm-Message-State: ALQs6tB//NFjuS4UiDv3XBXo1YTdHAq2bT9ECt9eAznXnXvUpQRR/ph0 x+J3Mu5KjgKqD4JTSHHc16HWNzANwlHAqOv40nkUotxGuCWUIS/GLI5oslO3wmh7NInzAM+I3td RCtJ9moBVa3oUr/owXilrQgTzVlet7KsmPHzhjMTjUC7u0PyIFEzBL5P1saDtMUA= X-Received: by 2002:a63:9401:: with SMTP id m1-v6mr35203607pge.140.1525852204183; Wed, 09 May 2018 00:50:04 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoxwhmKowpibtiPi26rtGJVgoeSkfjD5ZYQ9nm7sQ2C7pQpRtbyqZUY9XqKihlNiHbYuwk4 X-Received: by 2002:a63:9401:: with SMTP id m1-v6mr35203577pge.140.1525852203454; Wed, 09 May 2018 00:50:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525852203; cv=none; d=google.com; s=arc-20160816; b=Szvpei3gD2JdBdc9+5AWRXz8ChUdvgo8x/tXJyIQTOKlzxkDNRTBBLNhVGazK+cElK oE0aiEUjm1vfNv2cY/gL/7Fy4+B0TkBfkJoScHjrP1jr9KqAWAVlDnRgiRLnLr5Wlm2y 0bRIwONhRC986JV0n3CKwUfmgtaxBxKzJTYC5R/XymOLNJx7l6Qod9d/c0fOCjgRgvRx YpiA5JW1lPJ1VSy1j+5UWmY+Yx+djBP4ueiU5AS6ZzIVo1MXqlWfUY7YFm+DRlUKRt1B 4HfuxtMIWQXlDlLOzBLkz2oVGNyBm+ynFqUXt/7jB9+rdUaB7pe37ZRtqaetQCqsvQ2L AaUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=kiPracHkUqfk1EQjDjNOp0CKxUyEP755SPg+D9Zk70Q=; b=ps5TP5kGkvZPa9uttdNae7ZEU/YdR3Z5drtS03u9JS1tGNEh/FBSZcf6W0wGEm655R 94ZFW5i5LW2I8cxJD2hNYdNiM26mfnaDXRK0+LOQkz+V09M2n3w4zoMuUeDTGqc5Ag6c CArzBndo2TzcGqyrdGz2mGlN3Szh1fic47Z3xe+mf7vgn1stajHHzJspos6GBI6bFf5Z owBJB1IKHEGWeZVOKvgBDPocswrte+ZuXn22vlE4nVCj16nFj/HQSKzXve0gF5MJyt1+ Jq7lCirwI+aL50c8+38bbp+vWYqhSkXVMJYhCADwvkVCTm9oXovdLjBiIvIZmzsGTGQB MPpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=GHb4FF7l; spf=pass (google.com: best guess record for domain of batv+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id c84si13332950pfd.89.2018.05.09.00.50.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 00:50:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=GHb4FF7l; spf=pass (google.com: best guess record for domain of batv+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kiPracHkUqfk1EQjDjNOp0CKxUyEP755SPg+D9Zk70Q=; b=GHb4FF7lGDF5f7mQezfGQ74sY lygPuzH+ET8INiY7UmHtVjRLvOU6/vQMoFZW3AKXOVNi4oqaHTYmRX3UaTPMCqpr49NTYqSn/NwQZ 8dmPdKY7ZWW0aPsIWGpDhppUWSZwrxRS2FyS/GV77DiTR6uP/zPHZdqXLa5AAHLXO3U+cn6GlF04b B9oaXg4uLlpuJkht6OZOmDhjLwovC8FyNHOWhAu7fO8JWTgoPQHkv37+mYA/F5jE+0yryg293Lxtz 8E71UksqgKBDjcHsZWZTF8StHQzZB6xSP0h2X8UEEN0OyXB9B6z+O2GfPK1sgcIEvEActBD9M4RUh J1yqaAAYw==; Received: from 213-225-15-246.nat.highway.a1.net ([213.225.15.246] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGJrH-0001mn-2e; Wed, 09 May 2018 07:49:55 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 22/33] xfs: don't clear imap_valid for a non-uptodate buffers Date: Wed, 9 May 2018 09:48:19 +0200 Message-Id: <20180509074830.16196-23-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509074830.16196-1-hch@lst.de> References: <20180509074830.16196-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Finding a buffer that isn't uptodate doesn't invalidate the mapping for any given block. The last_sector check will already take care of starting another ioend as soon as we find any non-update buffer, and if the current mapping doesn't include the next uptodate buffer the xfs_imap_valid check will take care of it. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 07d5255a0f9f..5da2e99b0559 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -859,15 +859,12 @@ xfs_writepage_map( break; /* - * Block does not contain valid data, skip it, mark the current - * map as invalid because we have a discontiguity. This ensures - * we put subsequent writeable buffers into a new ioend. + * Block does not contain valid data, skip it. */ if (!buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); uptodate = false; - wpc->imap_valid = false; continue; }