From patchwork Wed May 9 07:48:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10388509 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8A34B60540 for ; Wed, 9 May 2018 07:50:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D95028E56 for ; Wed, 9 May 2018 07:50:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7277B28E6C; Wed, 9 May 2018 07:50:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A659528E68 for ; Wed, 9 May 2018 07:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B0546B0378; Wed, 9 May 2018 03:50:29 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 95F5D6B0379; Wed, 9 May 2018 03:50:29 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D9F06B037A; Wed, 9 May 2018 03:50:29 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id 345896B0378 for ; Wed, 9 May 2018 03:50:29 -0400 (EDT) Received: by mail-pf0-f197.google.com with SMTP id y12so17631063pfe.8 for ; Wed, 09 May 2018 00:50:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=mkiQrVkgU3P38eG8wT5JelNiVMWL9IpaIco07dhQPyY=; b=ASjKcB8LOq2I5oKFFpPo0X8cKcMn2xbl3xgoC1zu1zIXYT+554+0pJaNcQuA5OpvpV XPqx85YZnqyn1Pg1b9VsBYCXEZ/PuPkik6UB+8RtLckVFiCZ8VMlG5s1kbK/hIdnMULc 4/iW6F48BCteW4EFOrvV2HRGN+vg/CB9c8TqAjjMwKgdRGVum8ColhS5ikEzZBz322vR xR85wL9a2ZgWegxTXimCzPoxA0K0l9+fcnzBZ2A6MFa7Jk9upJv6BsKEKTYrDIA9oeof 04Tp/cZegRG8vqTTkQ8BmuXcRvlVm7ArvLIsELUEroOFVS7XzvtBgtpe/fAhb9w6Wusw 6vxg== X-Gm-Message-State: ALQs6tDgmp631ktIC001hXsBc95hZchBcjqVAjRdv4EZccYxvKt4Vk2f Ml2tH3LiZx+eUFa8lYoYg5gUGb2Qba8T4VCQrtayac6JrF/P2vaJ5cDV8b+3t9HQM86Lqqe2YGi DE9IiWuBnUaR7zdFSXE84PZyCEQcio2Zctvl5v7rlI46AIFARIJ4NpiSBy2JHjEo= X-Received: by 2002:a63:be42:: with SMTP id g2-v6mr20113701pgo.44.1525852228894; Wed, 09 May 2018 00:50:28 -0700 (PDT) X-Google-Smtp-Source: AB8JxZptAw8DpTmkreVRMf/aIxx8ne6IF3SQAnQGXtt/X/OzDD3rPGjNXyaSTPdUJj7kspBhV921 X-Received: by 2002:a63:be42:: with SMTP id g2-v6mr20113679pgo.44.1525852228264; Wed, 09 May 2018 00:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525852228; cv=none; d=google.com; s=arc-20160816; b=Yu0yfTNnKZNY762k2tXJUHDhHR42t/FsxSPg9FuyrAHS5Hbxxnq9zIXH8FZfz9O9C8 stfslnUTi1drZt0kKh1NVHq8BNN8UglHSnRfpXkNIlb7+qHvcRJuUfEQF9InYZbH5gQd zsqKg3C1o8/weAGx1mGNJ9xDmUUr5wRIu7khavVRJsv4X6ZNZe/7C17EyT/n/Cs0V22t kSLuM7ISzDBo4M9gvh4J3IXYTFDpjbYZVKHceYr+xe/08t12TMbKQMdL6e3s/uDomCnt nZ2stP1tfVuO3xaa7ue+4/jopoHy7jLwQMv6RLb/NuL7y1lXAxUkOucAGJmC623iAZ1g +ciw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=mkiQrVkgU3P38eG8wT5JelNiVMWL9IpaIco07dhQPyY=; b=ursT2hHThT6K5e4YdZGSMVqvK+JzzEDFrnHfc3iW+7HZRPmMRkOKldyXw2hXrHrdQp 6/6BYu7fyBAOaVidQsg+ZCU7TfdrfDW2Y2fvFiy2WXXvSRrS47ygRvfztESx13fJxxlf u1UfsnZZ5cDR8DGZsC7S4t8En7CfQLdoywTeaVvqil1apF4hwVayuWjKDXr9XFT4ggnt AqR6tosk8JtWdCtFII3Ko+lifjSAf4HZ41W+Kl9Yq5SN4YXir6VYcC/WA47a4JuJtzb0 aBbu/7vFepyAjfQHrMdLalVdHzJucpYyLECHby3kmfMPhrfP4ajjFiRT84okecgWqqtb TAuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=R5e9yWLO; spf=pass (google.com: best guess record for domain of batv+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id z23-v6si24686175plo.492.2018.05.09.00.50.28 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 00:50:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=R5e9yWLO; spf=pass (google.com: best guess record for domain of batv+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+e0efdd19ce80d487e3da+5372+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mkiQrVkgU3P38eG8wT5JelNiVMWL9IpaIco07dhQPyY=; b=R5e9yWLOqfSf0wf7Z5wBYY1KY DID8mzyT1BFkCnsbWA0KETFHCWCDTPtbbeRIviusihLlqHw/XYbegLWa+DmdTIiq+UwnekD48yFKP RB4NgEA2FlK6EnfhcFZXnw8FUs4HjO64YmHVUBek2lLv8o+G61Od9mZrkGHL5+VUmHwXLPoiKHbxO Kj/+zRRtkUoydlGHEF0wKTd+dE4kp8+QHBHSir3dCAJM0EFaM9078eqhm8gJN/gsNgZACqzGMMqIh MpA1+l8Yt/v+a+ddXb0iI3E1bEy728r0dZF7F3X7nzmfbffI+d4EOQXiOsGuOYfpnld0wRTu3jo1a J1ZZrRa6w==; Received: from 213-225-15-246.nat.highway.a1.net ([213.225.15.246] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGJrn-0002vE-1A; Wed, 09 May 2018 07:50:27 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 29/33] xfs: do not set the page uptodate in xfs_writepage_map Date: Wed, 9 May 2018 09:48:26 +0200 Message-Id: <20180509074830.16196-30-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509074830.16196-1-hch@lst.de> References: <20180509074830.16196-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP We already track the page uptodate status based on the buffer uptodate status, which is updated whenever reading or zeroing blocks. This code has been there since commit a ptool commit in 2002, which claims to: "merge" the 2.4 fsx fix for block size < page size to 2.5. This needed major changes to actually fit. and isn't present in other writepage implementations. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index dc82d4e71a64..dc92f23b0ea4 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -812,7 +812,6 @@ xfs_writepage_map( ssize_t len = i_blocksize(inode); int error = 0; int count = 0; - bool uptodate = true; loff_t file_offset; /* file offset of page */ unsigned poffset; /* offset into page */ @@ -840,7 +839,6 @@ xfs_writepage_map( if (bh && !buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); - uptodate = false; bh = bh->b_this_page; continue; } @@ -880,9 +878,6 @@ xfs_writepage_map( count++; } - if (uptodate && poffset == PAGE_SIZE) - SetPageUptodate(page); - ASSERT(wpc->ioend || list_empty(&submit_list)); out: