From patchwork Wed May 9 08:54:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lu X-Patchwork-Id: 10388751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DF8DF602C2 for ; Wed, 9 May 2018 08:53:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0D9B288CD for ; Wed, 9 May 2018 08:53:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5A0628E3F; Wed, 9 May 2018 08:53:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 744FB288CD for ; Wed, 9 May 2018 08:53:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F8656B04C3; Wed, 9 May 2018 04:53:39 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 7B9476B04C6; Wed, 9 May 2018 04:53:39 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64A1A6B04C6; Wed, 9 May 2018 04:53:39 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 216AA6B04C3 for ; Wed, 9 May 2018 04:53:39 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id n2-v6so19485715pgs.2 for ; Wed, 09 May 2018 01:53:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=W2eHiyd8AlflS8Wp1FzNkWsH9oQoACnDauB/NeNrwJo=; b=MY7wzDGZDSXlmXlejcw72lR+vjXTqf7zthQsHMT7rzqfBU6/K6ywripU0cdQ6PMYQH ZNpCMC/iwOLgBlPtXc+t3Ova28w0kIDc46SPWpn3gSZhbBwbBWAbKPWH1Q9wFXVDSMMb vnrD3cfohWfPbcPY5YJEEThzgPyNhDv65OSX1q8jmjY4oKegzvTki9Z51o4Ogp7j2Zkd VpAqc3Myr5xtklFxabKpwY7QYXRuY5m/FRAuv12sPXmAVz9FA68KAxoX28FZA8VpeEgM 9YTIA7FVT1utrFsoncmzQ2Lq2ws3Vb+gMAVw4RPrqwyiome4EYwlaNe6uw6XfmfJWhwb 14uw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=aaron.lu@intel.com X-Gm-Message-State: ALQs6tC7jnYhmF47M0k3wc8q4zdjrmdyK0dexJNyY8tHNT/wMZ4c5pP9 IMyiF49C0Or+HCIOkcvhvcDLaponrV3J9BzFbBRCtdv4WVwkCA6no//K7vgwQsd0xdUU3Lzz1c3 kJhHYHUfocrTLB3L9OlTRSOlXsEbUrlyAH8SA9nBj8ki3vlg/tvFVUsEjlP1GtEJ7uw== X-Received: by 2002:a17:902:10c:: with SMTP id 12-v6mr44958280plb.252.1525856018840; Wed, 09 May 2018 01:53:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoP/PrgDa4O+XSfT9orsOQs8a6//moU1V6eKxDjubdcZCv+CPyoV5k4sYW1df2K4XiuZw7K X-Received: by 2002:a17:902:10c:: with SMTP id 12-v6mr44958248plb.252.1525856018076; Wed, 09 May 2018 01:53:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525856018; cv=none; d=google.com; s=arc-20160816; b=o+P6gKieKwao0PKV83uHmuEpl7sjRRpy3QOYR4SYHjGeokgEVbdy/9Fxrhvu4djcA9 u1pMVS+NL/hN0t3JaTUNR1azHGPCEc0lMRZKflwYaCQkv4YzQlniSsZ5L+EFpi+0IFte 9J4OlZWk0qatVPTmT7SI1oNYpaQaJmgSQpy0TH+/HfsfNwoXKF3rCR/d39E12JKJs6O4 bJf5c28wqk8CvNIeSkADjO65ukEbc7I8kkjf0diQfWLqTIq8SqIoCKq0VWs87DBcT7dt dfGuwy3D/WUnWEUDMp8Xz5BvwNV3OEoJQqjgd7pQ7tKvimMF9qntwxwXZjYOEDvkUkTU BPwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=W2eHiyd8AlflS8Wp1FzNkWsH9oQoACnDauB/NeNrwJo=; b=nxYoN5rPB1R0NRWvMUPWK2YBcfdeVfez1wS+GAbVZ1K+D3XkPFPQiyQq20ptfmSOo0 iRjgTX91eG+45DqImUO9JOpS2CkOP9SekpRjrxtWCC6M47ggOUx2dmyxF+N85EEW5rpr 2JFv8euPRxVgIjDdvEsaZTtd4+8DaIFXkEa2sVMdrWzxlndub5GgmefTDplgyjs+DbDe tkaSnDQU2taSCddU86Xj4MeuyEfCLeyi0h3qJbeYMgWIOiwfOkOrXhUH1+B3+NKWrzc8 MzFIG8rcKg4sPCis7RJacFasVR93nlzInRN3Npc/0vrkS6IsmYdhpu/rlkrrLTRc/sqU Xyaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=aaron.lu@intel.com Received: from mga02.intel.com (mga02.intel.com. [134.134.136.20]) by mx.google.com with ESMTPS id x1-v6si25257590plv.520.2018.05.09.01.53.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 01:53:38 -0700 (PDT) Received-SPF: pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.20 as permitted sender) client-ip=134.134.136.20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=aaron.lu@intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 01:53:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,381,1520924400"; d="scan'208";a="227055183" Received: from aaronlu.sh.intel.com ([10.239.159.135]) by fmsmga006.fm.intel.com with ESMTP; 09 May 2018 01:53:35 -0700 From: Aaron Lu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Huang Ying , Dave Hansen , Kemi Wang , Tim Chen , Andi Kleen , Michal Hocko , Vlastimil Babka , Mel Gorman , Matthew Wilcox , Daniel Jordan , Tariq Toukan Subject: [RFC v3 PATCH 5/5] mm/can_skip_merge(): make it more aggressive to attempt cluster alloc/free Date: Wed, 9 May 2018 16:54:50 +0800 Message-Id: <20180509085450.3524-6-aaron.lu@intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180509085450.3524-1-aaron.lu@intel.com> References: <20180509085450.3524-1-aaron.lu@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP After system runs a long time, it's easy for a zone to have no suitable high order page available and that will stop cluster alloc and free in current implementation due to compact_considered > 0. To make it favour order0 alloc/free, relax the condition to only disallow cluster alloc/free when problem would occur, e.g. when compaction is in progress. Signed-off-by: Aaron Lu --- mm/internal.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index e3f209f8fb39..521aa4d8f3c1 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -552,10 +552,6 @@ void try_to_merge_page(struct page *page); #ifdef CONFIG_COMPACTION static inline bool can_skip_merge(struct zone *zone, int order) { - /* Compaction has failed in this zone, we shouldn't skip merging */ - if (zone->compact_considered) - return false; - /* Only consider no_merge for order 0 pages */ if (order) return false;