From patchwork Wed May 9 19:36:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 10390679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D043660236 for ; Wed, 9 May 2018 19:38:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDC9928469 for ; Wed, 9 May 2018 19:38:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF43C284D4; Wed, 9 May 2018 19:38:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 208E128469 for ; Wed, 9 May 2018 19:38:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E53406B056F; Wed, 9 May 2018 15:38:47 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id DBBCE6B0575; Wed, 9 May 2018 15:38:47 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0E6C6B056F; Wed, 9 May 2018 15:38:47 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr0-f200.google.com (mail-wr0-f200.google.com [209.85.128.200]) by kanga.kvack.org (Postfix) with ESMTP id 1F0786B0572 for ; Wed, 9 May 2018 15:38:47 -0400 (EDT) Received: by mail-wr0-f200.google.com with SMTP id k16-v6so24460964wrh.6 for ; Wed, 09 May 2018 12:38:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=YcuKR24yVNoTBGW1ncqEnJyEMmQl/2xqgsaQl6xAK+8=; b=HJEX4HseLD0kSv9xlbTki5vk7EdZe1uAUsqYkLkJGPhpZr4HDrhpoXCEAX0sTIkgAR QXm5G0EsjsUKZSMBOnbyiIceBBzd+x6fvuAwhwgz22QRwOHH50R4Aqo4VSfETJmrKHVJ z7B7aEH/WuG3jjXYX/VoC8oLtH15mJc2/4q5m9Tl9+qRNNwUQm1gw5xEI+HlfS47fSQ2 m0HhTkoSP6BR/yGaEr56w6JgVorgwRqtniw/5tFkuCkXl8Px6B+Fi54G9E141WPyOsDj Bt8BoGIakdVIjvzp/ZuHhkkLbJTnutz4ZJ4XJ7NK77ahpyIMWdpvsteJkoIZ9ZyI5g7v KcJQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de X-Gm-Message-State: ALQs6tB945txpNSTi1M8iAVkt2mhLK2BN1AP2fpCQMrkc1oH5Nv06OwF OGbLKocQjCpfQpadFPsyUDhsxpQdvZivY/9KGboDhBPVNReyqjPfT7JodGzhXPd+lJi98MTbeCk CiVPtbcEO61VRNjbudatP3wZVbRAGf8E4pdwM1EkAlzBFYf4Re1HAN7YBzOi+6Pq6pA== X-Received: by 2002:adf:bbce:: with SMTP id z14-v6mr39134458wrg.183.1525894726691; Wed, 09 May 2018 12:38:46 -0700 (PDT) X-Google-Smtp-Source: AB8JxZodsl7ofzhAgfYawYSmUtiH8buJzlQ9mBoqX1EvJG8RlDMQQ6Xt0+U/wAnCe4BhfawHfhq8 X-Received: by 2002:adf:bbce:: with SMTP id z14-v6mr39134431wrg.183.1525894725937; Wed, 09 May 2018 12:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525894725; cv=none; d=google.com; s=arc-20160816; b=QmOswLHnxSQuR6xMy+ZX3orRCBrrgVXDFHAWdnMzryGlO9TdLClhUsYVq/Z/sRj7vk XEAutZOvLLVVT8vWAvAUX9ShYgKCmJAuvnOrUSL7WSpkZu5tpa6NXJN3c15/zQOnr/WF ldwgE7gBa8WwQAmkwYqmqL8RVIyrR/vYY3NiTqwnqHRzi0PYqf/lzYU4zp0uWgcJ5Hvt 81LLlUg9C3zCK1j+XYgEBN5CdEfwujfpr0hJYssWb/J1newsiHJDjt2HQm5pcWZD+kV0 b8ke0XL/d4Ij2uhN91ibPXwo7AqnukfKrXI7fSbhjGDuyIeTpXCyQHKxUgKHShyqAILJ jnpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=YcuKR24yVNoTBGW1ncqEnJyEMmQl/2xqgsaQl6xAK+8=; b=jf4M5Jrqog6/qnVgDXvHKTn1+jfYIvfL0I3MjKXiSq/Ltxsv0bTl224PziXM6SF6mA QWipR3Jh5S9TB3uUPkllHtpWebsdHrRSeVpR/XnGfJWwq2fZvbgEjqMKwRZnExRh1WGA T6IBunXnMko3z5bDXaRO53VVvo5EtJTdUmvcVaD8ZeGFYDOCRo6ACqmi4sYeE9fS6SXB ylG57fak438I97tsHfXVNjf62iKwTk/xpMkH+ahT7/F6PQFq4wDi1iQ7Si8sYV7vhkga lpW79yboEYcL/tLkWjuNnHzCfL1um8ZmVM72r/YdaK3ZJHU7w279izOFw7QaAdLWuPPZ p5xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id y186-v6si8558240wmg.11.2018.05.09.12.38.45 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 09 May 2018 12:38:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1fGUvB-0005v9-Mj; Wed, 09 May 2018 21:38:41 +0200 From: Sebastian Andrzej Siewior To: linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, Peter Zijlstra , Ingo Molnar , linux-mm@kvack.org, Shaohua Li , linux-raid@vger.kernel.org, Anna-Maria Gleixner , Sebastian Andrzej Siewior Subject: [PATCH 5/8] bdi: Use irqsave variant of refcount_dec_and_lock() Date: Wed, 9 May 2018 21:36:42 +0200 Message-Id: <20180509193645.830-6-bigeasy@linutronix.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509193645.830-1-bigeasy@linutronix.de> References: <20180509193645.830-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Anna-Maria Gleixner The irqsave variant of refcount_dec_and_lock handles irqsave/restore when taking/releasing the spin lock. With this variant the call of local_irq_save/restore is no longer required. Signed-off-by: Anna-Maria Gleixner [bigeasy: s@atomic_dec_and_lock@refcount_dec_and_lock@g ] Signed-off-by: Sebastian Andrzej Siewior --- mm/backing-dev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 7984a872073e..520aa092f7b2 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -485,11 +485,8 @@ void wb_congested_put(struct bdi_writeback_congested *congested) { unsigned long flags; - local_irq_save(flags); - if (!refcount_dec_and_lock(&congested->refcnt, &cgwb_lock)) { - local_irq_restore(flags); + if (!refcount_dec_and_lock_irqsave(&congested->refcnt, &cgwb_lock, &flags)) return; - } /* bdi might already have been destroyed leaving @congested unlinked */ if (congested->__bdi) {