From patchwork Wed May 9 19:36:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 10390687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C40B860153 for ; Wed, 9 May 2018 19:39:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5C1228469 for ; Wed, 9 May 2018 19:39:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA0E5284D4; Wed, 9 May 2018 19:39:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EF2528469 for ; Wed, 9 May 2018 19:39:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8F1B6B0575; Wed, 9 May 2018 15:38:49 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D680D6B0577; Wed, 9 May 2018 15:38:49 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B98F26B0576; Wed, 9 May 2018 15:38:49 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 4A6346B0575 for ; Wed, 9 May 2018 15:38:49 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id 54-v6so19106349wrw.1 for ; Wed, 09 May 2018 12:38:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=nOyZYX/Ivc1o5BOOrgBvb7XeN34NGIaj1SE+Veq8ZXg=; b=ucIa+XbkuqnlWw1AYkM/kzSTnv06krhQrnkQrSDMqWhNbz90HEr6PmXr6PoAj3BHgW DJ6fHjKD5fpR+NNxYDMc0XWCCkpDIAwPJcJeWff/yYUC4LbVb/5udS8s/JY3KVxlPixd cvlPgb1e2t8t8qw6ACahHwAQN1+XTduD1hbMT4Eqfn0trHCvPYdhPI+wWEben4JhIDWK WjtIDKpoSz6xF9WfyiyICRCSnOGszuv2OeMRTpmnhYjOUR5yN9TNGHC1XnypihRKOPWp 9FZRVDeeG7EhxF3bV3XVClAlvU8DSjW0PNkySDNRtp0/SBrsvrVt/K8pim0zJDj4J+Xc arAw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de X-Gm-Message-State: ALQs6tBT/vgGqE2kbSa9IATIUNCRsQdIZgQSoCbwCd5ap+6Xu7XlHY+9 qgB3owxW941w/zoZZb/fsGkaIS85RtTzMbKqCKuIFpAhOxYi9IFPOyz+m1JGHcX4Y9I/Nn7vvPY Iwy29Qjt09vkhGqnFI+iWJ62caa4zp9TIMeb2FCypHg0aA6iJDwYPsOOfl4hMCWFH2w== X-Received: by 2002:adf:cd08:: with SMTP id w8-v6mr39662402wrm.187.1525894728890; Wed, 09 May 2018 12:38:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoVgkmKvHqhTFUFepKfQnJ6F6RYKT1yE1NYYxgavn607JYqkgT6mJujzXIWw0Q5FOCyRgyx X-Received: by 2002:adf:cd08:: with SMTP id w8-v6mr39662379wrm.187.1525894728240; Wed, 09 May 2018 12:38:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525894728; cv=none; d=google.com; s=arc-20160816; b=eg68w/FNCLw/oa5y9+3CpKjxqvbMUOn5++mVz6xkZpDryUxhbR9MZ1Ll0ABAMdG3IT y5qSX1blbBuDb3HTgKJLx+rmZDY8J0PQiB5rv/1ZOdAGzqjn9SFfztJd43O7Afi/nfyb wx5hGNnfhUYHRjhujTxPJ8MVYXsqK3AMbwHift6YpASVvGzhGB//h9Uplas9+LNLvvDO Zqe8KrgJnqgKCncx02QMyriB0kEwjNy/IkmVdVU6EQZsq2aIIkuUvC4YKOmbZzrqClzf z5ZQ/azdoWqtTJBaf1cWayfYEPsIJtm2GVicZmWYhlXusj3deUtH0r8caIhgRbpaT3Oh N/Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=nOyZYX/Ivc1o5BOOrgBvb7XeN34NGIaj1SE+Veq8ZXg=; b=Fo/YkJRiGUHbjVYe59+i1pLsEa925n8xguwgsyoKJO5vYfC5ga8zKFO47AaxvKUXA5 bZTuXUAWuPVdIWiIVREUAlGCggZ7WGX7u12Zmeis25/IMStGEItF84uqVh7/SoSFBCLg ZEhZvu76CRIbepz3BTsb/vm248sB5eJ4/g3yAArzXXURsc8lT5bQ+LzOR40xjRl73k/3 VIq4Lkoxy5m3pks9/Ue0/R1lXYKZa4ORNawNgSeYtqF145n0s6qXV00/zGcXYFz1mt18 bawfL+qMAlmGUbyfXd3/PWuYOJZZaqrqsVcz0Kl/UUkCNa/rUXB3P/QEdkHvKgGpLbzP CgjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id x1si7874118wmh.186.2018.05.09.12.38.48 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 09 May 2018 12:38:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1fGUvE-0005v9-2p; Wed, 09 May 2018 21:38:44 +0200 From: Sebastian Andrzej Siewior To: linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, Peter Zijlstra , Ingo Molnar , linux-mm@kvack.org, Shaohua Li , linux-raid@vger.kernel.org, Anna-Maria Gleixner , Sebastian Andrzej Siewior Subject: [PATCH 8/8] md: raid5: Do not disable irq on release_inactive_stripe_list() call Date: Wed, 9 May 2018 21:36:45 +0200 Message-Id: <20180509193645.830-9-bigeasy@linutronix.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509193645.830-1-bigeasy@linutronix.de> References: <20180509193645.830-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Anna-Maria Gleixner There is no need to invoke release_inactive_stripe_list() with interrupts disabled. All call sites, except raid5_release_stripe(), unlock ->device_lock and enable interrupts before invoking the function. Make it consistent. Signed-off-by: Anna-Maria Gleixner [bigeasy: s@atomic_dec_and_lock@refcount_dec_and_lock@g ] Signed-off-by: Sebastian Andrzej Siewior --- drivers/md/raid5.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 28453264c3eb..9433b2619006 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -414,9 +414,8 @@ void raid5_release_stripe(struct stripe_head *sh) INIT_LIST_HEAD(&list); hash = sh->hash_lock_index; do_release_stripe(conf, sh, &list); - spin_unlock(&conf->device_lock); + spin_unlock_irqrestore(&conf->device_lock, flags); release_inactive_stripe_list(conf, &list, hash); - local_irq_restore(flags); } }