From patchwork Fri May 11 15:45:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 10394633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DCC0160153 for ; Fri, 11 May 2018 15:45:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A7E428C7A for ; Fri, 11 May 2018 15:45:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F26F828F39; Fri, 11 May 2018 15:45:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A658A28C7A for ; Fri, 11 May 2018 15:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C828A6B066F; Fri, 11 May 2018 11:45:23 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id C32626B0670; Fri, 11 May 2018 11:45:23 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B49346B0671; Fri, 11 May 2018 11:45:23 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f199.google.com (mail-qk0-f199.google.com [209.85.220.199]) by kanga.kvack.org (Postfix) with ESMTP id 8859F6B066F for ; Fri, 11 May 2018 11:45:23 -0400 (EDT) Received: by mail-qk0-f199.google.com with SMTP id 39-v6so4758196qkx.0 for ; Fri, 11 May 2018 08:45:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=E0wKMiCMaLBGP0CG1gJX85Rt9z9zKnClAvFyNrqVrkc=; b=SUs92BCyLTeg6KjL4ChKbIy7nnWok8Tw7qKIjPWiMcHrWLY28simvPLCjmDjIb6EUl zjPx8Hrg0+wIUttFhv5+oQn1AFAJ4CRfS2gPokj1xXOJRG/YYiJBGEDkcLiYyuDMSe5u YdyltFHaA4LU2RytQm+acviCb/T7LPXmd/HrP7L/M4gSz+sygEO5GNsYBGoV2resJ8Yb U5AOPVEz+SDKef94RTA8UwJwPTBQaTF393NDd7r1LUW1Xd6Ic1aHRqzTwTdIJcqEkaNS 632GA2lF4YKSjXC9msxdNNUpkL58Y+9NYBLO26vgl/LJUiw5zlZgYT19qW2gGtqWQyqU 3bfw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: ALKqPwfLrC4NQ0T1E7LMHc/6aFEkIhvUTIPf2zCQq/Zaj39C6b6ZZrnY 0Tax8fOK4ggbrw45HKLXiGXu1+fwJK0+2/RMxllYDoLnP3Mf7phpK6Z71LEFBuRQsBzlchMrqXe 5QI6H7TUauMbNBJVBCIzQzwmfyVwyVq+okTYGTlEnojRbLms0Ol1LhLg+dPDIqt2tVQ== X-Received: by 2002:a0c:8661:: with SMTP id p88-v6mr5822816qva.56.1526053523312; Fri, 11 May 2018 08:45:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo52CP+dJf6mYWjW/rCzU5EDpQaDi6Si/zkZFls+rHHHhsuFoP8kxNf+4U/v03tgi+RhyI5 X-Received: by 2002:a0c:8661:: with SMTP id p88-v6mr5822760qva.56.1526053522392; Fri, 11 May 2018 08:45:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526053522; cv=none; d=google.com; s=arc-20160816; b=t0KcdtBbAB3e6/g5dh+buf7s2qcnFakyGnrMol1KknTbInVgm7Wo4yBnnD8z4MMzmB hHZBbi32i9L55QmUKDT8nVVHlClgK6qlHpB+xb2yWGw1RZ47QfhFrPNa/gPwbWP3CbgL 2tNw9KHx7ir42SKmP1GF01ULM9XGMuggwaHLIfytsigiC1obBQ26TDao6bCruof71lgT T/pS8wAytt3YfyuyhCWRxx5R9EQfeCpufVjenxRkp62GNfS0Bx1ZjxbFtxrze3ylpY1n 0OtV+sSUmOK3hkflKBiWhBtmyCVmKTX0Y5TM1n0fQ58nRlP5QmsKK3zpgQ0Ol9brD+r5 fN6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=E0wKMiCMaLBGP0CG1gJX85Rt9z9zKnClAvFyNrqVrkc=; b=ANe8TsUUUu3MEOQ2+AKgpqJkKMC2/EQy4Faf5KZr+UHQbRrwBn1fc/DrPIAECqiFEL 6qzfXk9C4jA9HtWEshfmHour7nBPzFIAKDz1OIdNA4n4FU49/pKg02exPeeioJWTEKeV LNaSh2V3KXuAok6zbrO3a8FIKHyTx6NCUzTR5yhtCqGL5L4tKeMuQ3pUrsgDzotZh0oJ 5pWZmUmqwLixatgrApEE7zyJiEThzAuN9SsqPSTAoWkAppH82HF4cnPN4C50HegH/X1H mPM5HCdnWJ40520Wp1Gn1RnqkAd63nYo1oVmyuzdtXbFknidLTvyWRbwe2Pe1gAVIvr9 Nq9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id a12-v6si1621139qkc.41.2018.05.11.08.45.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 May 2018 08:45:22 -0700 (PDT) Received-SPF: pass (google.com: domain of jpoimboe@redhat.com designates 66.187.233.73 as permitted sender) client-ip=66.187.233.73; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jpoimboe@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AC2E818A6B6; Fri, 11 May 2018 15:45:22 +0000 (UTC) Received: from treble (ovpn-124-84.rdu2.redhat.com [10.10.124.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A1B97D55C; Fri, 11 May 2018 15:45:21 +0000 (UTC) Date: Fri, 11 May 2018 10:45:19 -0500 From: Josh Poimboeuf To: Randy Dunlap Cc: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, Peter Zijlstra Subject: Re: mmotm 2018-05-10-16-34 uploaded (objtool) Message-ID: <20180511154519.w6bbhptv67fvsgnr@treble> References: <20180510233519.eYStA%akpm@linux-foundation.org> <20180511010122.xvkjqgx7yye77le3@treble> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180323 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 11 May 2018 15:45:22 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 11 May 2018 15:45:22 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jpoimboe@redhat.com' RCPT:'' X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 10, 2018 at 06:06:38PM -0700, Randy Dunlap wrote: > >> Hi Josh, Peter: > >> > >> Is this something that you already have fixes for? > >> > >> > >> on x86_64: > >> > >> drivers/video/fbdev/omap2/omapfb/dss/dispc.o: warning: objtool: dispc_runtime_suspend()+0xbb8: sibling call from callable instruction with modified stack frame > >> drivers/video/fbdev/omap2/omapfb/dss/dispc.o: warning: objtool: dispc_runtime_resume()+0xcc5: sibling call from callable instruction with modified stack frame > > > > I don't recall seeing that one. Can you share the .config and/or .o > > file? > > > > Sure. Both are attached. Here's a fix (applies on top of the GCC 8 patches I posted this week): diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 9bb04fddd3c8..a358489a1560 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -961,11 +961,15 @@ static struct rela *find_switch_table(struct objtool_file *file, if (find_symbol_containing(file->rodata, text_rela->addend)) continue; + /* mov [rodata addr], %reg */ rodata_rela = find_rela_by_dest(file->rodata, text_rela->addend); - if (!rodata_rela) - continue; + if (rodata_rela) + return rodata_rela; - return rodata_rela; + /* mov [rodata_addr](%rip), %reg */ + rodata_rela = find_rela_by_dest(file->rodata, text_rela->addend + 4); + if (rodata_rela) + return rodata_rela; } return NULL;