From patchwork Fri May 18 16:48:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10411371 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CBD92601F9 for ; Fri, 18 May 2018 16:50:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB5B028619 for ; Fri, 18 May 2018 16:50:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B0178288FA; Fri, 18 May 2018 16:50:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B41528619 for ; Fri, 18 May 2018 16:50:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53676B063A; Fri, 18 May 2018 12:50:15 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AD80F6B063C; Fri, 18 May 2018 12:50:15 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953236B063D; Fri, 18 May 2018 12:50:15 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 4CADD6B063A for ; Fri, 18 May 2018 12:50:15 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id s3-v6so5061666pfh.0 for ; Fri, 18 May 2018 09:50:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=JW7ZWeh7Dx9ZhJ7wi1sm/SGCW78S6fO5bWHg9jx+qxo=; b=kqIJItnSst8vLkI6QC/vAoQRj5d77TnNudq0LtvYgG5nuoiHZ/GoknYpOoqaQ+zmpu JFPgtxLpqUUDTJyIhVK2TTa5S55UCu7TF1hkDoaUBp2FtQqenJA2cgM1O1M3dbdawvwd 8Mi7rPd38pqLUNclvx0o5wuWds14mR+P+xRRson8YyalW9SEw/jJESkXMQQ4CWo2hMDt 7zZgYV78r7aKnu/mcaxOSvTq6IjDQ5/rdtktIwAU6xU9lVBic9ZUetqiZfcwJtPwXcw4 iHMwUvI33bjke3s2ERYib77Tfm/BfWrvYv7a7ky/3kpqcHK6Z5bL7yT1saDvXZzapFuK dbFw== X-Gm-Message-State: ALKqPweLayXiO3DIWCAJvtTyf4diRVnwurGMZRAo26/NLJp+ra8FvwEF jhkoSlN6NZ1TbTVoXt1mr2SKreMBe+B0mnaWviCLaIA9/SsylniIZtOVHgJWP2WXaASIQph6qj2 8/Zq+RDUBqiiM8ZoZVOZKfVt5G6uhmqOhiBbt2/704Nfrjtgtp4aUC8SSdKTACyk= X-Received: by 2002:a62:74b:: with SMTP id b72-v6mr10141415pfd.133.1526662214999; Fri, 18 May 2018 09:50:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq0lWAKBWER0A/NwI/fH9krfXqK5nzRisw81VqhqgVj/mUZ/htx2xZ+aWNZ6WA8g3rwc1bn X-Received: by 2002:a62:74b:: with SMTP id b72-v6mr10141379pfd.133.1526662214381; Fri, 18 May 2018 09:50:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526662214; cv=none; d=google.com; s=arc-20160816; b=xGxrq5PWPyO/dBT+aHVJb97EjFt5cQONTIUyRCRnFjjjWZvuuH85ak1wv/80QuI6Ss U9TEGh0eUK4BjaBIiE2vUXE7QItMztCsNCkN0cITZW+HX625H8VCa5DsL785xI4XX9Z2 f1Nf5BkkYDtTkuEsDfIOnJtAk294vwhOdIpITcQ0exWqqcr/IlrxaMznqSND7ZByBUFR /Z9JNo2VHzYufKNquMXZnWZ4zuxLe9LJaYU33ScIXI97Hwv8PczLp3x8i2oGyl2150Ha G7lk+d+MeDZ6D9agLG6IbSVLkGlEKjI3eDkkEulRLzNNnUbw7xc4v5MoEVnVOqXajL9v 7nOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=JW7ZWeh7Dx9ZhJ7wi1sm/SGCW78S6fO5bWHg9jx+qxo=; b=RcaeaBuTqVyaUSjE3NtlzmLu9IW1CDZRzNIPtWV6szxrOrQugd/KoOAIRajPoVaDna i9goGXVuJ4InRNet6kRqWgWxC7yHPVuFHRSc6IV0VWRfcMpThjLs44EgsnyYOv/wZ5Gt ssji9WOW2vAdjWTuX/BhU1b5j1HUZPqqXEIgGiqzropES7hdqj4SI7uggHIZs00XUCBO MSAyjbxuhPsun2kq3ZGQ2LvsE3VYdUTrx4BPNUCx+Af+fw0XkSXNST+veYiQVqeUPnO/ RdWbs2TE5YwD2QXDAYCrZEX6fgXgra773bFpuAzeo7uDbFIFAMKwKQZ//L1rFDyffnN6 7Gtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=Q0Oi81vS; spf=pass (google.com: best guess record for domain of batv+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id h186-v6si6180701pge.324.2018.05.18.09.50.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 May 2018 09:50:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=Q0Oi81vS; spf=pass (google.com: best guess record for domain of batv+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+77ddf8e9b1b344f28472+5381+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JW7ZWeh7Dx9ZhJ7wi1sm/SGCW78S6fO5bWHg9jx+qxo=; b=Q0Oi81vSEJXDv71BZxkX016ar EQiCUba9ZtzNdSV5u8RNw3UHHbLx4wuweK959Uo0SFImMOKYUruQVW0vLNW2Nt3pbj6U/K5/3QTIo r+AszRorviK+7ivhEFsdz0sVtn91Gx0kNa+iqymwWa84uUGjS75WPDGk0wcw/dbSHLmXBoyvkFf4T Zp5SrkPkQL5zLdZiW6BM5HudlKUmjc5dDHk2HBYpgZj1T3G89RLF6wqljHAMZAlgLno3dH4vYkAeT 0OYdYLV/dReKpEU74rAsP6o1Vca9vM8fhSbv6ZH8j3GmWKdUt0ANbfK52rpYZFm9HJLf53PFywbpI mLfYqKGMA==; Received: from 80-109-164-210.cable.dynamic.surfer.at ([80.109.164.210] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJia3-00083t-C2; Fri, 18 May 2018 16:50:12 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 33/34] xfs: do not set the page uptodate in xfs_writepage_map Date: Fri, 18 May 2018 18:48:29 +0200 Message-Id: <20180518164830.1552-34-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180518164830.1552-1-hch@lst.de> References: <20180518164830.1552-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP We already track the page uptodate status based on the buffer uptodate status, which is updated whenever reading or zeroing blocks. This code has been there since commit a ptool commit in 2002, which claims to: "merge" the 2.4 fsx fix for block size < page size to 2.5. This needed major changes to actually fit. and isn't present in other writepage implementations. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index a4e53e0a57c2..492f4a4b1deb 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -796,7 +796,6 @@ xfs_writepage_map( ssize_t len = i_blocksize(inode); int error = 0; int count = 0; - bool uptodate = true; loff_t file_offset; /* file offset of page */ unsigned poffset; /* offset into page */ @@ -823,7 +822,6 @@ xfs_writepage_map( if (!buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); - uptodate = false; continue; } @@ -857,9 +855,6 @@ xfs_writepage_map( count++; } - if (uptodate && poffset == PAGE_SIZE) - SetPageUptodate(page); - ASSERT(wpc->ioend || list_empty(&submit_list)); out: