From patchwork Tue May 22 09:39:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10417701 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D158B600CC for ; Tue, 22 May 2018 09:34:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C03F628A10 for ; Tue, 22 May 2018 09:34:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4A8328A16; Tue, 22 May 2018 09:34:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5822228A10 for ; Tue, 22 May 2018 09:34:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E32486B0003; Tue, 22 May 2018 05:34:24 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id DDFD46B0005; Tue, 22 May 2018 05:34:24 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD05F6B0006; Tue, 22 May 2018 05:34:24 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 84A446B0003 for ; Tue, 22 May 2018 05:34:24 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id v12-v6so9103623wmc.1 for ; Tue, 22 May 2018 02:34:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=3ciLsnXAoto4zhn48QWVrugsGBJdMFN2Pw8z2+5G37Q=; b=t3TdM0ZLeiYG/YkIbc/9bXLO2a4B/0rPsodf7VnyCO1pcW9RKhBs8xOwP17wmaQWMc 51KE6jg+6c4fdbdgFj017ACZRmTmdhBllzn/We3caHMnA+qBfE7LwHXuaLEXBqpXuRnp iAtC1VS0Ci6wPF9Yv1DaqofrBoYNrYR6AFXAY9JuNmJ3a4M8lCftn078y2CJtCxS8J70 EWOncSr92T5hmwPFN2O8LjfkbqJmHF7UTiZtFTmM81KZvszYWBqASDG5BuFhLzKGbdx3 r9dGUpyfiJNyT85QP/1Wt8bcUYGAkPb5T7fATSPb0jSb7+5tuCcwHgHkzI0uNuXsDTHe mdIg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de X-Gm-Message-State: ALKqPwfsVFy5p1G9jJLctzI9Rw6vnCX168fkf/9xiYgCYNZUmLY3Q4Lp Z0zfGG3CX+jI8rb0SbQOnJSp3YszckPfC0V/PjdneotVHG8do0KCgynRJloHQZq1X8VQ+x+/O6m IAitLwGl/YZ1h4w/pVdwFgXFYApy0gNHnDBWUtLeQ4CYDBXlAn+gF/7Ov0AlE9OSU5g== X-Received: by 2002:adf:b0c1:: with SMTP id j1-v6mr16975506wra.3.1526981664108; Tue, 22 May 2018 02:34:24 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp5ovBPeeC2NRpb/h8LwKV6tEru+GxjJSNYmjG2M/83TVhK2j8u1PjKiid3BXS8CCpLKiRd X-Received: by 2002:adf:b0c1:: with SMTP id j1-v6mr16975445wra.3.1526981662794; Tue, 22 May 2018 02:34:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526981662; cv=none; d=google.com; s=arc-20160816; b=xWExNtQQOlxPZ06rrwvC3+2YbDAEIjjjDNUYRE/7gqoJe7X+R04BEpRRmp/bWh1ios LmMvaBF+dtss+mHTIILjmD3WSn6mJF7qpVZyfsUU6oQE7JGfLL6jrJ+vjjzf/hR8u2Lo h9o0mXIMi3PZBzJyp02aF84wTmI8+sV6Ky/7ifVbXOGY2SBvdXNrjK+J8hlUOMG0YbMg bQwWJR05NvB/rObolpFcjBC0Y6RTLAMMjk0yjoa1tv4eNh9k5VUCCDH70NMJqNwDFrzS VqxGpY/zbvaH6lz+RhMKtwcxjO6kVqIqvQYBvka8rUKYjmKYrX5sLK4WNmUVL3Uu6C5+ 48yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=3ciLsnXAoto4zhn48QWVrugsGBJdMFN2Pw8z2+5G37Q=; b=qGw4amhtg8bRjyrvY/MtW/ZOKflM9XEf2DZNEioQrvKz8wJHhJtT/N06iXHJ9r4IAq u7NaveMe1P1b4xxgDHXKAM4zhSvHzYmCACWWDV45EosRpPCMxZBF+nylcH8vpY9DRQmF p7G811u3Zs4qclqn6QM+qxpJWaSZXT6UemwIu2hmKTkdxaybH9+DUKm6lZZVNZakkg68 hU7ddA3tkY9EbP7ASQT00ncjnVx1Uiz8SEqbEi65h8gBhyh4uwXhvNFo5uFFrD0AsYjE s8ois0I9ZjOQz3W7pz9/SsTXclctWo/sxEr1HZ8dAr5rndQc1QU8bWRG3Xuo+u7c9Yk2 +LSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id y17-v6si6373233wrl.91.2018.05.22.02.34.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 May 2018 02:34:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of hch@lst.de designates 213.95.11.211 as permitted sender) client-ip=213.95.11.211; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: by newverein.lst.de (Postfix, from userid 2407) id 8A26D68C7A; Tue, 22 May 2018 11:39:37 +0200 (CEST) Date: Tue, 22 May 2018 11:39:37 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 16/34] iomap: add initial support for writes without buffer heads Message-ID: <20180522093937.GA11513@lst.de> References: <20180518164830.1552-1-hch@lst.de> <20180518164830.1552-17-hch@lst.de> <20180521232700.GB14384@magnolia> <20180522083103.GA10079@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180522083103.GA10079@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 22, 2018 at 10:31:03AM +0200, Christoph Hellwig wrote: > The fix should be as simple as this: fsx wants some little tweaks: diff --git a/fs/iomap.c b/fs/iomap.c index 357711e50cfa..47676d1b957b 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -342,19 +342,19 @@ __iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, loff_t block_end = (pos + len + block_size - 1) & ~(block_size - 1); unsigned poff = block_start & (PAGE_SIZE - 1); unsigned plen = min_t(loff_t, PAGE_SIZE - poff, block_end - block_start); + unsigned from = pos & (PAGE_SIZE - 1); + unsigned to = from + len; int status; WARN_ON_ONCE(i_blocksize(inode) < PAGE_SIZE); if (PageUptodate(page)) return 0; + if (from <= poff && to >= poff + plen) + return 0; if (iomap_block_needs_zeroing(inode, block_start, iomap)) { - unsigned from = pos & (PAGE_SIZE - 1), to = from + len; - unsigned pend = poff + plen; - - if (poff < from || pend > to) - zero_user_segments(page, poff, from, to, pend); + zero_user_segments(page, poff, from, to, poff + plen); } else { status = iomap_read_page_sync(inode, block_start, page, poff, plen, iomap);