From patchwork Wed May 23 12:55:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10421217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 792BF60224 for ; Wed, 23 May 2018 12:56:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 695832892D for ; Wed, 23 May 2018 12:56:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E1EA28F97; Wed, 23 May 2018 12:56:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3316628F95 for ; Wed, 23 May 2018 12:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78B8E6B000E; Wed, 23 May 2018 08:56:09 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 712B16B0010; Wed, 23 May 2018 08:56:09 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6291B6B0266; Wed, 23 May 2018 08:56:09 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 0A3AE6B000E for ; Wed, 23 May 2018 08:56:09 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id e1-v6so2332365wma.3 for ; Wed, 23 May 2018 05:56:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=GFOFsEyjYQPfkTx5NvDQwSlCXCH4zFnlrRlTsiILKEc=; b=BY8nQRUMZ+vTTicz9QVimuE8gTwOxLuzFbnygKMWkjuN8ivq5LdTjwjQmDc6zwx5zW iJKV4uCu0fUXlaMIZbfQNGMuxq+2yW5lEz6kexc7keDnNG+N3xx4X65d2DUkFl+11TXx NO5joa1QjjH2t593n9WBfdNTl0Ka99ik5+DcOLJ0RgLg8QrEKAFe6IeF+Lb8VmneBmWZ 51h2arbyUmYvuKCkJyRDpPhgeIzafguTjPUOMgH8RTXcu4tcF/qQIs/n/R3qTjdIoiD8 IZrrz2gffRT7OdkNDH+U74HtMVQ08FqXqKlDnoppmPQvY8rjvBEC88A5IUC8TJAhHPFu eq6w== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: ALKqPwebgqhOVfHYH6lebslPrkwFJkgWIQS+Nt+DR5jvcPZh7/bNz3I9 US+dTZR7Nt93LOUoxDCebbCWLGNMVindjYtfkZSjUlkoXt/f/4UeAikS6tc7TCUrV/Jr7n2qP7L owIQXzjGLKt9UP+ALesq4rwJ36UIHJCDxEuqSUKM8S6yf7SbA/LiwsaseM4nTUsCjoyaWznMSKy sTYv/u8MjyC+cT1eySDeKKuwvTJNiWQOZ5HFA+YQ8MIeKnMWqH/zBWzG7w2KU5SY3VO1hUlsOi/ gfV8D7P/EulzLPOBqcvGBmQ0lWzbqkT6+3LcaokCpMZX3ciFf6aevYYnPgnv16RcfuX8v1Y6DMm 8t3+NBYmqU7gBHL6qSYigELpvVi56b/T8Ju5WRMhjn8aN1pZ6mBxNZJdlI+AYG1aADdqcIC2fA= = X-Received: by 2002:a1c:b20d:: with SMTP id b13-v6mr4456931wmf.130.1527080168577; Wed, 23 May 2018 05:56:08 -0700 (PDT) X-Received: by 2002:a1c:b20d:: with SMTP id b13-v6mr4456887wmf.130.1527080167640; Wed, 23 May 2018 05:56:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527080167; cv=none; d=google.com; s=arc-20160816; b=V0ckBaCIaOZGInuFt5DnpE5euk5ym2FxkpCoZwhVI479l0ixPnV1JJRID6NJ1DfZjE BVPh+0lalCpif5WKQ0gCFA5La6uND6q5RBVMJ+hx3YsUVHtQgD7Dm2IAIAJtPQ/WO0JX rHvSRXZoGdMJOIpJyW942YPu9Clw8ErsDvg2j4hQe1Ou+H0+HLZAXe+Y3rUp25CDIuyp vX3pmMFEhC1XJ+Y4DBGkMiZXLZBlu8+Mux5YNp9SN9ecCmc0U+pUQZeQkuponJIyH23c 1JYHTa0gD2g2LtsjRo9QovYOzFK5QHSWnyOIRq8n4rWjZQGG/KJ/1I2apBk6MVGMqqCm kdXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=GFOFsEyjYQPfkTx5NvDQwSlCXCH4zFnlrRlTsiILKEc=; b=CUFD/HheJOky3zMliZrXPue0Yv5kVP+PwkhZypfuerJxX9jXzA5sNH63r9l/nYpm8L fZ0W5m1dfRFlvyJ1rMDCdXgpl82w1vKzAv9HituIZLMzl+gZGAnlcKMDawkSQhIqwAOh TXvb9rOB34ewUHQZWEl7e0O2AxwydiC2hM135I+tApiHO/AAy/KJLk7/t5ZfxkcreCMU ift3kcRy01XTxl4pVyYIcXm+6dfTB29e8otHSGZOrcP7v+RXLMFlbBvxplKASflnitLi +uODuEwl10folZzJK1Nub6vuCYTSxy/pLlRawF33aesTMDKrg7s4myv1ZSU2+pTjjSoB l4ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id v18-v6sor4281449wrv.48.2018.05.23.05.56.07 for (Google Transport Security); Wed, 23 May 2018 05:56:07 -0700 (PDT) Received-SPF: pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Google-Smtp-Source: AB8JxZrghwfkCnOpDL8t2REl1PR9DKPUxDofBtyM2jfegpLX20yrhjOKY7J6H//FFmbJd2luTKkjHQ== X-Received: by 2002:adf:bb4c:: with SMTP id x12-v6mr2222175wrg.244.1527080167348; Wed, 23 May 2018 05:56:07 -0700 (PDT) Received: from tiehlicka.suse.cz (ip-37-188-135-200.eurotel.cz. [37.188.135.200]) by smtp.gmail.com with ESMTPSA id u89-v6sm2643543wma.4.2018.05.23.05.56.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 05:56:06 -0700 (PDT) From: Michal Hocko To: Andrew Morton Cc: Oscar Salvador , Vlastimil Babka , Pavel Tatashin , Reza Arbab , Igor Mammedov , Vitaly Kuznetsov , LKML , , Michal Hocko Subject: [PATCH 2/2] mm: do not warn on offline nodes unless the specific node is explicitly requested Date: Wed, 23 May 2018 14:55:55 +0200 Message-Id: <20180523125555.30039-3-mhocko@kernel.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523125555.30039-1-mhocko@kernel.org> References: <20180523125555.30039-1-mhocko@kernel.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Michal Hocko Oscar has noticed that we splat linux kernel: WARNING: CPU: 0 PID: 64 at ./include/linux/gfp.h:467 vmemmap_alloc_block+0x4e/0xc9 [...] linux kernel: CPU: 0 PID: 64 Comm: kworker/u4:1 Tainted: G W E 4.17.0-rc5-next-20180517-1-default+ #66 linux kernel: Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014 linux kernel: Workqueue: kacpi_hotplug acpi_hotplug_work_fn linux kernel: RIP: 0010:vmemmap_alloc_block+0x4e/0xc9 linux kernel: Code: fb ff 8d 69 01 75 07 65 8b 1d 9d cb 93 7e 81 fb ff 03 00 00 76 02 0f 0b 48 63 c3 48 0f a3 05 c8 b1 b4 00 0f 92 c0 84 c0 75 02 <0f> 0b 31 c9 89 da 89 ee bf c0 06 40 01 e8 0f d1 ad ff 48 85 c0 74 linux kernel: RSP: 0018:ffffc90000d03bf0 EFLAGS: 00010246 linux kernel: RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000008 linux kernel: RDX: 0000000000000000 RSI: 0000000000000001 RDI: 00000000000001ff linux kernel: RBP: 0000000000000009 R08: 0000000000000001 R09: ffffc90000d03ae8 linux kernel: R10: 0000000000000001 R11: 0000000000000000 R12: ffffea0006000000 linux kernel: R13: ffffea0005e00000 R14: ffffea0006000000 R15: 0000000000000001 linux kernel: FS: 0000000000000000(0000) GS:ffff88013fc00000(0000) knlGS:0000000000000000 linux kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 linux kernel: CR2: 00007fa92a698018 CR3: 00000001184ce000 CR4: 00000000000006f0 linux kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 linux kernel: DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 linux kernel: Call Trace: linux kernel: vmemmap_populate+0xf2/0x2ae linux kernel: sparse_mem_map_populate+0x28/0x35 linux kernel: sparse_add_one_section+0x4c/0x187 linux kernel: __add_pages+0xe7/0x1a0 linux kernel: add_pages+0x16/0x70 linux kernel: add_memory_resource+0xa3/0x1d0 linux kernel: add_memory+0xe4/0x110 linux kernel: acpi_memory_device_add+0x134/0x2e0 linux kernel: acpi_bus_attach+0xd9/0x190 linux kernel: acpi_bus_scan+0x37/0x70 linux kernel: acpi_device_hotplug+0x389/0x4e0 linux kernel: acpi_hotplug_work_fn+0x1a/0x30 linux kernel: process_one_work+0x146/0x340 linux kernel: worker_thread+0x47/0x3e0 linux kernel: kthread+0xf5/0x130 linux kernel: ? max_active_store+0x60/0x60 linux kernel: ? kthread_bind+0x10/0x10 linux kernel: ret_from_fork+0x35/0x40 linux kernel: ---[ end trace 2e2241f4e2f2f018 ]--- Reviewed-by: Pavel Tatashin ==== when adding memory to a node that is currently offline. The VM_WARN_ON is just too loud without a good reason. In this particular case we are doing alloc_pages_node(node, GFP_KERNEL|__GFP_RETRY_MAYFAIL|__GFP_NOWARN, order) so we do not insist on allocating from the given node (it is more a hint) so we can fall back to any other populated node and moreover we explicitly ask to not warn for the allocation failure. Soften the warning only to cases when somebody asks for the given node explicitly by __GFP_THISNODE. Reported-by: Oscar Salvador Tested-by: Oscar Salvador Signed-off-by: Michal Hocko --- include/linux/gfp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index 036846fc00a6..7f860ea29ec6 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -464,7 +464,7 @@ static inline struct page * __alloc_pages_node(int nid, gfp_t gfp_mask, unsigned int order) { VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES); - VM_WARN_ON(!node_online(nid)); + VM_WARN_ON((gfp_mask & __GFP_THISNODE) && !node_online(nid)); return __alloc_pages(gfp_mask, order, nid); }