From patchwork Wed May 23 14:43:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10421663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CEDBE60327 for ; Wed, 23 May 2018 14:46:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE1012897A for ; Wed, 23 May 2018 14:46:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B29EA289B5; Wed, 23 May 2018 14:46:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56C2B2897A for ; Wed, 23 May 2018 14:46:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AE876B029D; Wed, 23 May 2018 10:45:47 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8E5496B029F; Wed, 23 May 2018 10:45:47 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AC086B02A0; Wed, 23 May 2018 10:45:47 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 2F3CD6B029D for ; Wed, 23 May 2018 10:45:47 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id 89-v6so14154256plb.18 for ; Wed, 23 May 2018 07:45:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=JW7ZWeh7Dx9ZhJ7wi1sm/SGCW78S6fO5bWHg9jx+qxo=; b=K/bVSLAbq0lu3pyI3J/OA7dsrwnMGWIvMO9nGKIPpUjOaz0EYAx7enjtErhpi5HYzf ZVf4RWUafqLjwLVUeQ9Xx/vBAXvA6TYuNgu0U0DtWIaWzD9+Mn7CUXEOJ/SNbw42uOFl Uhy+qBkhgHrcwj1qP6EAEgOMxcLwOnb6G2rXGhZTAgp+oCXKTFrvuMZ9FDwLhBlFK8oE 5R1XByI5sS1X6qHpJ5klQE0JhB6NP5s9Eg+JK9BQYqRf82WfY2p7QbkWR/hUgpiF3RQD /HHP7bfJyZSCxwNPoeaaK7Q56HeMkRf6+49ALvFlOgKnfFE/4PJjE2yXmluGcqPzbPDE KXZA== X-Gm-Message-State: ALKqPwfls8Fcdm1vZodXIaZLGmbE5iveT+tj5kyGPuhujkodmw15xOHA tLzbnReld47lCriUUJ9qHxIyK8GflJuqx6v/bim1G7rUcRub8rvGb8OR4Y/ohpDNMOUbJBzMoe0 GXeozuKMS9tK5IlYziY1s6yPP6byFUqujLoICfy+fZHrWpg9GwBw/xhJIqRXOTCU= X-Received: by 2002:a17:902:8f93:: with SMTP id z19-v6mr3222024plo.166.1527086746675; Wed, 23 May 2018 07:45:46 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo9clta3fUEvTNuAcYk+N+pxj4Nu1bFDE8/2VLADpF97kcJbcZHqzMOWCYliUtNTk3DGRyn X-Received: by 2002:a17:902:8f93:: with SMTP id z19-v6mr3221995plo.166.1527086746015; Wed, 23 May 2018 07:45:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527086745; cv=none; d=google.com; s=arc-20160816; b=t6TCQfhTvYtXahcAaY77g7O+sGVLVpVeaSEVnwffGhLWhd5hVAEEqUwkgbd7eofI5f 8UIPfiuKPz2PkONBhQg83GDU+R6cON2cQ0Y3/bEUCcryvJPlyZBfSD8nJUNZdDE9rfaw AJvRiR1BpY9P8e/867w6hlR0jiy6E77dXQC7u+6lgxYJJ2TGDPp+7mZYArc24QBjGa4p R6JYr9/gpMMboGJmd7J+xcvz4PBH/Xprqcv9UHjMD+wflTxxpKu5iBhJFmbssH1I6tdw 17d4a1x6tEXOWECBL4FMRNFm/E1zxjxc9P/R1DpsStFVYrab9iKvYyuIEcxPAJQywJjY mToQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=JW7ZWeh7Dx9ZhJ7wi1sm/SGCW78S6fO5bWHg9jx+qxo=; b=aGe3HpY8S5ofEMDWpx6tTYxfMIdtSFISrr9CKyOyvLuqOVu5TMG7eT3/V1XZX8sBSl y6VBFp2bKEdcVJO7WeqP8w9CY8Dxnp3opvMboBLQ5OdN3qoec9i4gLfXn/pJqJ6mA+9/ xIhKTI4/4+rmR2NhP/hYGJ2bfwh/SgWI2ftIP4V6L951xyfcKhJEFoUNJrBMuIE7f5lT 9pCiADgV0zBdl0icVWFp87ZNYgm3ayscNtFiiL8iqAbiqxHkf/5OgcT3/wucc5UYSMsy tPXonfevBSPFZK9hsU1Y9P8d6r3w4EQyAWBKyuUkQERDzlCZCIbV2LmUSAXypzdBbV6Z Q3sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=Ylj2t0dF; spf=pass (google.com: best guess record for domain of batv+df5a2477ff0fa86e9985+5386+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+df5a2477ff0fa86e9985+5386+infradead.org+hch@bombadil.srs.infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id h125-v6si13041658pgc.34.2018.05.23.07.45.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 May 2018 07:45:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of batv+df5a2477ff0fa86e9985+5386+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=Ylj2t0dF; spf=pass (google.com: best guess record for domain of batv+df5a2477ff0fa86e9985+5386+infradead.org+hch@bombadil.srs.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=BATV+df5a2477ff0fa86e9985+5386+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JW7ZWeh7Dx9ZhJ7wi1sm/SGCW78S6fO5bWHg9jx+qxo=; b=Ylj2t0dF6VJpDiSne4v+dngnn 3bS5Im3OdqBPCv0oxNGv8M589b/rpJuekkcOeKhYCXy9RNmKjxzZ+8JNl3DNpH5ZCdw89rhQT/MIu 2MMYMtG+ib0YzXxcUNIftrtFkWMhgP9lVd1lOJvsj0CUteYnUg/YS95TqOSvkqbuwxVNF2GNZEwxe KPfpbMRmgTvpzeLblXdqH9bIEdHMrPAbCoUL6dNJHK5OHxBgjymuVxvQXSAY+w+71PhR7QrQ4GhaZ TiHsxGu523ZnWtMjyODiP7knyFZG5k0qPQq+5QJwnS8q6mBcc+LWlIWsi6wB1RUm2Givir6BHa+rm n16Tosw0w==; Received: from 089144199016.atnat0008.highway.a1.net ([89.144.199.16] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fLV1M-0002Hi-1J; Wed, 23 May 2018 14:45:44 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 33/34] xfs: do not set the page uptodate in xfs_writepage_map Date: Wed, 23 May 2018 16:43:56 +0200 Message-Id: <20180523144357.18985-34-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180523144357.18985-1-hch@lst.de> References: <20180523144357.18985-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP We already track the page uptodate status based on the buffer uptodate status, which is updated whenever reading or zeroing blocks. This code has been there since commit a ptool commit in 2002, which claims to: "merge" the 2.4 fsx fix for block size < page size to 2.5. This needed major changes to actually fit. and isn't present in other writepage implementations. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index a4e53e0a57c2..492f4a4b1deb 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -796,7 +796,6 @@ xfs_writepage_map( ssize_t len = i_blocksize(inode); int error = 0; int count = 0; - bool uptodate = true; loff_t file_offset; /* file offset of page */ unsigned poffset; /* offset into page */ @@ -823,7 +822,6 @@ xfs_writepage_map( if (!buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); - uptodate = false; continue; } @@ -857,9 +855,6 @@ xfs_writepage_map( count++; } - if (uptodate && poffset == PAGE_SIZE) - SetPageUptodate(page); - ASSERT(wpc->ioend || list_empty(&submit_list)); out: