| Message ID | 20180601125321.30652-5-osalvador@techadventures.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 1, 2018 at 8:54 AM <osalvador@techadventures.net> wrote: > > From: Oscar Salvador <osalvador@suse.de> > > Callers of register_mem_sect_under_node() are always passing a valid > memory_block (not NULL), so we can safely drop the check for NULL. > > In the same way, register_mem_sect_under_node() is only called in case > the node is online, so we can safely remove that check as well. > > Signed-off-by: Oscar Salvador <osalvador@suse.de> Reviewed-by: Pavel Tatashin <pasha.tatashin@oracle.com> > --- > drivers/base/node.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 248c712e8de5..681be04351bc 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -415,12 +415,7 @@ int register_mem_sect_under_node(struct memory_block *mem_blk, int nid, > int ret; > unsigned long pfn, sect_start_pfn, sect_end_pfn; > > - if (!mem_blk) > - return -EFAULT; > - > mem_blk->nid = nid; > - if (!node_online(nid)) > - return 0; > > sect_start_pfn = section_nr_to_pfn(mem_blk->start_section_nr); > sect_end_pfn = section_nr_to_pfn(mem_blk->end_section_nr); > -- > 2.13.6 >
diff --git a/drivers/base/node.c b/drivers/base/node.c index 248c712e8de5..681be04351bc 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -415,12 +415,7 @@ int register_mem_sect_under_node(struct memory_block *mem_blk, int nid, int ret; unsigned long pfn, sect_start_pfn, sect_end_pfn; - if (!mem_blk) - return -EFAULT; - mem_blk->nid = nid; - if (!node_online(nid)) - return 0; sect_start_pfn = section_nr_to_pfn(mem_blk->start_section_nr); sect_end_pfn = section_nr_to_pfn(mem_blk->end_section_nr);