From patchwork Mon Jun 25 17:15:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Thelen X-Patchwork-Id: 10487015 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E5ED46023A for ; Mon, 25 Jun 2018 17:15:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D25562858F for ; Mon, 25 Jun 2018 17:15:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C54DD28592; Mon, 25 Jun 2018 17:15:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 659AD2858F for ; Mon, 25 Jun 2018 17:15:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72F436B026F; Mon, 25 Jun 2018 13:15:31 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6B7BE6B0270; Mon, 25 Jun 2018 13:15:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 580E86B0271; Mon, 25 Jun 2018 13:15:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ua0-f197.google.com (mail-ua0-f197.google.com [209.85.217.197]) by kanga.kvack.org (Postfix) with ESMTP id 2645B6B026F for ; Mon, 25 Jun 2018 13:15:31 -0400 (EDT) Received: by mail-ua0-f197.google.com with SMTP id e17-v6so4282302uam.21 for ; Mon, 25 Jun 2018 10:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:date:message-id :subject:from:to:cc; bh=Zub7ViUOsmj+AevHRwGRuUDiiz0//f8K6SFVme4s8Ac=; b=UBJQR8lsRrm25fki6LiI8E+pkFt76POk1ED0UnBJKWwtIa2gxGrmlvMOXVooyCCG5t 1xrCUr0M4Qj6ooYZ+AdyfFixdbvjTjdAQn5Me/NMeTB4IftbinQtYulhkDZWZ2qIQteU iAEl3oItbQJwU0QQ5AOVbRN1kuC+9RWhGt3xcALM9VNut+jsTodgKRqQHsiY/ctiuL6K WRb6ezoeWKMo7LWYU8VKLLlfElojjdnQvl9aQSXGCZGRtaaQf3rl+CWfnUlQcK9uN0zi m/+3p6zOVKhFX7dclkhT8pXB66CGKiPZ58S6GqPKqC39o7OTOpQPp5Dj4ne3S/x6TCiC fOaQ== X-Gm-Message-State: APt69E0Ei+4hcoy/UwBNVmGnP8y/YqG4YSQeqoXh1ws08cey72+Hp+77 9iUZ7OV3wt6baKviZLL6nTelI6/HhvVMZAPv65aAv7xuQzkNQx9mSMFZXkJJBVdGGEuGIKdPN9T uyP2T2BrnEEcl2LQHs77DPDeEqVW0xWKavmArR6lv/UQeV46h57yEEzncD0wAzpyqj7MGIH7Nqf sm3Ledf9R7zlE/JTsVosv3EpMpUQRAwhXblVtex47xN6KGwJ/FaJ69gNucZXxZRgki2KCskRhQn jbrUTMrKsYVhKhDJgr+4y8PTJTbtyqWoEm3/jqnXGHlKoS75qtN9Qi6Wj0rITUehw8Uo68ySkJH fsiGjldCG8UeG94Zm8TJ8kHpXPsvzxEdKooOY81MJNKLBX2Kb1yypCgRaVm5t2EUBxaohd6GrQS X X-Received: by 2002:ab0:42c4:: with SMTP id j62-v6mr8470326uaj.125.1529946930754; Mon, 25 Jun 2018 10:15:30 -0700 (PDT) X-Received: by 2002:ab0:42c4:: with SMTP id j62-v6mr8470300uaj.125.1529946930109; Mon, 25 Jun 2018 10:15:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529946930; cv=none; d=google.com; s=arc-20160816; b=LpqAklze1ogoma3L2MHftfUWW2vXMwlDw5eEBVX2G0N+wht23ZGfqpI0UheRlhVo1T QoV32U0dgE3Zc/71rtFuFR2h49YgZQiUH4HYwPqfY8cST2fPB7c2m6nVb5G/Ol1Mvo2g f0R2fO2Um0icf6vsZlZvLcgxtepn4UeL626VlCbZlN/kksWa3TBnFgYzXC5V7ouK2Zo8 3VuOgYlRa+5J8CV1z+2ZL5quxcmo9ZlpjQI7yccHIT6kQXS5RfGYePrYopypp/7NQofD /uISshFjFSbiLquDaJ5w4SNh1lkdfmLkY0dv7TjLcrG1gel84Whlc+gS69aflZ6UJyrJ R0mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:date:mime-version:dkim-signature :arc-authentication-results; bh=Zub7ViUOsmj+AevHRwGRuUDiiz0//f8K6SFVme4s8Ac=; b=dlhXoF5Xujak877RgLZtzhRaLyRchdiMcNgX9+mTDj3AN8uW32HxFBapwuRtBqLKt8 BthOsw5lEFjRy19gaRk9w1227TrePljBWEQBmPapKYYOMHwslheAiIZYNifKTNxUR/5T zNLTzxVad6ZFMfFUI0ZdR6udyF4nSBpMqgp2UzWdBPNNKJlD9DH/HkFq087KNevMQ9lx UVhlbx6jiT3s+JWv3GQ6tuO5dd/3hfXf5MJ19Nl3u7U0NpTyKIOtX/rSm76yfsMRZZ8G p8C+dnflHFB1Kp0isVMeAaWXP4o/K/4bYSo2CY1ajM9Ns+NrN4vCMgGQ5uYmgai9qfQw Xung== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="uELxE8/+"; spf=pass (google.com: domain of 3msmxwwckcbw8l96d6f8gg8d6.4gedafmp-eecn24c.gj8@flex--gthelen.bounces.google.com designates 209.85.220.73 as permitted sender) smtp.mailfrom=3MSMxWwcKCBw8L96D6F8GG8D6.4GEDAFMP-EECN24C.GJ8@flex--gthelen.bounces.google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f73.google.com (mail-sor-f73.google.com. [209.85.220.73]) by mx.google.com with SMTPS id f4-v6sor1961858vkb.171.2018.06.25.10.15.30 for (Google Transport Security); Mon, 25 Jun 2018 10:15:30 -0700 (PDT) Received-SPF: pass (google.com: domain of 3msmxwwckcbw8l96d6f8gg8d6.4gedafmp-eecn24c.gj8@flex--gthelen.bounces.google.com designates 209.85.220.73 as permitted sender) client-ip=209.85.220.73; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="uELxE8/+"; spf=pass (google.com: domain of 3msmxwwckcbw8l96d6f8gg8d6.4gedafmp-eecn24c.gj8@flex--gthelen.bounces.google.com designates 209.85.220.73 as permitted sender) smtp.mailfrom=3MSMxWwcKCBw8L96D6F8GG8D6.4GEDAFMP-EECN24C.GJ8@flex--gthelen.bounces.google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:date:message-id:subject:from:to:cc; bh=Zub7ViUOsmj+AevHRwGRuUDiiz0//f8K6SFVme4s8Ac=; b=uELxE8/+eiO59MrqSGG3f2xcB/sF/McDy2qHhkAdEmwm/Sh6L7UG/SeZMDKKSmuiI8 0R+Rjt1qWixlR+ZwTBRT44zFmEKIUFHhTq3X5wmyNvtSXnmPv8lD9UT0+WEBVGSeT9co 8GT1Sr4HMlkRrrjcQhnah9HDex1KKjk9KN5Kc8dudtjmSYEM32kpxurhtnHaG9/fDnm2 uVuA0p+Yd9KMUDKoP047UnAAecSH7hWlSHtgVQXEBJQ8xmu0+GdbWOGY+XfA8z3zUuTz svezsKoAOOc6h0HrYo8CfjyyloyxAT1Ut9XMzxLvCU9E0OhIJRrnwRaDm7KHS+sO/E/B rOLg== X-Google-Smtp-Source: AAOMgpddcJUDT7m68L3mWfdUH2o+b3Df1o9M7c7Ffvx/K3Rg7FyP+iwAwAwa5Qy4M9NQPJeMxwH39NG3AUEu MIME-Version: 1.0 X-Received: by 2002:a1f:1b04:: with SMTP id b4-v6mr1164610vkb.19.1529946929661; Mon, 25 Jun 2018 10:15:29 -0700 (PDT) Date: Mon, 25 Jun 2018 10:15:26 -0700 Message-Id: <20180625171526.173483-1-gthelen@google.com> X-Mailer: git-send-email 2.18.0.rc2.346.g013aa6912e-goog Subject: [PATCH] writeback: update stale account_page_redirty() comment From: Greg Thelen To: Tejun Heo , Andrew Morton Cc: Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Greg Thelen X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in account_page_redirty(). Update comment to track that change. BDI_DIRTIED => WB_DIRTIED BDI_WRITTEN => WB_WRITTEN Signed-off-by: Greg Thelen Reviewed-by: Jan Kara Acked-by: Tejun Heo --- mm/page-writeback.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 337c6afb3345..6551d3b0dc30 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2490,8 +2490,8 @@ EXPORT_SYMBOL(__set_page_dirty_nobuffers); /* * Call this whenever redirtying a page, to de-account the dirty counters - * (NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied), so that they match the written - * counters (NR_WRITTEN, BDI_WRITTEN) in long term. The mismatches will lead to + * (NR_DIRTIED, WB_DIRTIED, tsk->nr_dirtied), so that they match the written + * counters (NR_WRITTEN, WB_WRITTEN) in long term. The mismatches will lead to * systematic errors in balanced_dirty_ratelimit and the dirty pages position * control. */