diff mbox

/tmp/cctnQ1CM.s:35: Error: .err encountered

Message ID 20180630111210.ec9de2c2923a0c58b1357965@linux-foundation.org
State New, archived
Headers show

Commit Message

Andrew Morton June 30, 2018, 6:12 p.m. UTC
On Sat, 30 Jun 2018 11:07:20 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 30 Jun 2018 12:27:09 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
> 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   1904148a361a07fb2d7cba1261d1d2c2f33c8d2e
> > > commit: 758517202bd2e427664857c9f2aa59da36848aca arm: port KCOV to arm
> > > date:   2 weeks ago
> > > config: arm-allmodconfig (attached as .config)
> > > compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> > > reproduce:
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         git checkout 758517202bd2e427664857c9f2aa59da36848aca
> > >         # save the attached .config to linux build tree
> > >         GCC_VERSION=7.2.0 make.cross ARCH=arm
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    /tmp/cctnQ1CM.s: Assembler messages:
> > >>> /tmp/cctnQ1CM.s:35: Error: .err encountered
> > >    /tmp/cctnQ1CM.s:36: Error: .err encountered
> > >    /tmp/cctnQ1CM.s:37: Error: .err encountered
> > 
> > Hi kbuild test robot,
> > 
> > The fix was mailed more than a month ago, but still not merged into
> > the tree. That's linux...
> 
> That was a rather unhelpful email.
> 
> I've just scanned all your lkml emails since the start of May and
> cannot find anything which looks like a fix for this issue.
> 
> Please resend.   About three weks ago :(

OK, with a bi of amazing sleuthing I found this from Arnd, which is what
I presume you're referring to?



From: Arnd Bergmann <arnd@arndb.de>
Subject: ARM: disable KCOV for trusted foundations code

The ARM trusted foundations code is currently broken in linux-next when
CONFIG_KCOV_INSTRUMENT_ALL is set:

/tmp/ccHdQsCI.s: Assembler messages:
/tmp/ccHdQsCI.s:37: Error: .err encountered
/tmp/ccHdQsCI.s:38: Error: .err encountered
/tmp/ccHdQsCI.s:39: Error: .err encountered
scripts/Makefile.build:311: recipe for target 'arch/arm/firmware/trusted_foundations.o' failed

I could not find a function attribute that lets me disable
-fsanitize-coverage=trace-pc for just one function, so this turns it off
for the entire file instead.

Link: http://lkml.kernel.org/r/20180529103636.1535457-1-arnd@arndb.de
Fixes: 758517202bd2e4 ("arm: port KCOV to arm")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

Comments

Olof Johansson June 30, 2018, 8:30 p.m. UTC | #1
On Sat, Jun 30, 2018 at 11:12 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sat, 30 Jun 2018 11:07:20 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> On Sat, 30 Jun 2018 12:27:09 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
>>
>> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> > > head:   1904148a361a07fb2d7cba1261d1d2c2f33c8d2e
>> > > commit: 758517202bd2e427664857c9f2aa59da36848aca arm: port KCOV to arm
>> > > date:   2 weeks ago
>> > > config: arm-allmodconfig (attached as .config)
>> > > compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>> > > reproduce:
>> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> > >         chmod +x ~/bin/make.cross
>> > >         git checkout 758517202bd2e427664857c9f2aa59da36848aca
>> > >         # save the attached .config to linux build tree
>> > >         GCC_VERSION=7.2.0 make.cross ARCH=arm
>> > >
>> > > All errors (new ones prefixed by >>):
>> > >
>> > >    /tmp/cctnQ1CM.s: Assembler messages:
>> > >>> /tmp/cctnQ1CM.s:35: Error: .err encountered
>> > >    /tmp/cctnQ1CM.s:36: Error: .err encountered
>> > >    /tmp/cctnQ1CM.s:37: Error: .err encountered
>> >
>> > Hi kbuild test robot,
>> >
>> > The fix was mailed more than a month ago, but still not merged into
>> > the tree. That's linux...
>>
>> That was a rather unhelpful email.
>>
>> I've just scanned all your lkml emails since the start of May and
>> cannot find anything which looks like a fix for this issue.
>>
>> Please resend.   About three weks ago :(
>
> OK, with a bi of amazing sleuthing I found this from Arnd, which is what
> I presume you're referring to?
>
>
>
> From: Arnd Bergmann <arnd@arndb.de>
> Subject: ARM: disable KCOV for trusted foundations code
>
> The ARM trusted foundations code is currently broken in linux-next when
> CONFIG_KCOV_INSTRUMENT_ALL is set:
>
> /tmp/ccHdQsCI.s: Assembler messages:
> /tmp/ccHdQsCI.s:37: Error: .err encountered
> /tmp/ccHdQsCI.s:38: Error: .err encountered
> /tmp/ccHdQsCI.s:39: Error: .err encountered
> scripts/Makefile.build:311: recipe for target 'arch/arm/firmware/trusted_foundations.o' failed
>
> I could not find a function attribute that lets me disable
> -fsanitize-coverage=trace-pc for just one function, so this turns it off
> for the entire file instead.
>
> Link: http://lkml.kernel.org/r/20180529103636.1535457-1-arnd@arndb.de
> Fixes: 758517202bd2e4 ("arm: port KCOV to arm")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Solves it on my builder at least. Would be good to get this in.

Acked-by: Olof Johansson <olof@lixom.net>


-Olof
Olof Johansson July 3, 2018, 5:50 p.m. UTC | #2
Hi Andrew,

On Sat, Jun 30, 2018 at 1:30 PM, Olof Johansson <olof@lixom.net> wrote:
> On Sat, Jun 30, 2018 at 11:12 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Sat, 30 Jun 2018 11:07:20 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>>> On Sat, 30 Jun 2018 12:27:09 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
>>>
>>> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> > > head:   1904148a361a07fb2d7cba1261d1d2c2f33c8d2e
>>> > > commit: 758517202bd2e427664857c9f2aa59da36848aca arm: port KCOV to arm
>>> > > date:   2 weeks ago
>>> > > config: arm-allmodconfig (attached as .config)
>>> > > compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>>> > > reproduce:
>>> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> > >         chmod +x ~/bin/make.cross
>>> > >         git checkout 758517202bd2e427664857c9f2aa59da36848aca
>>> > >         # save the attached .config to linux build tree
>>> > >         GCC_VERSION=7.2.0 make.cross ARCH=arm
>>> > >
>>> > > All errors (new ones prefixed by >>):
>>> > >
>>> > >    /tmp/cctnQ1CM.s: Assembler messages:
>>> > >>> /tmp/cctnQ1CM.s:35: Error: .err encountered
>>> > >    /tmp/cctnQ1CM.s:36: Error: .err encountered
>>> > >    /tmp/cctnQ1CM.s:37: Error: .err encountered
>>> >
>>> > Hi kbuild test robot,
>>> >
>>> > The fix was mailed more than a month ago, but still not merged into
>>> > the tree. That's linux...
>>>
>>> That was a rather unhelpful email.
>>>
>>> I've just scanned all your lkml emails since the start of May and
>>> cannot find anything which looks like a fix for this issue.
>>>
>>> Please resend.   About three weks ago :(
>>
>> OK, with a bi of amazing sleuthing I found this from Arnd, which is what
>> I presume you're referring to?
>>
>>
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>> Subject: ARM: disable KCOV for trusted foundations code
>>
>> The ARM trusted foundations code is currently broken in linux-next when
>> CONFIG_KCOV_INSTRUMENT_ALL is set:
>>
>> /tmp/ccHdQsCI.s: Assembler messages:
>> /tmp/ccHdQsCI.s:37: Error: .err encountered
>> /tmp/ccHdQsCI.s:38: Error: .err encountered
>> /tmp/ccHdQsCI.s:39: Error: .err encountered
>> scripts/Makefile.build:311: recipe for target 'arch/arm/firmware/trusted_foundations.o' failed
>>
>> I could not find a function attribute that lets me disable
>> -fsanitize-coverage=trace-pc for just one function, so this turns it off
>> for the entire file instead.
>>
>> Link: http://lkml.kernel.org/r/20180529103636.1535457-1-arnd@arndb.de
>> Fixes: 758517202bd2e4 ("arm: port KCOV to arm")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Dmitry Vyukov <dvyukov@google.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> Solves it on my builder at least. Would be good to get this in.
>
> Acked-by: Olof Johansson <olof@lixom.net>

Since this doesn't seem to be in your queue at the moment, I've
applied it to our set of fixes for 4.18 in arm-soc, I'll send to Linus
at end of week and it'll be in -next as of now through there.


Thanks,

-Olof
Andrew Morton July 3, 2018, 6:30 p.m. UTC | #3
On Tue, 3 Jul 2018 10:50:46 -0700 Olof Johansson <olof@lixom.net> wrote:

> > Solves it on my builder at least. Would be good to get this in.
> >
> > Acked-by: Olof Johansson <olof@lixom.net>
> 
> Since this doesn't seem to be in your queue at the moment, I've
> applied it to our set of fixes for 4.18 in arm-soc, I'll send to Linus
> at end of week and it'll be in -next as of now through there.

I queued it on June 30:

http://ozlabs.org/~akpm/mmots/broken-out/arm-disable-kcov-for-trusted-foundations-code.patch

but whatever.  If it turns up in -next I drop my copy.
diff mbox

Patch

diff -puN arch/arm/firmware/Makefile~arm-disable-kcov-for-trusted-foundations-code arch/arm/firmware/Makefile
--- a/arch/arm/firmware/Makefile~arm-disable-kcov-for-trusted-foundations-code
+++ a/arch/arm/firmware/Makefile
@@ -1 +1,4 @@ 
 obj-$(CONFIG_TRUSTED_FOUNDATIONS)	+= trusted_foundations.o
+
+# tf_generic_smc() fails to build with -fsanitize-coverage=trace-pc
+KCOV_INSTRUMENT                := n