From patchwork Tue Jul 3 14:52:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 10504231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 279706035E for ; Tue, 3 Jul 2018 14:52:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 163CA28C5D for ; Tue, 3 Jul 2018 14:52:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A85A28C69; Tue, 3 Jul 2018 14:52:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D396428C5D for ; Tue, 3 Jul 2018 14:52:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B882B6B0006; Tue, 3 Jul 2018 10:52:51 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B379B6B0008; Tue, 3 Jul 2018 10:52:51 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A27416B000A; Tue, 3 Jul 2018 10:52:51 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 4AB5A6B0006 for ; Tue, 3 Jul 2018 10:52:51 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id i193-v6so871363wmf.6 for ; Tue, 03 Jul 2018 07:52:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=MeEY8/clSRDMyBVj1mTSsDjAH7nA2jZGPuLujr7vmp4=; b=rS9sEElIM4C6wdPLg0r/qugkH030NWpRMsGB8P7YrL/UD0icTAemb9hCTYB6OkZhGY IpFbuFQQrtGJ/xzOmgC+OWw1vfGY0+FxJP7DrwFLvnbOfopuQvSmYxLg9ocsBN1lTVnX bXhuWsoQbKvlkhfqvie8w1Fy+uBpQ4JoX8r/s9WmnQ61fllnZwDE8kHtRIbV1BTpjLFJ mIkDSKgv+o7QCHeiDGjFZUH27FfCgi+hhC0xkuloC001nVIPuJedXpoXEwrfR4eOG2+y uagc6n1m5svFSKqKLXW1o7ZCI2obcV9TZisVjRYjkrB3zFgw25DvpxAphF8igTSDHglJ qfig== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de X-Gm-Message-State: APt69E1EbHOSj9yJxOiBWw989QR+NyuTFaOR+o3HF7bUzLSIxE6ZVrI8 mY2FwLtQf9k/0WqVcdy4p42m0Gyvf4JKMqsA+ctB05ubKD1ixlHb1jzG9CQCywzhESTrAm818UN wSS83IIdbkVlpjVdKgmyKDwuMCB5z5GdxTaW4i1edcdme9qCFCPyV9MtTdx2Bm+nmXA== X-Received: by 2002:a1c:4405:: with SMTP id r5-v6mr6564590wma.4.1530629570808; Tue, 03 Jul 2018 07:52:50 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeLXCVGy84lUrRCOFN4qczw5kk5ni3SaeCplHLQ/HB1Uz9rd+lHztExGv+XVB/QY21X5Owi X-Received: by 2002:a1c:4405:: with SMTP id r5-v6mr6564554wma.4.1530629569821; Tue, 03 Jul 2018 07:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530629569; cv=none; d=google.com; s=arc-20160816; b=OgPRUrFkIXL2l2t/7MuPAa0vn0ZnxTGG0xxKeoFnLuKhz/BdTN4omFejI2qc9H3Mst fTEcSn57HFTMl7ZkAG0j4nwWc7lhPw/bnUtXxGBuUNndRmDI22mxDqj1nk79HE9MUQcC nQFiZXLOLDpm37vfSIJmjna8Or8MshClWeHCjspnqF2vQjebV/FcoL36ndVhl2EwRKPr MFuI+PBVog/EbtyTHVxwHq7U0W8NdZmkBjjcuBo5D0z70Lm0Hh0qbpHRCGGDgBOxIGO4 0JPBnfpiy5K8+imMzVjVuREcTQEhKfrmXRqw9wZv+wzFnVaF6wOw/QpvRZJ3Zh0EfFZi pDyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=MeEY8/clSRDMyBVj1mTSsDjAH7nA2jZGPuLujr7vmp4=; b=yyP08NYzPcVZMRkMWZkL3m2SYdPgGvGn5oOPsvJ/LU95u13n34zv7uEhhXZKtm4t3q hH01Fu5anUSEy8icso2sR54YTroHtI0fyBCI73afucQe8wbkeSRnqu2IWUvF0X4U+qn6 WF9XwKL9toN6HgMjx77zfYke9k2kF2QtF41TaUNE7NJZ3f+qP33bac2DFk4/G+qwcf+t pkyxsQ7/TCa9RgZzKoZ/b3jANuskrYvkW3WXelnJnbKg+2W6D3JI9Wry0nzTpJeM07+H pdHqv+whWFxaUnim4ShIG60XhP/WmIYYVFbd0ykIlLgVpc0cLl/r+XZPGcFO9eech1WQ PVfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id g8-v6si1276561wrw.125.2018.07.03.07.52.49 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 03 Jul 2018 07:52:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1faMfg-000384-JB; Tue, 03 Jul 2018 16:52:48 +0200 From: Sebastian Andrzej Siewior To: Vladimir Davydov Cc: linux-mm@kvack.org, tglx@linutronix.de, Andrew Morton , Sebastian Andrzej Siewior Subject: [PATCH 1/4] mm/list_lru: use list_lru_walk_one() in list_lru_walk_node() Date: Tue, 3 Jul 2018 16:52:32 +0200 Message-Id: <20180703145235.28050-2-bigeasy@linutronix.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180703145235.28050-1-bigeasy@linutronix.de> References: <20180624200907.ufjxk6l2biz6xcm2@esperanza> <20180703145235.28050-1-bigeasy@linutronix.de> Reply-To: "[PATCH 0/4]"@kvack.org, "mm/list_lru:add"@kvack.org, list_lru_shrink_walk_irq@kvack.org, and@kvack.org (), use@kvack.org, it@kvack.org MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP list_lru_walk_node() invokes __list_lru_walk_one() with -1 as the memcg_idx parameter. The same can be achieved by list_lru_walk_one() and passing NULL as memcg argument which then gets converted into -1. This is a preparation step when the spin_lock() function is lifted to the caller of __list_lru_walk_one(). Invoke list_lru_walk_one() instead __list_lru_walk_one() when possible. Signed-off-by: Sebastian Andrzej Siewior --- mm/list_lru.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index fcfb6c89ed47..ddbffbdd3d72 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -272,8 +272,8 @@ unsigned long list_lru_walk_node(struct list_lru *lru, int nid, long isolated = 0; int memcg_idx; - isolated += __list_lru_walk_one(lru, nid, -1, isolate, cb_arg, - nr_to_walk); + isolated += list_lru_walk_one(lru, nid, NULL, isolate, cb_arg, + nr_to_walk); if (*nr_to_walk > 0 && list_lru_memcg_aware(lru)) { for_each_memcg_cache_index(memcg_idx) { isolated += __list_lru_walk_one(lru, nid, memcg_idx,