From patchwork Wed Jul 11 20:57:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Davidlohr Bueso X-Patchwork-Id: 10520535 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0F42E6028E for ; Wed, 11 Jul 2018 20:57:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC65D298B6 for ; Wed, 11 Jul 2018 20:57:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E0277298BD; Wed, 11 Jul 2018 20:57:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D602298B6 for ; Wed, 11 Jul 2018 20:57:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F6AC6B0003; Wed, 11 Jul 2018 16:57:11 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2CD9B6B0006; Wed, 11 Jul 2018 16:57:11 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E4876B0007; Wed, 11 Jul 2018 16:57:11 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id D3EC26B0003 for ; Wed, 11 Jul 2018 16:57:10 -0400 (EDT) Received: by mail-pf0-f199.google.com with SMTP id h14-v6so17029226pfi.19 for ; Wed, 11 Jul 2018 13:57:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:mail-followup-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=44VttybpH1tdI3UXpxG7O79bh4EQPM82YvRVUupxutI=; b=i/e2/1FB21awYwrMv2tcWD7/OBvMpaGz9xp+UbD539teIJQ6IHVbapsroV9rTuW6RF JLXwl6e8SwO4i08owOCWFPp4U5GDFezg6DsYNj8yblOc959ZjyOKA4zh9X4fzNski6e0 tfta292acdYZnixYyVYAXUXlvUQzj8qjXUSULPVDjXDk0QuNTq1mnn3hKzj6OE77p8ms qI9KUox3G490SyvtRDs8MonjCWwrik7tr04Vw/q208zvFEhnIos3X2BMrxUDW9aOkq2Z 5gH1cYyQZ087GEVin7NKNO97hSFORDu+/Y4pNY8x4pdVtooNwMMKP4oCL3ZFkUYUef53 tMhQ== X-Original-Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning dave@stgolabs.net does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=dave@stgolabs.net X-Gm-Message-State: AOUpUlHv293djAaBuLHF54XUDCD5N07TOhGRrPgJFuCFJqnVAbnMqi0P d+HAUo6ZVQK0M8amXb7ysIZDUFvtukf3fSnox2bbFlrGE44q0xA7KpOcoEvQ0kxCQC7olxEj470 Y3GzzFBeTRvVXit/UBcV29zQCE1YrGAG9FPJA5ASiSYAu14SZOaRBdlKyOfWyfg8= X-Received: by 2002:a63:e0b:: with SMTP id d11-v6mr197838pgl.134.1531342630501; Wed, 11 Jul 2018 13:57:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpepA5Ve72LsIY+tM4DV1WWIqecVX3wZexJxflhV9z2h7/BP+9X0a5RR8LIZk5O1Q8C66smC X-Received: by 2002:a63:e0b:: with SMTP id d11-v6mr197798pgl.134.1531342629364; Wed, 11 Jul 2018 13:57:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531342629; cv=none; d=google.com; s=arc-20160816; b=A7MjVOK1Q0UG2fH/Qmha3rvoxD6z4W4UlEjZX1ZNigEEfRIvA9El3K8gWNC+KzN1mB v7Q/jvPaRnJXV11Bzx/J2YCoss3CzjViNs3BlwanXO8KjXt+wscA0AckjxpHWvM+7V4S Lci/Ptv6RTDviRx8f5gZBCnfOb+sRF9zITIvm3zVVi7u6juU/mP3jlddseSXiapoM7ul Eq2gZHyBFKfw19CLFoEme/hi945M7JJqc+3b/T87MYZsM6bX8mTISWAKZegK1MEkXJX5 jb491UT6D9BGQ+vY+Jk18aOVHhFCWfK3ECcXd0ulaGWSuNZbPkdF0LMLBRT+T2Oz3TwG 83Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=44VttybpH1tdI3UXpxG7O79bh4EQPM82YvRVUupxutI=; b=KQgaAYH0R7pszOAYKm0afMKVG3DkYTLdztsa1Ix5Jmruur03r52rZNmGt9Z6WTnC/x nowtqlXDG0GFNdjD+f3MN+QA/94iPjCdg82xuRnk1AuMw1+iDFk0R3A0MBVet1F/OH5g ygggQNo4KDR+QTW3A15N5/8eWp54lLj+QIPCHxsvwqmGYcobCzxpS2e6/iqU49IbgZIY nETlPkPEBLFHgiZZ/kU8b9tWPsBruUGvSbqH7Io9xCxk/zq0BgEmn1JaTQCjkwLfx7ns YcQCoHvJ0b5aXap/HKtfuZ87i33XxDcCUa8JymNb2pQawP8jvwBHizBZtvtJwBPvDX89 /IMg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning dave@stgolabs.net does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=dave@stgolabs.net Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id e67-v6si20101866plb.272.2018.07.11.13.57.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jul 2018 13:57:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning dave@stgolabs.net does not designate 195.135.220.15 as permitted sender) client-ip=195.135.220.15; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning dave@stgolabs.net does not designate 195.135.220.15 as permitted sender) smtp.mailfrom=dave@stgolabs.net X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 41CA4ADA0; Wed, 11 Jul 2018 20:57:07 +0000 (UTC) Date: Wed, 11 Jul 2018 13:57:02 -0700 From: Davidlohr Bueso To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Aneesh Kumar K . V" , Michael Ellerman , Benjamin Herrenschmidt , Michal Hocko , Cannon Matthews , Andrew Morton Subject: Re: [PATCH] mm/hugetlb: remove gigantic page support for HIGHMEM Message-ID: <20180711205702.d4xeu552xgxjbse3@linux-r8p5> Mail-Followup-To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Aneesh Kumar K . V" , Michael Ellerman , Benjamin Herrenschmidt , Michal Hocko , Cannon Matthews , Andrew Morton References: <20180711195913.1294-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180711195913.1294-1-mike.kravetz@oracle.com> User-Agent: NeoMutt/20170912 (1.9.0) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 11 Jul 2018, Mike Kravetz wrote: >This reverts commit ee8f248d266e ("hugetlb: add phys addr to struct >huge_bootmem_page") > >At one time powerpc used this field and supporting code. However that >was removed with commit 79cc38ded1e1 ("powerpc/mm/hugetlb: Add support >for reserving gigantic huge pages via kernel command line"). > >There are no users of this field and supporting code, so remove it. Considering the title, don't you wanna also get rid of try_to_free_low() and something like the following, which I'm sure can be done fancier, and perhaps also thp? Thanks, Davidlohr diff --git a/fs/Kconfig b/fs/Kconfig index ac474a61be37..849da70e35d6 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -192,8 +192,8 @@ config TMPFS_XATTR config HUGETLBFS bool "HugeTLB file system support" - depends on X86 || IA64 || SPARC64 || (S390 && 64BIT) || \ - SYS_SUPPORTS_HUGETLBFS || BROKEN + depends on !HIGHMEM && (X86 || IA64 || SPARC64 || (S390 && 64BIT) || \ + SYS_SUPPORTS_HUGETLBFS || BROKEN) help hugetlbfs is a filesystem backing for HugeTLB pages, based on ramfs. For architectures that support it, say Y here and read