From patchwork Mon Jul 16 11:19:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 10526485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 45B73601D2 for ; Mon, 16 Jul 2018 11:19:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35B8928A52 for ; Mon, 16 Jul 2018 11:19:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29B0728A56; Mon, 16 Jul 2018 11:19:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A50F728A52 for ; Mon, 16 Jul 2018 11:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71B576B0008; Mon, 16 Jul 2018 07:19:34 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6814F6B0269; Mon, 16 Jul 2018 07:19:34 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 403D56B026A; Mon, 16 Jul 2018 07:19:34 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by kanga.kvack.org (Postfix) with ESMTP id 07F186B0008 for ; Mon, 16 Jul 2018 07:19:34 -0400 (EDT) Received: by mail-wr1-f70.google.com with SMTP id z16-v6so8279356wrs.22 for ; Mon, 16 Jul 2018 04:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=r5ZD2hNJ+CyWEgwFXQPqVV6dWBAXkmTBe23tA7xPBd8=; b=mkYA3X5KmeSPHq/Im4ojQd7XZNCOcS2ByE5rkuWQVA+PvelbR6IVtha2jtZR7cAVIG vJ76f6+Js7MirbVDxVXxAbvIDUQrGRlMxwY1sG1gEAtpcwhFg+SgMF8VQQJ36/y55B3z mKAhJMhQUbylYJyEPg7EMxeffEX634yeElCOwzjECVrDRPdNH4W0sd/h6MvN1Ye46VAz SHj7rj0ekmRzPZ13cYD39GyTTmz1ppzLZsxthfrAyfOioUJkr1egDoYh/2MLq0QDkCmR 0JEFNt4GfKDLCoD5UIS66alJHLitD39oOLvKTeaIPYWMDWmVV9B+hA0QpmZBrgxhpbT1 dqAA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de X-Gm-Message-State: AOUpUlFz+WD9+EwhMCEo/45rbRgr8Tk4CkcSFfYhYTbcxDD5hZtg5zi3 L6bzi+7aYw7OeLlXS+cuWBLLSKWdaLR4D07kWpEpbw1PoIcnhIPo7Nho4vXh7ViSK+MmG2LxnMF K8v9iK+D4X+kgoH/JPcxpUI3DhlPbwmGMoIvU9u0iUg8jacCyfpsOkvn/9j94HKQ8tg== X-Received: by 2002:adf:f148:: with SMTP id y8-v6mr11301829wro.134.1531739973610; Mon, 16 Jul 2018 04:19:33 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeIeeGpxTnm1t55XuOS0wVT5Ov8ngH1jn166/DO/ZlrGGKnvRdKKCqzYL8zWYbF5P+J8fpq X-Received: by 2002:adf:f148:: with SMTP id y8-v6mr11301799wro.134.1531739972979; Mon, 16 Jul 2018 04:19:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531739972; cv=none; d=google.com; s=arc-20160816; b=wppi2E6dzMnwKi7TtN8xlyXhZDOvrMDtVrMxLaaHhRXktzDzTd6GvBIQqiTf7X9bdj aCIeZs79RFvBgyyZdrpQFioMmp5Ct7k0IXxEs1xmz9HngP3IQKKZyVjAVTPcuQ3OuNns aYEAZunZqthy84Vh1aEfAyrVmC2FPEpWo7lO87EP4b76oDRfBocC3rItjeu/hD6XWpPF CokEdxUI2kvr2q09vMbSal1PfgOqe3tXK6SGaM3lqBms6otcXOuZ6+61KCUWqbSmSoXQ J00oyAWTakdswVXw+GQ9jTqdOsnrruTDd7WXoYIhbafmUe6/LhbbImzSnhsjELw/diJJ D1Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=r5ZD2hNJ+CyWEgwFXQPqVV6dWBAXkmTBe23tA7xPBd8=; b=pBPXVBFjS/qtWK5f8sHY65Syyeipv51GpMQkDnCB1ICxndWcuy0Sza0467g2cHuVfP rnn121JSAWgaa90j+dCqThT4kFpmrtmB4maiUYX25lqLMiPx9FCqsVHqBfG54ef8wSkR Qd5l0PfME3W7NnGIg/X869xD6hV1x4/oju3EbH9A9MRy0TxM2wAJ6ISTwJWfaJyLuI9+ 2Ri+JC1+fCC5gHMBXgzWmJLdGqCxGsuHcRIn1L4dIFfkDBIbvSKzeMo1OAHT9HE6Qq8o UNhnhDUoNlj0Q95I7kfaaR4YU6kxifPumzmvYALXCbpmOw5sQm/SLOkKYT7dF3/sGqk8 VexA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id q74-v6si2308368wmd.156.2018.07.16.04.19.32 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 16 Jul 2018 04:19:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of bigeasy@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1ff1XO-0003CQ-AF; Mon, 16 Jul 2018 13:19:30 +0200 From: Sebastian Andrzej Siewior To: linux-mm@kvack.org Cc: tglx@linutronix.de, Vladimir Davydov , Andrew Morton , Sebastian Andrzej Siewior Subject: [PATCH 1/4] mm/list_lru: use list_lru_walk_one() in list_lru_walk_node() Date: Mon, 16 Jul 2018 13:19:18 +0200 Message-Id: <20180716111921.5365-2-bigeasy@linutronix.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180716111921.5365-1-bigeasy@linutronix.de> References: <20180716111921.5365-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP list_lru_walk_node() invokes __list_lru_walk_one() with -1 as the memcg_idx parameter. The same can be achieved by list_lru_walk_one() and passing NULL as memcg argument which then gets converted into -1. This is a preparation step when the spin_lock() function is lifted to the caller of __list_lru_walk_one(). Invoke list_lru_walk_one() instead __list_lru_walk_one() when possible. Reviewed-by: Vladimir Davydov Signed-off-by: Sebastian Andrzej Siewior --- mm/list_lru.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index ca6dbcfe4256..344306714636 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -294,8 +294,8 @@ unsigned long list_lru_walk_node(struct list_lru *lru, int nid, long isolated = 0; int memcg_idx; - isolated += __list_lru_walk_one(lru, nid, -1, isolate, cb_arg, - nr_to_walk); + isolated += list_lru_walk_one(lru, nid, NULL, isolate, cb_arg, + nr_to_walk); if (*nr_to_walk > 0 && list_lru_memcg_aware(lru)) { for_each_memcg_cache_index(memcg_idx) { isolated += __list_lru_walk_one(lru, nid, memcg_idx,