From patchwork Fri Jul 27 14:03:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10547215 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 45E1C174A for ; Fri, 27 Jul 2018 14:03:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 343FC2BC39 for ; Fri, 27 Jul 2018 14:03:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 288322BC41; Fri, 27 Jul 2018 14:03:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B91F2BC39 for ; Fri, 27 Jul 2018 14:03:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 903DD6B0010; Fri, 27 Jul 2018 10:03:37 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8D8F06B026B; Fri, 27 Jul 2018 10:03:37 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B356B026C; Fri, 27 Jul 2018 10:03:37 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 12FF76B0010 for ; Fri, 27 Jul 2018 10:03:37 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id s25-v6so1278726wmh.1 for ; Fri, 27 Jul 2018 07:03:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=r3FUumIztPDwO6lIdEH4/NlXhd3R05jzu97rMbjyVnY=; b=JT7v5QF2oJe5x2yU1x5usaGWiTc/ZoSCQrZGaxi1qgxKA8QqPKVHr6f7a+ZfVi3QXt iPlv+tK3P9BaoIHDZYvgbvmIMhl5AKx1p8OwTFwl8zR87JjR/BgHWzD5T6PqiItyFYDp azWRIYJZ8uIaCmpZY9LZ2IKPwwfzag8s99NpHDpaLfmHADdtjQqK/K7TtcyYS9uXNw7K XXsdzJv2mRHtQSX3UpBe8eQ6lM8xi6PUInOSG1Lb3NF8Wr5mSc6gYWkheoZVqX8Tb+ET 6tkVSgqTc2J/cRL6WaIBtOH2THhYoYx6fqBBOBI6Zv9rg2VTOEHLPvm/dPiqPz4rriBm gprw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: AOUpUlHZtAIAV6e3UcvRt5hKxdNYzMVvwx78w+AzEIxkweSWTJy7jase JM4LJllxYxtxDZxF/bPr/l3SwExdytlnC8T3D20JjpbR10JIotqzIN8uZcfUT0FdY9gHb5ZpIV2 ERlW2e8asBAKpy7tHnRJ7OqYHkllr/uhY3wyRT19/37HeMy/8dUPej0vWaqrCTAUphu2f4+H1Jo uKDXeQAIxPCSPE7+RhRmkV25NALwvcrOMxrBWE8y8Yo7+LD2SbShl6VcHT/SZIeasdGKh9aOMst p4aDV8VPNj1i29bUwf95q+OotIUqXRBUv/Xy8zESQce5I7xOVl18B5OebIW4FG8cwKmi57NdIM/ JJADZsaFmtOaZh0krxV8TgkTRnergOsK5BuSVomsYTeDqoU2lFnBKPVi2krXBEBFUSlLPCEk8Q= = X-Received: by 2002:a1c:8e08:: with SMTP id q8-v6mr4711544wmd.137.1532700216615; Fri, 27 Jul 2018 07:03:36 -0700 (PDT) X-Received: by 2002:a1c:8e08:: with SMTP id q8-v6mr4711474wmd.137.1532700215318; Fri, 27 Jul 2018 07:03:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532700215; cv=none; d=google.com; s=arc-20160816; b=so4b+qT4So2P0W0W/0S8ZMJQayEol5/mYvbPMOIWw5Y69XhcFMms5xWXBfftWloNvD 5Kfv4qf6PZ5L7wbJNos/nclzwX0Mqt8Ra/xhTjkjAOX4zOu5S3de4WS3FVEB3c8SywrG RjliQ5rfXd64Do6w16/W8ifPvZcthmN0jurVg7lQr56fO6zSD3Ft2pOlhxWMk4xFZYDL nWY9aG90dZnF4a4gV7q8nYRRn3FqNhFAn3ShxuHW4NmSNL435U0v88d6U0Gq5lNG0n8U XXq0Sp/eVTabxoaMFr8kDs8PIuht53wNcLRF75ZN9Tcht34FOw0CgbxafBZi76nqD871 /JeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=r3FUumIztPDwO6lIdEH4/NlXhd3R05jzu97rMbjyVnY=; b=bn8mrZy1g4PUCG/kEMTD2S5ViXiP7J6ScAS1Qzkc3TERQk2K45PjVuas8/gDQsh0va VmZ6snh3tcXew6/oN3orJNdOp4GjWeVZKjzLtZbRJ84d2NUlG5fNazr7rDHz1iQ44XfW f5QLrMJslLFwiSAINkE3hTBfxofbwuETJ/LcHWdNJIooAu+TPlkKfHDZsJ0mau6hFv1q 9N2SQSVv7l5hdnVRk9kTwZ4AH8uCczOuyt1O0PzsUSMZbgUddmLTjeoXjkORDbIQ780w s/pYmO3TItV8/Ux0K2Jh6U2lKB180ICneUbGHQgowAbq5LMWkQnm65hoPQOJF7A94Cx4 4gJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b11-v6sor1728633wrw.35.2018.07.27.07.03.35 for (Google Transport Security); Fri, 27 Jul 2018 07:03:35 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: AAOMgpc2oRKahwTzpqyQdfrA/ycGXlMEtY+0/wUdqxVn6BihI6UQUSvu6a8TlVZXTeXog+sJy6YLZA== X-Received: by 2002:adf:a599:: with SMTP id g25-v6mr5109662wrc.88.1532700215035; Fri, 27 Jul 2018 07:03:35 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id d8-v6sm4077313wrv.68.2018.07.27.07.03.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jul 2018 07:03:33 -0700 (PDT) Received: from d104.suse.de (nat.nue.novell.com [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id ABEFF124406; Fri, 27 Jul 2018 16:03:31 +0200 (CEST) From: osalvador@techadventures.net To: akpm@linux-foundation.org Cc: mhocko@suse.com, vbabka@suse.cz, pasha.tatashin@oracle.com, mgorman@techsingularity.net, aaron.lu@intel.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dan.j.williams@intel.com, Oscar Salvador Subject: [PATCH v4 2/4] mm: access zone->node via zone_to_nid() and zone_set_nid() Date: Fri, 27 Jul 2018 16:03:23 +0200 Message-Id: <20180727140325.11881-3-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180727140325.11881-1-osalvador@techadventures.net> References: <20180727140325.11881-1-osalvador@techadventures.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Pavel Tatashin zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to have inline functions to access this field in order to avoid ifdef's in c files. Signed-off-by: Pavel Tatashin Signed-off-by: Oscar Salvador Reviewed-by: Oscar Salvador Acked-by: Michal Hocko --- include/linux/mm.h | 9 --------- include/linux/mmzone.h | 26 ++++++++++++++++++++------ mm/mempolicy.c | 4 ++-- mm/mm_init.c | 9 ++------- mm/page_alloc.c | 10 ++++------ 5 files changed, 28 insertions(+), 30 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 726e71475144..6954ad183159 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -940,15 +940,6 @@ static inline int page_zone_id(struct page *page) return (page->flags >> ZONEID_PGSHIFT) & ZONEID_MASK; } -static inline int zone_to_nid(struct zone *zone) -{ -#ifdef CONFIG_NUMA - return zone->node; -#else - return 0; -#endif -} - #ifdef NODE_NOT_IN_PAGE_FLAGS extern int page_to_nid(const struct page *page); #else diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index ae1a034c3e2c..17fdff3bfb41 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -842,6 +842,25 @@ static inline bool populated_zone(struct zone *zone) return zone->present_pages; } +#ifdef CONFIG_NUMA +static inline int zone_to_nid(struct zone *zone) +{ + return zone->node; +} + +static inline void zone_set_nid(struct zone *zone, int nid) +{ + zone->node = nid; +} +#else +static inline int zone_to_nid(struct zone *zone) +{ + return 0; +} + +static inline void zone_set_nid(struct zone *zone, int nid) {} +#endif + extern int movable_zone; #ifdef CONFIG_HIGHMEM @@ -957,12 +976,7 @@ static inline int zonelist_zone_idx(struct zoneref *zoneref) static inline int zonelist_node_idx(struct zoneref *zoneref) { -#ifdef CONFIG_NUMA - /* zone_to_nid not available in this context */ - return zoneref->zone->node; -#else - return 0; -#endif /* CONFIG_NUMA */ + return zone_to_nid(zoneref->zone); } struct zoneref *__next_zones_zonelist(struct zoneref *z, diff --git a/mm/mempolicy.c b/mm/mempolicy.c index f0fcf70bcec7..8c1c09b3852a 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1784,7 +1784,7 @@ unsigned int mempolicy_slab_node(void) zonelist = &NODE_DATA(node)->node_zonelists[ZONELIST_FALLBACK]; z = first_zones_zonelist(zonelist, highest_zoneidx, &policy->v.nodes); - return z->zone ? z->zone->node : node; + return z->zone ? zone_to_nid(z->zone) : node; } default: @@ -2326,7 +2326,7 @@ int mpol_misplaced(struct page *page, struct vm_area_struct *vma, unsigned long node_zonelist(numa_node_id(), GFP_HIGHUSER), gfp_zone(GFP_HIGHUSER), &pol->v.nodes); - polnid = z->zone->node; + polnid = zone_to_nid(z->zone); break; default: diff --git a/mm/mm_init.c b/mm/mm_init.c index 5b72266b4b03..6838a530789b 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -53,13 +53,8 @@ void __init mminit_verify_zonelist(void) zone->name); /* Iterate the zonelist */ - for_each_zone_zonelist(zone, z, zonelist, zoneid) { -#ifdef CONFIG_NUMA - pr_cont("%d:%s ", zone->node, zone->name); -#else - pr_cont("0:%s ", zone->name); -#endif /* CONFIG_NUMA */ - } + for_each_zone_zonelist(zone, z, zonelist, zoneid) + pr_cont("%d:%s ", zone_to_nid(zone), zone->name); pr_cont("\n"); } } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 8a73305f7c55..10b754fba5fa 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2909,10 +2909,10 @@ static inline void zone_statistics(struct zone *preferred_zone, struct zone *z) if (!static_branch_likely(&vm_numa_stat_key)) return; - if (z->node != numa_node_id()) + if (zone_to_nid(z) != numa_node_id()) local_stat = NUMA_OTHER; - if (z->node == preferred_zone->node) + if (zone_to_nid(z) == zone_to_nid(preferred_zone)) __inc_numa_state(z, NUMA_HIT); else { __inc_numa_state(z, NUMA_MISS); @@ -5287,7 +5287,7 @@ int local_memory_node(int node) z = first_zones_zonelist(node_zonelist(node, GFP_KERNEL), gfp_zone(GFP_KERNEL), NULL); - return z->zone->node; + return zone_to_nid(z->zone); } #endif @@ -6311,9 +6311,7 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat) * And all highmem pages will be managed by the buddy system. */ zone->managed_pages = freesize; -#ifdef CONFIG_NUMA - zone->node = nid; -#endif + zone_set_nid(zone, nid); zone->name = zone_names[j]; zone->zone_pgdat = pgdat; spin_lock_init(&zone->lock);