From patchwork Mon Aug 13 15:46:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10564465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 075AF13B4 for ; Mon, 13 Aug 2018 15:47:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAE5A29501 for ; Mon, 13 Aug 2018 15:47:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DEEFC29509; Mon, 13 Aug 2018 15:47:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BDAF29501 for ; Mon, 13 Aug 2018 15:46:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 002776B0007; Mon, 13 Aug 2018 11:46:53 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EA4A96B0008; Mon, 13 Aug 2018 11:46:52 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB92D6B000A; Mon, 13 Aug 2018 11:46:52 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by kanga.kvack.org (Postfix) with ESMTP id 801916B0008 for ; Mon, 13 Aug 2018 11:46:52 -0400 (EDT) Received: by mail-wr1-f70.google.com with SMTP id t10-v6so13051665wrs.17 for ; Mon, 13 Aug 2018 08:46:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=t8JI55qiiScE0tExHnbnQS/eE8NCPsrYaAtEdiJRMhc=; b=pz2SA+gjz34FpZMbxNrVHATiPdZY0GTw8YaDRb40FeCrD0GBt9RuC4Qi2zmij4CEoj iiJutWAKrSz4DvKRau3BOVBwJGscVeMJEmiOdfXY4WBU6KblU3p+Qln5hLW6xAW0zxPX qV3XtLcgzSuxotVfzdbVYA/PeCDtoBjTdlW6Fnu8Mw43LufzjhZF5rE6lg3Knn9qGICs 9nBAMHDaLenskpW/IBBfvp0BR2hStwoys4MVUMD0Zrx0YNCKIe/qbL5KhfJmRqnlablZ scUcpDLnaQhv5fL8O/2SGrC253DrU/QtrkbTkiZBfVuZ4h39bu23GJ/mdFj8jRAcw7+J 4YGQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: AOUpUlGnbvNsBvQm4OTQCg+JmITzoaxQ8noGXqKszRy94HOVzIv9t8nQ gYUrSWGYkP4iJyUiIOXU1uhbZRInkDBJGmwj3LhhSM/uPYXxqwtYHeP4yMfDg7eOvbSjbTGgzyt d8uUFy+wHf6fcSv123zxg4X40Z1fdiBZlielEv54m+KHkt7FplTm998UFW2GWDeYlpW/HfJmQvj HJW0myfJf2NEssUKFYHrOC/VgEqref21QgXRa7WcGowx+El1JrVPfnJAK3kkxuUUCdUlsI1dy7a br2HbpE0kBoSlBdJ5DEVk8zvHRL9bKta7/FE+KYZ9n50xP5n8cEFIIslVVMiVZ1ROq5bYTgYxiH TZIfXZNHSZZr8R00SsEzNQHAB9NoPmEw/Egs04vNxGQ4YHnRaMiSVAtaIQ9d1T0bGluNlve7Ew= = X-Received: by 2002:adf:9366:: with SMTP id 93-v6mr10552001wro.60.1534175212107; Mon, 13 Aug 2018 08:46:52 -0700 (PDT) X-Received: by 2002:adf:9366:: with SMTP id 93-v6mr10551986wro.60.1534175211444; Mon, 13 Aug 2018 08:46:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534175211; cv=none; d=google.com; s=arc-20160816; b=orjhD3J2fq7ugqg7fA/0OZOIVfeW+xkQcfjhz6yG7TPWHePYzP1Tlh0H1QktUWVth5 wlHiNrFZjDn7u0vj6yMCGe2nG9wN9XgX8SYCJ94tBZt20QgFLG0dNMGKfXad/SDYZ1Yd Lt7S29hFymrGvQagh8nWpqpVPISPapKaMLKYHvMMj5XYq0Fr2AspXqLFf0ZjRsvMUzU7 Igfz2baMusRedKsJGXHFaM0Fw4y2sBtNMWx33ixvLkHo+YCYcWc4PV21Gk+5xk3b8NnH ekpd7U13HWxe+QtG3eA3e2FobToRQmvHLVCMd2qAra4rO8b2/Zt2tf8plhq8lQhAwUZI oKfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=t8JI55qiiScE0tExHnbnQS/eE8NCPsrYaAtEdiJRMhc=; b=uow6AFKaogeJvB96BDPCg7zqzbgYrDCQNSZaVnBACRkdvyGedIYtKUxjlnQ9J90mgs fxpQU0EQKYDTW3cXHcJJ+VH/XYFvB37Gih15Kq6StgXlkF8uAevJT0ARFcc1vxl9SJCa uhWrt4XCr5FMRt/l9EaZGpmC8Xch/1VuqR8NYwQbGF77Sl4EA+Unqs8FjLspy4hySU+R nuI1PIPCWeDXdAIs3KEHF7S59LUeoq/EPHELBrF0HXLUdi7bThH1kTDP0lSbScOrPbe7 RZfSjNkWJ6tDNdN16uLplh7HvIMDgtosQ9EZatWfkYDhy/kOtQ2xaGUhCuReHTbusXyC JY8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id n24-v6sor1948935wmh.66.2018.08.13.08.46.51 for (Google Transport Security); Mon, 13 Aug 2018 08:46:51 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: AA+uWPwYVyNyN9KpmIV0w/2O1uBSTnfW8Aubyv0bOtU1GjAt4i2I3YYV0pZniJifvPTY7/Zf6LNDFQ== X-Received: by 2002:a1c:37cd:: with SMTP id e196-v6mr8134789wma.84.1534175211194; Mon, 13 Aug 2018 08:46:51 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id y11-v6sm17891575wrt.4.2018.08.13.08.46.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Aug 2018 08:46:50 -0700 (PDT) Received: from d104.suse.de (nat.nue.novell.com [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id A790A12485E; Mon, 13 Aug 2018 17:46:48 +0200 (CEST) From: osalvador@techadventures.net To: akpm@linux-foundation.org Cc: mhocko@suse.com, dan.j.williams@intel.com, jglisse@redhat.com, rafael@kernel.org, david@redhat.com, yasu.isimatu@gmail.com, logang@deltatee.com, dave.jiang@intel.com, Jonathan.Cameron@huawei.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes Date: Mon, 13 Aug 2018 17:46:38 +0200 Message-Id: <20180813154639.19454-3-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180813154639.19454-1-osalvador@techadventures.net> References: <20180813154639.19454-1-osalvador@techadventures.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Salvador Before calling to unregister_mem_sect_under_nodes(), remove_memory_section() already checks if we got a valid memory_block. No need to check that again in unregister_mem_sect_under_nodes(). Signed-off-by: Oscar Salvador --- drivers/base/node.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 1ac4c36e13bb..dd3bdab230b2 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -455,10 +455,6 @@ int unregister_mem_sect_under_nodes(struct memory_block *mem_blk, NODEMASK_ALLOC(nodemask_t, unlinked_nodes, GFP_KERNEL); unsigned long pfn, sect_start_pfn, sect_end_pfn; - if (!mem_blk) { - NODEMASK_FREE(unlinked_nodes); - return -EFAULT; - } if (!unlinked_nodes) return -ENOMEM; nodes_clear(*unlinked_nodes);