From patchwork Wed Aug 15 14:42:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10566675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E630515E2 for ; Wed, 15 Aug 2018 14:42:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6DB82A902 for ; Wed, 15 Aug 2018 14:42:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CAE362A905; Wed, 15 Aug 2018 14:42:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77F012A902 for ; Wed, 15 Aug 2018 14:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CE8B6B000E; Wed, 15 Aug 2018 10:42:34 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 35C636B0010; Wed, 15 Aug 2018 10:42:34 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 184D76B0266; Wed, 15 Aug 2018 10:42:34 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by kanga.kvack.org (Postfix) with ESMTP id B1EAB6B000E for ; Wed, 15 Aug 2018 10:42:33 -0400 (EDT) Received: by mail-wr1-f69.google.com with SMTP id p12-v6so1018918wro.7 for ; Wed, 15 Aug 2018 07:42:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=d5t4JM6u128OdWFKaN6Pi+4z+3cMbUK86+f7qJ/R6T8=; b=sMN0iBsem5D8RTB5oet3QCNDQ1i3DPD9h2uHNb7eYNmY7viburSW/938fSeWUTkxJZ 0pUABLCGW6SEAsHPv7BagNbMWnmSWkdgCtPfJRf2K9JCqO5ul/Vs1+79wqFAzIf+y+YW c08PrUG4nlvaVbUCumo3uCXoRp00xx80Y2RheRq00vJjcWzSWlHyYwZ07G5MXL2Xs4zf jp6ub796lSEX7N/3J09v+ZFAaefck12IRZNpm5MmU04rSOjD9oFpSNMTY+5kWAmXMd92 o+9RpZaiysXndBHftqgwmwiiP557dKQW4kGfTlrezcHgbRJuZJi8oHk/AVETjvsuG6IU Jang== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: AOUpUlGfGRx82nTxN8djVH70N0io8gZyL2Bp1WBwUez1iSncDosBg16J fCPosjvS/JzMXGgyDtzfzHBHJZPvs1O0koV9ql2pxz85pdKtrxtWvwEJaii8l1gu69kqsGZXvST MNcPLHO9NSqAAjrRQKH55TSwQVFld+bKf8udyiZaIevXV1Mf0HDjbx5ykcqqYzt/Gu8lf8eyGUV o6GA1Pfgp9f8YwHVOXDGYuif9ZPo0xhFL8y9DNUtvXeECBZ1EqkcbyD/VGS+h9YPg52VZi6TNxV zk5KcOHPtRLNgcwUHFvGMNo3LwoGoTHFW0Zrf/w2oXkNTT99Rox/4x5IqiXiCTX0Y3RejMJXbwt JGQ+kBZ+s4/oIaOHi9mVbx24CWbkkgvrpfENfI2HTXNChqkC2Z9Q1MdrEWqrghs0qJ3GZwuUfQ= = X-Received: by 2002:adf:e584:: with SMTP id l4-v6mr16263346wrm.190.1534344153274; Wed, 15 Aug 2018 07:42:33 -0700 (PDT) X-Received: by 2002:adf:e584:: with SMTP id l4-v6mr16263319wrm.190.1534344152351; Wed, 15 Aug 2018 07:42:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534344152; cv=none; d=google.com; s=arc-20160816; b=dO3digLx1aSpL+FyKFJlltIbTedym22ssTKLPXCQ+LPyCbZcId30qmEKasdX69gUAn KYJF601aFtRglAsZ2qoy6OFXqzqzOKnAsAU+sJIuo4jRA7oLOkan6hFAM8k2vZyb+HhB 8HHKEJ/ehLQhWhReMC5w8eGFMSMcTjk9WXr8CYvCKvqH/UbrhfLpJ65Of4/6jipru9LI MRJsoGHaCC7kHZ/bJqj/zhoBMYvqx4u6YU3OZz4I7wqrrt+DQcLSs45woj9zhsIQqyou L/B49qxsQvQZdJrWub+euYpxiQvVpIcC0wNRJdU5AyoWkFheh6ijqMaLgOn+pXDS67M/ mEgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=d5t4JM6u128OdWFKaN6Pi+4z+3cMbUK86+f7qJ/R6T8=; b=wLq9cpql0qeS5QCa0nJeT+aZY2jfVpR77W1tJ67OYNt2BHvsefPF7TKuoO8RpVXt1o LOKa59OPjL/DvAkPcsMrtH7wDq6vyISkhFZE8YRNICczHdMCPET9KLty+fRSQ5LUpN1L wOJqfoT2aA98HYAEIpgy4UxZvDlF/YqXMIQXbzQQ+Citxzx/tCSYG6Y2pkjqMJeUHpCG zz8hWjaoH8xMDmrweUcOaXhVaxhfC+kz4gnfKRrNPgcJhZGCd0b6dsw/hq03ZmeAKf20 eEUamKgJaRmkHhJ4zc6hyNQr9bsJ4umXjC2mLfaoeSPEtJIOUmiyIcL3T8KPWmAy+qUi YU1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id h6-v6sor8279655wre.67.2018.08.15.07.42.32 for (Google Transport Security); Wed, 15 Aug 2018 07:42:32 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: AA+uWPxpvGb3Z418XXlCV4EC3wi3IkPkHLUaLUA/IaP6UV+yImGQFJzLH6lWRA0daJWjS0ZfeX05Zw== X-Received: by 2002:adf:e992:: with SMTP id h18-v6mr17038910wrm.238.1534344152122; Wed, 15 Aug 2018 07:42:32 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id n7-v6sm17137985wmc.2.2018.08.15.07.42.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 07:42:30 -0700 (PDT) Received: from d104.suse.de (charybdis-ext.suse.de [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id B77E31248A1; Wed, 15 Aug 2018 16:42:28 +0200 (CEST) From: Oscar Salvador To: akpm@linux-foundation.org Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com, yasu.isimatu@gmail.com, jonathan.cameron@huawei.com, david@redhat.com, Pavel.Tatashin@microsoft.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes Date: Wed, 15 Aug 2018 16:42:19 +0200 Message-Id: <20180815144219.6014-5-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180815144219.6014-1-osalvador@techadventures.net> References: <20180815144219.6014-1-osalvador@techadventures.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Salvador We are getting the nid from the pages that are not yet removed, but a node can only be offline when its memory/cpu's have been removed. Therefore, we know that the node is still online. Signed-off-by: Oscar Salvador Reviewed-by: David Hildenbrand Reviewed-by: Pavel Tatashin --- drivers/base/node.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 81b27b5b1f15..b23769e4fcbb 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -465,8 +465,6 @@ void unregister_mem_sect_under_nodes(struct memory_block *mem_blk, if (nid < 0) continue; - if (!node_online(nid)) - continue; /* * It is possible that NODEMASK_ALLOC fails due to memory * pressure.