From patchwork Thu Aug 16 10:06:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 10567281 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2EA8139B for ; Thu, 16 Aug 2018 10:06:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF7D32856F for ; Thu, 16 Aug 2018 10:06:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C165A2A836; Thu, 16 Aug 2018 10:06:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 641542856F for ; Thu, 16 Aug 2018 10:06:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32B756B026B; Thu, 16 Aug 2018 06:06:57 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2B4A56B026C; Thu, 16 Aug 2018 06:06:57 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 157FD6B026D; Thu, 16 Aug 2018 06:06:57 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by kanga.kvack.org (Postfix) with ESMTP id D7E836B026B for ; Thu, 16 Aug 2018 06:06:56 -0400 (EDT) Received: by mail-qk0-f198.google.com with SMTP id m2-v6so3855289qka.9 for ; Thu, 16 Aug 2018 03:06:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=ZK8vEAn6/4gnVz/ZB766goJEE7u/KMHw+ZZsajH12tA=; b=bVEuMXzLepzEir1m1FLPZWjBfK3p1CAS+S9KHG1Sj7G3bcE2JLZzfdEsm2w1sQ158l 36BvogwFblDsfgRckSF0hMrtwJncFbbHolmZ2QpKtCl95xmD0CN1+dgyD9+fB7NFOmpc f9C8qWwyuy2sM3NyKBawLszgqNwhlGwsG3OfVqfzu2PrXNJ7+V9ZXxl8Wb+QW7VayLht OsSm/atXVlIQqq6f9hU/OpE3y87SCDOtaUWtObGugvG5daE9yp2YZo6OMaY699rfVYuF RwZrD6/WfDOwcip5ZZ72QEG9v6rNRXKEg+BvRKkgeVNOCyCgY1wFV2X+XVEzQymgNKpM Xh5Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: AOUpUlEdNn7xUE3GvCGBquYNKPVo2njrBWhAau4JX4Dt2uyM/pemePUj m/GCi0HziBCmqgtp2ciOThv+MoMRONKuqB2dtKJY6ALw9Anck1mFcnY4nM/nnU6V5EanakCSStX 0TrpYKa988kK9m0UX3qCd931ELYhZ+WqWRoY1QRiASDUHd+lbUfqD9ra7Lh2CM7s6CQ== X-Received: by 2002:ac8:1019:: with SMTP id z25-v6mr29182765qti.25.1534414016633; Thu, 16 Aug 2018 03:06:56 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx2Pz4YkABXG+uiH4zzQKLZbbgCnghlkhkaSlOLBHVU8aRcwMOVLniYRCvqQTVJbql7W8m+ X-Received: by 2002:ac8:1019:: with SMTP id z25-v6mr29182728qti.25.1534414016052; Thu, 16 Aug 2018 03:06:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534414016; cv=none; d=google.com; s=arc-20160816; b=U6HJMDCzg08bNwfI9o4f1PTrYbUwYMA+Pmhsgj4QVtqijOL/qa0ZMjuTcWGvCYA+lq zqorWoUfP1b/wPYbrGuthSgQeWgNYgW9kSnV+3anIH+9J+91nsnIhfdzeVNuNvnk3+Oz fm0chN7yA1fo6q5DvMMqA+o9kAYHQPAawP8k9NntY+RLogPDMpcHmWU3+Nst0vhsP92G P5rqzDhmUJqglFgj4ZwvxeU2mB1BZt0Yg22e7s7+p1BJnxWSRtB7Vd/psCFXTjW9Qkuv tTwgCRMG9hLMMIJvCu0cJ9d1Q6LCNMWDwDDKPRRL9ke4rMUntKXsDgIsPl1eh4W8jPHy YPYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ZK8vEAn6/4gnVz/ZB766goJEE7u/KMHw+ZZsajH12tA=; b=T48nGp57nEnYijzqqii4jyMYak+oWg93yHLwTLHTNVxJkfGeadfCnes+n0a7wD0Apj xAIeonW0Sk7GncJP6Sa/6S5UbfEYIXZ6KgqCwdVNMK3Kw9OMlIm9cOsEyzA1TYOT2c30 uu2yOTsAd1xHcU2xRtbd9MUNi4KSGu/rCgGv/4VnIf15R+YKxLWPk7fBAojr8SxZgPks IQKmhUN+k/kYs8Z7ZYsxaim6/br0IevViWI7jD1LXA+NnmCdA1qoiWtMj6QkGqKguPNP Mt6fBnuH/rZHNKMfQ9UBpDfQUyKvES98YnvKVyJvjfrfub0j63IKazenf1Xympzjaz+d qneQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id 30-v6si2579993qvt.193.2018.08.16.03.06.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Aug 2018 03:06:56 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) client-ip=66.187.233.73; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 66.187.233.73 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D82C400E9BA; Thu, 16 Aug 2018 10:06:55 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id C70011010413; Thu, 16 Aug 2018 10:06:49 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Vlastimil Babka , Stephen Rothwell , Pavel Tatashin , Kemi Wang , David Rientjes , Jia He , Oscar Salvador , Petr Tesarik , Andrey Ryabinin , Dan Williams , David Hildenbrand , Mathieu Malaterre , Baoquan He , Wei Yang , Ross Zwisler , "Kirill A . Shutemov" Subject: [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() Date: Thu, 16 Aug 2018 12:06:28 +0200 Message-Id: <20180816100628.26428-6-david@redhat.com> In-Reply-To: <20180816100628.26428-1-david@redhat.com> References: <20180816100628.26428-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 16 Aug 2018 10:06:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 16 Aug 2018 10:06:55 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'david@redhat.com' RCPT:'' X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Let's try to minimze the noise. Signed-off-by: David Hildenbrand --- mm/memory_hotplug.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index bbbd16f9d877..6fec2dc6a73d 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -966,9 +966,11 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ return 0; failed_addition: +#ifdef CONFIG_DEBUG_VM pr_debug("online_pages [mem %#010llx-%#010llx] failed\n", (unsigned long long) pfn << PAGE_SHIFT, (((unsigned long long) pfn + nr_pages) << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_ONLINE, &arg); return ret; } @@ -1660,7 +1662,9 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages) offlined_pages = check_pages_isolated(start_pfn, end_pfn); if (offlined_pages < 0) goto repeat; +#ifdef CONFIG_DEBUG_VM pr_info("Offlined Pages %ld\n", offlined_pages); +#endif /* Ok, all of our target is isolated. We cannot do rollback at this point. */ offline_isolated_pages(start_pfn, end_pfn); @@ -1695,9 +1699,11 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages) return 0; failed_removal: +#ifdef CONFIG_DEBUG_VM pr_debug("memory offlining [mem %#010llx-%#010llx] failed\n", (unsigned long long) start_pfn << PAGE_SHIFT, ((unsigned long long) end_pfn << PAGE_SHIFT) - 1); +#endif memory_notify(MEM_CANCEL_OFFLINE, &arg); /* pushback to free area */ undo_isolate_page_range(start_pfn, end_pfn, MIGRATE_MOVABLE);