From patchwork Fri Aug 17 09:00:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10568545 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9545A1575 for ; Fri, 17 Aug 2018 09:00:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83E0F2B039 for ; Fri, 17 Aug 2018 09:00:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77CB92B056; Fri, 17 Aug 2018 09:00:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 106052B039 for ; Fri, 17 Aug 2018 09:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4B6C6B0722; Fri, 17 Aug 2018 05:00:25 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id A1AD56B0750; Fri, 17 Aug 2018 05:00:25 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75B2D6B0722; Fri, 17 Aug 2018 05:00:25 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by kanga.kvack.org (Postfix) with ESMTP id 18EE36B074F for ; Fri, 17 Aug 2018 05:00:25 -0400 (EDT) Received: by mail-wr1-f70.google.com with SMTP id t10-v6so5156994wrs.17 for ; Fri, 17 Aug 2018 02:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=3ECCH/k6jiVWi1l5eaaCRKhrwOJOvg2mUyo3PfA9i7w=; b=n9Aw5zrdUIqcHGl3giCavgDd0xSXU80yP1fPOb4/vfShiNxPRQWqW+EVA6KC6iVFj9 dYUQy5twFRUCzwvnopJTLjiAprGGhJO+ktpOQ8Hn57ekH6IDjU1dIjtZ7v4a21cPqNF1 LkNTNcWdGFhDX56lDVsbG8DmvSh6XtErTcMKDcQ8vVk5SFQ7Hqi/tvN+CrOW2JYuhLZn AInuxRqqolTNaQq2cVEs9AHOwrXGD5GayytBAiRFWltJegPf5YyqlRA+az4XixWeGIIY DzxVMgM+KAqL7ZlNntGrZuLApZjhqs7jifG5/Tm2yzT5uxYuHTJ/qo4FxnsMOKqb3wCd 1raQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: AOUpUlEM0gBUooT8bjSfGHqXL2nLlBYUPo5sesM+Iy6UXSv5pIl6WXfC WJ5lShPcugWe+RQQIm53alOccZok5TFsxpCsOPn27dpGgXy+glilzHn/kxj44pIUrYkaSKd9dSx cZZunsSwUTW11DrT3yU0G8VViUN3GpQUOPYW9fhKDCjOMyHVdtYL43cFgUmuFuGjVjxlNL4aHmv zPsWBVzTBnG01JpeyP49GyopeCpfhS5mIkMXsWQrzV6e47ClZVLZFrDFQqvjLu5FzcxIm4OINKV olq1cXz2TAjnP8685TL3HCfAniBILJBQ3bmQO4XoSpeKyAgBZJKz0syuc8CJjFZVXj6UqoZPmwd itgK4G9n2sRN6GCYX/hT5nubUEcEd/+sapbDyjFEagGxzdJVadVrzvAXXIMcC4U5wH7u/EWpvQ= = X-Received: by 2002:a1c:b58e:: with SMTP id e136-v6mr17138263wmf.141.1534496424577; Fri, 17 Aug 2018 02:00:24 -0700 (PDT) X-Received: by 2002:a1c:b58e:: with SMTP id e136-v6mr17138223wmf.141.1534496423815; Fri, 17 Aug 2018 02:00:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534496423; cv=none; d=google.com; s=arc-20160816; b=VpwhL1rpIUsTT771Lhu011T/5MJdG3nwXuD6PSkTvKTW6CwrMgzJ6wGj5Sh8b0stVg HW4Km0xzhVds0IIbT/KMG19u0cOe31gBA33TaxVWGibYZi24/jCGcMCTMRh6s+TqEOzT GJrRdsLCWVgZjgyRE9nKQCqRoDYLTTpIgljkKFCCzMvGhtqM27z550i3CgDZA+V78PGP i6JD8y7P1YbmkSI3+CW2VPOtweUWOPmA9Q56dRXyRa7epj8GDRPnjyTltV9pCAliUsLm mxQa1eSsmnnYQwBr6ulZOpfY2ecLAI0qWl8EwKyatErzEIQjpcw0cEPuZ8E4mUwIfYiq /dVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=3ECCH/k6jiVWi1l5eaaCRKhrwOJOvg2mUyo3PfA9i7w=; b=Z9J/XoKH/L005hFPCcPf7bLJJE5+wvf57SDCfWwlIcQJ49thbaCPFxhrLJ9/wfWOjk bjYwxMvaVvY3oKDpjeejTNK5GPX7ShDv+ljhfSmLPdtxraVUx2rxeSVA98YRKhC1HIvm oVUFRKtVA9QJZMiNM/bwaak5jqAfAHs7J5l7HMp0DG7HD23q2RWLBKc5Twmeyt7OxYew UZ7zkzmVyJM6wEaPHdGmumoItinhPAfZw+gGbcc4uvA8VN6LNUCI/zdvmwg/2dFXAM3F WTJ6oPalUTI6pnhyKv5midOW+zS3ybXXyx5flGNijEG9IA19sGeyrl17DEFKVd4g93cl Th/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b65-v6sor897983wmh.19.2018.08.17.02.00.23 for (Google Transport Security); Fri, 17 Aug 2018 02:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: AA+uWPwK9wRdaRi5EQ3bWRQJjG8o+L8hDi6Sukw/s1xQUKIwppv6plB/HAuWpnz392b6QfpeyEa0XQ== X-Received: by 2002:a1c:6c03:: with SMTP id h3-v6mr17211304wmc.38.1534496423554; Fri, 17 Aug 2018 02:00:23 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id a84-v6sm4446308wmh.27.2018.08.17.02.00.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 02:00:22 -0700 (PDT) Received: from d104.suse.de (nat.nue.novell.com [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id 2B0A4124936; Fri, 17 Aug 2018 11:00:21 +0200 (CEST) From: Oscar Salvador To: akpm@linux-foundation.org Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com, yasu.isimatu@gmail.com, jonathan.cameron@huawei.com, david@redhat.com, Pavel.Tatashin@microsoft.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v4 2/4] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes Date: Fri, 17 Aug 2018 11:00:15 +0200 Message-Id: <20180817090017.17610-3-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180817090017.17610-1-osalvador@techadventures.net> References: <20180817090017.17610-1-osalvador@techadventures.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Salvador Before calling to unregister_mem_sect_under_nodes(), remove_memory_section() already checks if we got a valid memory_block. No need to check that again in unregister_mem_sect_under_nodes(). If more functions start using unregister_mem_sect_under_nodes() in the future, we can always place a WARN_ON to catch null mem_blk's so we can safely back off. For now, let us keep the check in remove_memory_section() since it is the only function that uses it. Signed-off-by: Oscar Salvador Reviewed-by: Andrew Morton Reviewed-by: Pavel Tatashin Reviewed-by: David Hildenbrand --- drivers/base/node.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 1ac4c36e13bb..dd3bdab230b2 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -455,10 +455,6 @@ int unregister_mem_sect_under_nodes(struct memory_block *mem_blk, NODEMASK_ALLOC(nodemask_t, unlinked_nodes, GFP_KERNEL); unsigned long pfn, sect_start_pfn, sect_end_pfn; - if (!mem_blk) { - NODEMASK_FREE(unlinked_nodes); - return -EFAULT; - } if (!unlinked_nodes) return -ENOMEM; nodes_clear(*unlinked_nodes);