From patchwork Fri Aug 17 09:00:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10568547 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E500D139A for ; Fri, 17 Aug 2018 09:00:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5A1C2B039 for ; Fri, 17 Aug 2018 09:00:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C9DD72B042; Fri, 17 Aug 2018 09:00:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 752832B039 for ; Fri, 17 Aug 2018 09:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 937B56B074F; Fri, 17 Aug 2018 05:00:26 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8BCEB6B0750; Fri, 17 Aug 2018 05:00:26 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714116B0766; Fri, 17 Aug 2018 05:00:26 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 150B06B074F for ; Fri, 17 Aug 2018 05:00:26 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id q26-v6so687743wmc.0 for ; Fri, 17 Aug 2018 02:00:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=MfeLkrMnDV4y5R6Q7/PqTxz8z6E5Vlfpzpm0flHpXQo=; b=AYLNpAw5OD00PpC3DCFfLt2zDRFUe0WdVlli8mN1vrCXsPe0jUUmpMwtkhpfLRleSH nKsdQigyYgDPnrtwfP6qgDqIXLwMNCZ6nyqwFKL9IiU84ggkifith2svSiRPpRsD0O/V NNS8DwACE40c35l1lIxyYSrQHhdxAjxm3AQnYZuPYMNXU9kRgRnFCFQIm8rf7KO2xkQE JSftSYnsHGw35SjyhGk6Qc3rTQaXtXw9IRa6DkC40Ns2DTBFBDNSDQE69zTwdpWnvPYm DT/vBpZiXPugG2MCoshAKyGfsCsVuACzXMriQRHa04tfFyoaKc6YJgjH4O5jR3l0dlNp K72A== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: AOUpUlHlh1XHTNUt/5bMf6glQjKhsBeulnTWrTmiivcojJmxkE7zCKDc jIB5OVz8FShb5Cj7zS1+G9+2IflDgLfD5n8a1xpw5nDLg0QqzoWFF3X3MiR97jwACKVIHJrq6/h YXAxHCQGswsNCsoq/DtPzv2nFR8gz34c9JOGCTcGtoNj3LinuKmpCCz3cC2M7tBIGkq5SvxYLRb z0YFZe9Ll/XkbOlO18eI0xN9GuQBLc5IN4/L+lHAi+ri9/wyBwFVwS5JrGQcfFGGvsbXSTEBTqs 8/iduOasSl2S0UWa1fZNyQnmNkkKS5GzBEAD2AOncLDhICjkJx+85e/Vfezo0uExqw8XqjPQyyU PitN2KgKeM1HN37JyMlLvXZ4ICyqNX9U4RdK1Zaar9OLqCJllPwvcX+q5BzdHYmLR+Nh0K6Ebg= = X-Received: by 2002:a7b:c0d5:: with SMTP id s21-v6mr541493wmh.106.1534496425563; Fri, 17 Aug 2018 02:00:25 -0700 (PDT) X-Received: by 2002:a7b:c0d5:: with SMTP id s21-v6mr541457wmh.106.1534496424610; Fri, 17 Aug 2018 02:00:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534496424; cv=none; d=google.com; s=arc-20160816; b=Dddf0eZ3AvQumBEmIkLlQ9IAufTh+kq+lOsD8LzoEurP2MuuX/54wS8al6VJsR6TBF v3OydfTfBUk9aXBI6ikrBf9BvU4vAtJtoQLQPcXHgQVNClXOSxwSaYeshi0ivE6ya3Yu KFNdDh4dtez5Z+4X348Iz2FIio4JJzl+s2U18fNJSw0jzuMBgkQj6lIENAzpUYE3tFr+ fLSUXK9LXAEV7pjgzUu5kHZyxy4jpHWJE7ZILM24JV6Uho64Cz1LytL8JHxxc3npMYko x8bOiIEy43Gc8PlwOrQMurTLtbbNXq+GQgRyUsQypfLyv+07nleUCM9ZZPeLo99g9exA aRkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=MfeLkrMnDV4y5R6Q7/PqTxz8z6E5Vlfpzpm0flHpXQo=; b=QKIdFOt5gzLlhyiu1c4uEo2xTCmHvdzMDdujYslnfqkI32nBo582yKxMqadPlJ9wCL aOXCMEjlPStwL7tWkZscEy9dDXQKYxepnZTlSRR6MUzKQT+Z2n0ZuBI6L2FZolDr2X2+ H2d5otAL8c9m5ODBbG1gy18qbbRndFKQfL3mi9FQDFXODlfPPcMOm0oFUNaTEeHBv6HK 59X3LR85/UANdyyFERu9TstMctojFK9rTorxCu+OyON27a5AaILIwYNWZBPGYZ9t08Nf 7zusw+UqfEDRYl2X86JUlDvGbWmR6GeNcrCcMu1ksILoGlgvcf10FZHD6woRslunK+Oo WwCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 68-v6sor752708wmj.38.2018.08.17.02.00.24 for (Google Transport Security); Fri, 17 Aug 2018 02:00:24 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: AA+uWPy/pwRZnkedISFcrKnIaUEnl/GVgL8mdCGJ851HnZDLaVDLDdDhn3xlCnxImgLL1CcmheN42A== X-Received: by 2002:a1c:f60c:: with SMTP id w12-v6mr17479406wmc.80.1534496424377; Fri, 17 Aug 2018 02:00:24 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id f23-v6sm2105975wmc.42.2018.08.17.02.00.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 02:00:23 -0700 (PDT) Received: from d104.suse.de (nat.nue.novell.com [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id B4EE6124938; Fri, 17 Aug 2018 11:00:21 +0200 (CEST) From: Oscar Salvador To: akpm@linux-foundation.org Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com, yasu.isimatu@gmail.com, jonathan.cameron@huawei.com, david@redhat.com, Pavel.Tatashin@microsoft.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v4 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes Date: Fri, 17 Aug 2018 11:00:17 +0200 Message-Id: <20180817090017.17610-5-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180817090017.17610-1-osalvador@techadventures.net> References: <20180817090017.17610-1-osalvador@techadventures.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Salvador We are getting the nid from the pages that are not yet removed, but a node can only be offline when its memory/cpu's have been removed. Therefore, we know that the node is still online. Signed-off-by: Oscar Salvador Reviewed-by: David Hildenbrand Reviewed-by: Pavel Tatashin --- drivers/base/node.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 6b8c9b4537c9..01e9190be010 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -464,8 +464,6 @@ void unregister_mem_sect_under_nodes(struct memory_block *mem_blk, if (nid < 0) continue; - if (!node_online(nid)) - continue; if (node_test_and_set(nid, unlinked_nodes)) continue;