From patchwork Wed Aug 22 09:32:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10572775 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2CFD8112E for ; Wed, 22 Aug 2018 09:32:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20656298D3 for ; Wed, 22 Aug 2018 09:32:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14FD92AAEC; Wed, 22 Aug 2018 09:32:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC267298D3 for ; Wed, 22 Aug 2018 09:32:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BACEA6B23AF; Wed, 22 Aug 2018 05:32:35 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B324B6B23B1; Wed, 22 Aug 2018 05:32:35 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 911D56B23AF; Wed, 22 Aug 2018 05:32:35 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 2D5576B23AC for ; Wed, 22 Aug 2018 05:32:35 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id s18-v6so1390180wmc.5 for ; Wed, 22 Aug 2018 02:32:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=Wz8/ynznSqcf8dsCpQK0BPCP5e0b9FrI7V6UJn+hlEA=; b=Tg2mvuz6xCfuWSVjzN1/+WZFTf5DJr9YIi3te2qAVZ6PQcooPX/MBfzZ4zyGQ7eSHz XMJnDG2M/3QfHhmxLrvsQTMjFl9xlTNZO1H0+szPObd2GAprksQkE6hM43ylCjpdiY71 Tf/ykZUS4q5mF9deS3z+gkJslctDiLlc1guLazqb74A2xKLLskDEMaFHVdSOkSY4zGWh 1e1wrAHDh7nBP4kVDeS0ld/RWyjbT3ocxM5OQJ5K0trflDT0rJTuZLxLrE/QQbcJjw6F tucx/cwlT1oMzvcmWYz6Acq78IH/flD6K5R8TFHIZSkoBI2Qcbut+3+OlNkXbMkFJ6Qa 7Uww== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: APzg51DioyXIf7tQiolOrCABDIdwrX89kVqIU7hMnIrsGSvZDP67mDgx sU296iOWIqM3jVG2+rl6/9xKeZbsVcrmHaZ42EAx3+1jz7455TrngP7zLpxYrBKw5A4XMH1TUAf ci7/u7WjRxNy38KZ1LhUY/Z4pGfNd11ksvMGmd3YvkCZVIfjrGaPzs1+008qhoXuR4rr9NfZ/AV F5aFp5SuZ9emzsdBcgdoPQQJj0MERZAPL6UWSIS/bA/72J3HhMtRjNIbKYDU64p5yWUo5GFFXUx ai5ZkI/XqlW6rTqwQ3KDRfC6cwJeWl/XW3GUjOKN6XciXmUTKJobZ4il+CAAF1wcgIP3nP+rxYy oA27hmF8T1g4YoHxj/uDyD7oD2k1+v8eARs0Qc4jVDDAgnKxJSmbVE5ke/mvNpd5DYCD+9uEvQ= = X-Received: by 2002:a1c:3314:: with SMTP id z20-v6mr1745033wmz.95.1534930354636; Wed, 22 Aug 2018 02:32:34 -0700 (PDT) X-Received: by 2002:a1c:3314:: with SMTP id z20-v6mr1745003wmz.95.1534930353828; Wed, 22 Aug 2018 02:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534930353; cv=none; d=google.com; s=arc-20160816; b=MLa7PVQQB3qZ2rgZT4HorZPmXpMKjTbZGY2apnaoDWyccmfhBiwnNa7A8Dqn83nI/5 bTt6DN+I5h7BpVMxg4+prLITC1adXwirizvK1Rr2vBUOakRSigFhGoGMHMECrjY81XOW yC/LJluz5mlgRW7axOnYyVZHNrTP2NiWxcoh/Abg4Ln1UUvgsZg2cdUjmf6h5qo28ZZs EIoYCKhGzq7T8n6VXsRsEoKMpKN4Xp2QvcxenYeiQJ+ahoSitnRhW/t+4NOPeubZaMTe YFdGdwRW9gRHPbn5OpW/th0bo0u2wWdzchyhL2eGJ4QsztucLoooXcK0nsK+Hk2gUSWo s9GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Wz8/ynznSqcf8dsCpQK0BPCP5e0b9FrI7V6UJn+hlEA=; b=ZbFV3xrx15ZQIuXwHvy3RPsj4Hw3Lti9nsvcqsOWZgTpQedoEnNsOTLzXHkBgGANIz 97/B3U0HXQ+JwurXwNPo5crxe6/ups/GV5yy8MSP606+IZwxAQ4ecPYKqj/R54sWItSr 28FC+Ne+/83kgCRZQrI0vQnIJSKf+MQzLk+zxh3bwA6+40I4E91K+SjLz9zc+e9/z8Rp NnP/Q30s1MLWJUSgIWqNe+8TenaQOAZMy1qZ19iOHipmslM5d+1mNYcxbpxxM4owiEda k3InxcaOfA5Gdv73zOaMkIjH2jqSoN3fH+9UZsaWZPiAzIPGrWn+eG9jR/3bJ8nDrnTs tpTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g5-v6sor338492wme.55.2018.08.22.02.32.33 for (Google Transport Security); Wed, 22 Aug 2018 02:32:33 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: ANB0VdbHrwXHXSCrKU8pWVOCF9UhkYpALTex3Krz0ZWw3HwbSHiQkxhOSXexVU1R2czef+JwNwC86g== X-Received: by 2002:a1c:6f8b:: with SMTP id c11-v6mr1937798wmi.138.1534930353518; Wed, 22 Aug 2018 02:32:33 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id t13-v6sm940418wrr.74.2018.08.22.02.32.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Aug 2018 02:32:32 -0700 (PDT) Received: from d104.suse.de (nat.nue.novell.com [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id 2DF57124A14; Wed, 22 Aug 2018 11:32:31 +0200 (CEST) From: Oscar Salvador To: akpm@linux-foundation.org Cc: mhocko@suse.com, dan.j.williams@intel.com, malat@debian.org, david@redhat.com, Pavel.Tatashin@microsoft.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Oscar Salvador Subject: [RFC PATCH 2/5] mm/memory_hotplug: Avoid node_set/clear_state(N_HIGH_MEMORY) when !CONFIG_HIGHMEM Date: Wed, 22 Aug 2018 11:32:23 +0200 Message-Id: <20180822093226.25987-3-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180822093226.25987-1-osalvador@techadventures.net> References: <20180822093226.25987-1-osalvador@techadventures.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Salvador Currently, when !CONFIG_HIGHMEM, status_change_nid_high is being set to status_change_nid_normal, but on such systems, N_HIGH_MEMORY equals N_NORMAL_MEMORY. That means that if status_change_nid_normal is not -1, we will perform two calls to node_set_state for the same memory type. Set status_change_nid_high to -1 for !CONFIG_HIGHMEM, so we skip the double call in node_states_set_node. The same goes for node_clear_state. Signed-off-by: Oscar Salvador --- mm/memory_hotplug.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 4a89915e1467..1cfd0b5a9cc7 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -724,7 +724,11 @@ static void node_states_check_changes_online(unsigned long nr_pages, else arg->status_change_nid_high = -1; #else - arg->status_change_nid_high = arg->status_change_nid_normal; + /* + * When !CONFIG_HIGHMEM, N_HIGH_MEMORY equals N_NORMAL_MEMORY + * so setting the node for N_NORMAL_MEMORY is enough. + */ + arg->status_change_nid_high = -1; #endif /* @@ -1547,7 +1551,11 @@ static void node_states_check_changes_offline(unsigned long nr_pages, else arg->status_change_nid_high = -1; #else - arg->status_change_nid_high = arg->status_change_nid_normal; + /* + * When !CONFIG_HIGHMEM, N_HIGH_MEMORY equals N_NORMAL_MEMORY + * so clearing the node for N_NORMAL_MEMORY is enough. + */ + arg->status_change_nid_high = -1; #endif /*