From patchwork Sun Aug 26 23:49:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naoya Horiguchi X-Patchwork-Id: 10576345 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5FB9514E1 for ; Sun, 26 Aug 2018 23:51:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4428B296FE for ; Sun, 26 Aug 2018 23:51:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37E1129723; Sun, 26 Aug 2018 23:51:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5A2B296FE for ; Sun, 26 Aug 2018 23:51:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 209CE6B3D80; Sun, 26 Aug 2018 19:51:03 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 1B7546B3D81; Sun, 26 Aug 2018 19:51:03 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CE966B3D82; Sun, 26 Aug 2018 19:51:03 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id DB79F6B3D80 for ; Sun, 26 Aug 2018 19:51:02 -0400 (EDT) Received: by mail-it0-f70.google.com with SMTP id n194-v6so7126209itn.0 for ; Sun, 26 Aug 2018 16:51:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:thread-topic:thread-index:date:message-id:references :in-reply-to:accept-language:content-language:content-id :content-transfer-encoding:mime-version; bh=4doo7Os/SUMkXXrNUs/9EOOKu2ZlqMaAEPR9/PjNuLE=; b=SR+dgKyaeTlJDdyYQgRAdDLrON/TD40XUYpmlGqu3G9bt1E8Zz9rgxCHsmzfWbhLyW XrQiqRV3B5+xFyjaSJTSQuhNJJaZYdFRiRCPHjUH5/uP4ruTxNNqYh04gWLRi52mQQsh 0jlk7RWNbi+sUZcL2TThOZme45FWF67j6ch1GEw6u167Mu+wA0CEgXnaQ4bW4jjW4Q0S 7tIV3xfOG7GumqXxhCRwwPqulXwLP7Um8x52WSbxYYZsuNwepkk/bqZ3n2t1prxGutAO nSKxUPacDHCKFf8L7NxsHmPo/3cZo7Qoj0Z+wJAE9Xzfl31fnHYKHv0h5S3EcQc5/fF4 8pCw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of n-horiguchi@ah.jp.nec.com designates 114.179.232.162 as permitted sender) smtp.mailfrom=n-horiguchi@ah.jp.nec.com X-Gm-Message-State: APzg51AGe0NGUzmX0P1zzLTGoZironA9zHgzHQpl/6joxvzCg87qQq45 JlqqO7rPt85erpLxwUkVlCNveaHktCLXSXkfDGVm1eLN8eql00IuGBTm65LqfYE/GylLGYhwUA5 maYSaePV3PCymquwcnYXavAFO3hlBY5r1AKQx2uYV1tQWstimI4S0ryaOt86aArlOQg== X-Received: by 2002:a6b:1cc9:: with SMTP id c192-v6mr3668402ioc.127.1535327462655; Sun, 26 Aug 2018 16:51:02 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbxmVI7VUCaEKD346WkXewS76/ccIgIHHKDQa3/4Gb6R916zI/yHTtHEu+ujxAGKeK6Yukd X-Received: by 2002:a6b:1cc9:: with SMTP id c192-v6mr3668388ioc.127.1535327461899; Sun, 26 Aug 2018 16:51:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535327461; cv=none; d=google.com; s=arc-20160816; b=rIqqffupZtnBQyQ/XIJMIn+2vGQ+6cEYoqa3BaIo6xJiQui5n3zASqqTeN7anocThd cV08tIt1EV3STIAt3k8DUdnPRs4R3ZMRAbyZCUZHlSIMGmzwUtcHMOSWx40d3j6E2ed0 dOCqfgT2gJkUOgdtilpbUHc0Na8t7h/Pips9mgdra8XY2UvqkOfe1qLUVLBj1dY1WMZ1 VRI7vp5ravsqwIgZ8Ws0IAyEEoXyaZWfKLT6E/dWe3g4wniBmfk8dxyqP+pcjqIgTKOS hk6gBgZ3z0N9ssMQscDrfmHVRxaG73Vt33U5Gyd8USl3sjq/SUZnGBjClvEzmutRP0oM s5WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:arc-authentication-results; bh=4doo7Os/SUMkXXrNUs/9EOOKu2ZlqMaAEPR9/PjNuLE=; b=yFg5mxQZfAtg0NtU6Y+pVbLXqzCUpiwM85Y+nQRxGFYMPBrLdEITLXuw/WRnwca5fg GRaOTLlUuqX3Cw/sq+H27hjOBICvcTjjl9gNMW/Ymc1ZJSesiR8aCqpeaT5FWQPI6sTz 8qtSIx4qkTsBcFtjMSWiCzuxhdSREohFvTA+xmjlmFFoB4o+FsJiqc2lcX/T8e2XRxVs p1iz5vK1m1At5Dc3d6vRL7SSpVlXzzIy5kA6q/iUxZYFzvY2ZXd0JM/sjonOctj9XJ7E VJLbmBGPKwomZiUIjAztBxNsbQzyshUbQVEGrz/B96/Jl3C+Muzm0V5uQJwGm9ZBFrEF 1Khg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of n-horiguchi@ah.jp.nec.com designates 114.179.232.162 as permitted sender) smtp.mailfrom=n-horiguchi@ah.jp.nec.com Received: from tyo162.gate.nec.co.jp (tyo162.gate.nec.co.jp. [114.179.232.162]) by mx.google.com with ESMTPS id k88-v6si9419220jad.47.2018.08.26.16.51.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Aug 2018 16:51:01 -0700 (PDT) Received-SPF: pass (google.com: domain of n-horiguchi@ah.jp.nec.com designates 114.179.232.162 as permitted sender) client-ip=114.179.232.162; Authentication-Results: mx.google.com; spf=pass (google.com: domain of n-horiguchi@ah.jp.nec.com designates 114.179.232.162 as permitted sender) smtp.mailfrom=n-horiguchi@ah.jp.nec.com Received: from mailgate01.nec.co.jp ([114.179.233.122]) by tyo162.gate.nec.co.jp (8.15.1/8.15.1) with ESMTPS id w7QNoYm1007133 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 27 Aug 2018 08:50:34 +0900 Received: from mailsv02.nec.co.jp (mailgate-v.nec.co.jp [10.204.236.94]) by mailgate01.nec.co.jp (8.15.1/8.15.1) with ESMTP id w7QNoYnx003127; Mon, 27 Aug 2018 08:50:34 +0900 Received: from mail03.kamome.nec.co.jp (mail03.kamome.nec.co.jp [10.25.43.7]) by mailsv02.nec.co.jp (8.15.1/8.15.1) with ESMTP id w7QNnDe3017152; Mon, 27 Aug 2018 08:50:34 +0900 Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.149] [10.38.151.149]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-3052741; Mon, 27 Aug 2018 08:49:49 +0900 Received: from BPXM23GP.gisp.nec.co.jp ([10.38.151.215]) by BPXC21GP.gisp.nec.co.jp ([10.38.151.149]) with mapi id 14.03.0319.002; Mon, 27 Aug 2018 08:49:48 +0900 From: Naoya Horiguchi To: Matthew Wilcox CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: [PATCH v2] tools/vm/slabinfo.c: fix sign-compare warning Thread-Topic: [PATCH v2] tools/vm/slabinfo.c: fix sign-compare warning Thread-Index: AQHUPZd49tQkGd6j1UO2OK3DHhN73Q== Date: Sun, 26 Aug 2018 23:49:47 +0000 Message-ID: <20180826234947.GA9787@hori1.linux.bs1.fc.nec.co.jp> References: <1535103134-20239-1-git-send-email-n-horiguchi@ah.jp.nec.com> <20180826022114.GA23206@bombadil.infradead.org> In-Reply-To: <20180826022114.GA23206@bombadil.infradead.org> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.51.8.80] Content-ID: <4AAD8CA9736C6A4BBEB17E32908E4524@gisp.nec.co.jp> MIME-Version: 1.0 X-TM-AS-MML: disable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Aug 25, 2018 at 07:21:14PM -0700, Matthew Wilcox wrote: > On Fri, Aug 24, 2018 at 06:32:14PM +0900, Naoya Horiguchi wrote: > > - int hwcache_align, object_size, objs_per_slab; > > - int sanity_checks, slab_size, store_user, trace; > > + int hwcache_align, objs_per_slab; > > + int sanity_checks, store_user, trace; > > int order, poison, reclaim_account, red_zone; > > + unsigned int object_size, slab_size; > > Surely hwcache_align and objs_per_slab can't be negative either? > Nor the other three. So maybe convert all seven of these variables to > unsigned int? > Fair enough, I update the patch. Thanks for the comment. - Naoya --- From 25e19ce711cdb4aa5c4f1a04784017af48616e5f Mon Sep 17 00:00:00 2001 From: Naoya Horiguchi Date: Fri, 24 Aug 2018 18:22:40 +0900 Subject: [PATCH v2] tools/vm/slabinfo.c: fix sign-compare warning Currently we get the following compiler warning: slabinfo.c:854:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (s->object_size < min_objsize) ^ due to the mismatch of signed/unsigned comparison. ->object_size and ->slab_size are never expected to be negative, so let's define them as unsigned int. Signed-off-by: Naoya Horiguchi --- tools/vm/slabinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c index f82c2eaa859d..334b16db0ebb 100644 --- a/tools/vm/slabinfo.c +++ b/tools/vm/slabinfo.c @@ -30,8 +30,8 @@ struct slabinfo { int alias; int refs; int aliases, align, cache_dma, cpu_slabs, destroy_by_rcu; - int hwcache_align, object_size, objs_per_slab; - int sanity_checks, slab_size, store_user, trace; + unsigned int hwcache_align, object_size, objs_per_slab; + unsigned int sanity_checks, slab_size, store_user, trace; int order, poison, reclaim_account, red_zone; unsigned long partial, objects, slabs, objects_partial, objects_total; unsigned long alloc_fastpath, alloc_slowpath;