From patchwork Wed Sep 26 23:28:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Duyck X-Patchwork-Id: 10617033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA190175A for ; Wed, 26 Sep 2018 23:29:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9916D2B1E5 for ; Wed, 26 Sep 2018 23:29:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D6692B1EB; Wed, 26 Sep 2018 23:29:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11D6B2B1E5 for ; Wed, 26 Sep 2018 23:29:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A6A58E0004; Wed, 26 Sep 2018 19:29:12 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 300FF8E0001; Wed, 26 Sep 2018 19:29:12 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 217178E0004; Wed, 26 Sep 2018 19:29:12 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id DAE518E0001 for ; Wed, 26 Sep 2018 19:29:11 -0400 (EDT) Received: by mail-pf1-f200.google.com with SMTP id j15-v6so745564pfi.10 for ; Wed, 26 Sep 2018 16:29:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:from :to:cc:date:message-id:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=jhjxZvBjszQ5RnptR/+F6TSTGiYG5ZGxhup5BfFu4CU=; b=eWB98w5L1l53+l0X9Ag33sJ+ubdMynk26Pps7jsfhdhstsgthr/C9nrqM8zn83h7Tw 0cPVTHTvV9kzRpSsttbpM07wKq9WVi8tielTeN/09aa8QsZjc9fXb36C3fXjsHRoLIDJ 62FKytzLCrx9D9K5cA0IC/8Dm65MmSTWkFKN3+4W0c4asDsAuRkRDawyoQX7lPFTjCBJ UZmwdKZBZBlOB0cYBVNyVXxVHTQUBB+gRWKyTUCJBvNv2AQ9o5NwcfRkdnZKNyrR8zGQ 7+WLmg63VQlW3r628KK2Pf05w0hDg174xxLnIQxx871e8gHfU8JUq7FDsPrzaAuu3JNE rAAQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of alexander.h.duyck@linux.intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=alexander.h.duyck@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: ABuFfojsHC5mgqdnYAyGaCoy3EwKSrCngQzETXyasSy6izuBys7e+H1B vSgECWTIzNc627E0m1N4BCiri0ZPRCHP0JiSgWAoSA9Irc/3SqO12Qljvhifm0BWFjfuL3qlQ14 opdUZgvj8eOYIVZf44NPHRsH4vRqxpwcOre/VHBiaXs3tXL3lAkkJItAUYtYFD0BLCg== X-Received: by 2002:a62:7501:: with SMTP id q1-v6mr8324580pfc.225.1538004551569; Wed, 26 Sep 2018 16:29:11 -0700 (PDT) X-Google-Smtp-Source: ACcGV62nq/N2kEOTURXJskhBJ4FxcGEUxVaiYf0SSNmHA71SDo3t35v1OsrlhWCwLqQoBaIoyVJD X-Received: by 2002:a62:7501:: with SMTP id q1-v6mr8324514pfc.225.1538004550260; Wed, 26 Sep 2018 16:29:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538004550; cv=none; d=google.com; s=arc-20160816; b=tSi0/jHgTkRCB1ORqzk0IKpMxocrOWt1HCu16iQxEXJVROAG0NGmWSG2BWJfQ5T03b qcXANFjmsgDrA/biO1VN3UviQTt6sEncgB3hZGQ0W9A9CveSwLpapzBPavswK+CgHmzB uclIfRMR2Bf24itDgRKw1J74PtWmMCD9Wvhuol4RWBjpehyHfG77XuFjY8HLRBO4WkAm WNM3zt8Cnl/O+fHqR8Jk8mGdXsRLuV/QZLJr7U1h21BsVZTcgvWaV8cNr03Qw+WMERVE UADlExRElJaIJarF0ucidruTZd7pt2hvg/aD8PVG80JAv1HmWhXe7jliRLXZrR1fvYKY wkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:cc:to:from:subject; bh=jhjxZvBjszQ5RnptR/+F6TSTGiYG5ZGxhup5BfFu4CU=; b=tZbWdGRpl3hfLDcXBZ5CCHlixs5IWd0EpqlMhs2w9gYWQXEMKv9U5MGh9O6frbDtTm DpFv4CTDXYkomtkmJ8J8hOo2gAYxk/PKZ4ouPaWApWWZpFhUlfFuXohULI9zVpFfKieS NT0sWyymCBC1oTMRhnljxpnaTO4vVxWAUVtD/HfMMyCD5S0cA5nvRFZpP3eZ7/Fxb8pk Fwtg73XfjGJI8ffOaE7Xov8YBRs/7wTLSQi2ZhpvZ8dO/HUi+YMLsOR4MWWTbu5se8np yBghV40NTdaCq1YbBNB+GM8l/3tQVJ+Ln1oqgvtQf950lFH0p2KSht4m5K/L/O1z/u7u g73g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of alexander.h.duyck@linux.intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=alexander.h.duyck@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga12.intel.com (mga12.intel.com. [192.55.52.136]) by mx.google.com with ESMTPS id d7-v6si360746pln.68.2018.09.26.16.29.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Sep 2018 16:29:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of alexander.h.duyck@linux.intel.com designates 192.55.52.136 as permitted sender) client-ip=192.55.52.136; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of alexander.h.duyck@linux.intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=alexander.h.duyck@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 16:29:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,308,1534834800"; d="scan'208";a="86873221" Received: from ahduyck-mobl.amr.corp.intel.com (HELO localhost.localdomain) ([10.7.198.154]) by orsmga003.jf.intel.com with ESMTP; 26 Sep 2018 16:28:26 -0700 Subject: [RFC mm PATCH 1/5] mm: Use mm_zero_struct_page from SPARC on all 64b architectures From: Alexander Duyck To: sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: pavel.tatashin@microsoft.com, mhocko@suse.com, dave.jiang@intel.com, alexander.h.duyck@linux.intel.com, dan.j.williams@intel.com, willy@infradead.org, mingo@kernel.org, khalid.aziz@oracle.com, rppt@linux.vnet.ibm.com, vbabka@suse.cz, akpm@linux-foundation.org, ldufour@linux.vnet.ibm.com, davem@davemloft.net, kirill.shutemov@linux.intel.com Date: Wed, 26 Sep 2018 16:28:26 -0700 Message-ID: <20180926232826.17365.84669.stgit@localhost.localdomain> In-Reply-To: <20180926232117.17365.72207.stgit@localhost.localdomain> References: <20180926232117.17365.72207.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This change makes it so that we use the same approach that was already in use on Sparc on all the archtectures that support a 64b long. This is mostly motivated by the fact that 8 to 10 store/move instructions are likely always going to be faster than having to call into a function that is not specialized for handling page init. An added advantage to doing it this way is that the compiler can get away with combining writes in the __init_single_page call. As a result the memset call will be reduced to only about 4 write operations, or at least that is what I am seeing with GCC 6.2 as the flags, LRU poitners, and count/mapcount seem to be cancelling out at least 4 of the 8 assignments on my system. Signed-off-by: Alexander Duyck --- arch/sparc/include/asm/pgtable_64.h | 30 ------------------------------ include/linux/mm.h | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 30 deletions(-) diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 1393a8ac596b..22500c3be7a9 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -231,36 +231,6 @@ extern struct page *mem_map_zero; #define ZERO_PAGE(vaddr) (mem_map_zero) -/* This macro must be updated when the size of struct page grows above 80 - * or reduces below 64. - * The idea that compiler optimizes out switch() statement, and only - * leaves clrx instructions - */ -#define mm_zero_struct_page(pp) do { \ - unsigned long *_pp = (void *)(pp); \ - \ - /* Check that struct page is either 64, 72, or 80 bytes */ \ - BUILD_BUG_ON(sizeof(struct page) & 7); \ - BUILD_BUG_ON(sizeof(struct page) < 64); \ - BUILD_BUG_ON(sizeof(struct page) > 80); \ - \ - switch (sizeof(struct page)) { \ - case 80: \ - _pp[9] = 0; /* fallthrough */ \ - case 72: \ - _pp[8] = 0; /* fallthrough */ \ - default: \ - _pp[7] = 0; \ - _pp[6] = 0; \ - _pp[5] = 0; \ - _pp[4] = 0; \ - _pp[3] = 0; \ - _pp[2] = 0; \ - _pp[1] = 0; \ - _pp[0] = 0; \ - } \ -} while (0) - /* PFNs are real physical page numbers. However, mem_map only begins to record * per-page information starting at pfn_base. This is to handle systems where * the first physical page in the machine is at some huge physical address, diff --git a/include/linux/mm.h b/include/linux/mm.h index 7312fb78ef31..db9aef028690 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -102,8 +102,41 @@ static inline void set_max_mapnr(unsigned long limit) { } * zeroing by defining this macro in . */ #ifndef mm_zero_struct_page +#if BITS_PER_LONG == 64 +/* This function must be updated when the size of struct page grows above 80 + * or reduces below 64. The idea that compiler optimizes out switch() + * statement, and only leaves move/store instructions + */ +#define mm_zero_struct_page(pp) __mm_zero_struct_page(pp) +static inline void __mm_zero_struct_page(struct page *page) +{ + unsigned long *_pp = (void *)page; + + /* Check that struct page is either 64, 72, or 80 bytes */ + BUILD_BUG_ON(sizeof(struct page) & 7); + BUILD_BUG_ON(sizeof(struct page) < 64); + BUILD_BUG_ON(sizeof(struct page) > 80); + + switch (sizeof(struct page)) { + case 80: + _pp[9] = 0; /* fallthrough */ + case 72: + _pp[8] = 0; /* fallthrough */ + default: + _pp[7] = 0; + _pp[6] = 0; + _pp[5] = 0; + _pp[4] = 0; + _pp[3] = 0; + _pp[2] = 0; + _pp[1] = 0; + _pp[0] = 0; + } +} +#else #define mm_zero_struct_page(pp) ((void)memset((pp), 0, sizeof(struct page))) #endif +#endif /* * Default maximum number of active map areas, this limits the number of vmas