From patchwork Fri Sep 28 05:39:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: john.hubbard@gmail.com X-Patchwork-Id: 10618949 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D698C180E for ; Fri, 28 Sep 2018 05:40:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C4CC02B16F for ; Fri, 28 Sep 2018 05:40:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B8C162B195; Fri, 28 Sep 2018 05:40:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0849E2B16F for ; Fri, 28 Sep 2018 05:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77D6A8E0008; Fri, 28 Sep 2018 01:40:04 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 703608E0007; Fri, 28 Sep 2018 01:40:04 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531DB8E0008; Fri, 28 Sep 2018 01:40:04 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by kanga.kvack.org (Postfix) with ESMTP id 11BE08E0001 for ; Fri, 28 Sep 2018 01:40:04 -0400 (EDT) Received: by mail-pg1-f198.google.com with SMTP id 186-v6so5577197pgc.12 for ; Thu, 27 Sep 2018 22:40:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=gTxV0aWUbi8aFwYtgG+7uDbNGSrkpXx/JtqQLR1W0X4=; b=rCyuLUBJ1as/t2nJ89uKRrRzK2ZWeK55zqWYr0xQXJ1FR7PZDeDB5S8/2uov5sI/Ts t2RRrLN2UkUetrhHxVJzlzWYsCmoXxQ6vWrUj2IzAKeKTk8VbXVqUMNewfh3kO5+z281 dt0O8p9FG9rXptmscVGGHfN3Q0AcYxVHXnhHAsPRUqPx6r8XH/DzuXP0Oh0qNjawLJlZ j+QSRm55mxMIAExRDlKbqOGZUKJEE2kxRATIGNEC0C1sel8/9yoIMPq95KxG5nJZVFyb wSXRM6/dMC9XOJ3TXqEWtMkIl4z3pUozv7Vb80hvxXcnq8QFKhws8JPS6PjxohQnFFip CVpQ== X-Gm-Message-State: ABuFfoikhg9HIqmoiCtsbh4IjnL9EmreTIYrLB4vb6fEGfxoHYlxv1x+ MNBwxOluiT+igoA7W05K2s0ceM9DcZcHe2nAMOvvE++Q6fnhi8ujSkGbOcLvm7TUH5rOXbgcl6c ipPkZi4tV8oh6p3KyG2e9UtMEIV0nbrcGMWdfaYxdyQXQ5wCKqwQ5m7F+jQ+SfevgZC0wPK712p 6RoSgnix7F1OxlogN385914S38FPFC8fVJbn5sViAMw98Z+OnNFhsqkdvh83Zacmem3OeHt/Ofm FMQe3Mrp/n9rwTkTtiq9ImdDzdDXQu4Yp71lg70BvU4OULm5LYRXfF5yxXG130ujYqS4i8GOLYS YtNpGVYH7M+0pxqqra9yKD1Vr3QoSj/eJkY3aVx4RLRkunLvN780v5w4VXrviqM1SH4ZhR9GO50 8 X-Received: by 2002:a63:af5b:: with SMTP id s27-v6mr1122320pgo.448.1538113203744; Thu, 27 Sep 2018 22:40:03 -0700 (PDT) X-Received: by 2002:a63:af5b:: with SMTP id s27-v6mr1122265pgo.448.1538113202839; Thu, 27 Sep 2018 22:40:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538113202; cv=none; d=google.com; s=arc-20160816; b=kgGO1ujEOScrIMxI37zuGNen5wahDVKRBk6mmftOQQQODZHiFkJnpgPWYEHMNW/dtF X8d2PHWBVp46jHDVD7aOiM20YphVZ3F1Q6Td/NJGm5vaLyjpCx6/ImRHzWPN0Mwf9+rW tcvqogcw4bhjxe0c1Ce5c65FBDiHcpludjtDHhSJMtHvxmDJyXki3N/lVvs7/ugQdGkx QmcT6rsjqVmpekBAvE3WoJv8dsUV84WUPKiwmwju0OdZiuOkocT8laZ5R2nqzxN2VzFt WmdEbxS/gOX2u57QtltOAmL/bYyqWdPxMatvKtLdLLMiT6wbNnF3xidp3p7E0vmPh/80 f5lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=gTxV0aWUbi8aFwYtgG+7uDbNGSrkpXx/JtqQLR1W0X4=; b=q+ImwmKK77Nt68u+IpDPtfs6yvHmQxMsY2WXxJ9uTXbbPSAc8dVv7xbEaOMpy033hT CfUbg5rHirpCOUHjdWlKSGY2jXntlu0jKqj91/BZnHlQxAR0uGcpHjEoPOYVyt3mOlD8 +KGHBtlgmESPekzmxRf0ELWBc/2/yzMOXNGC0m+r32v7+hYiF37QFwkya/evy08zWd28 W5R49ULwMpy/HAb34xAly5SOWkoYGowRnDQTQF9xp7jydJddrZnFCtPUC2AkgXrn2Pfk iBNhj2mCTrOdDFg3l1vnPArIkz7sp22FLdWwH6K99ySXwgzok1/mj9q1Xzo1TsPP0EAE Cadg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bDNixGuJ; spf=pass (google.com: domain of john.hubbard@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.hubbard@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 15-v6sor1117246pgt.175.2018.09.27.22.40.02 for (Google Transport Security); Thu, 27 Sep 2018 22:40:02 -0700 (PDT) Received-SPF: pass (google.com: domain of john.hubbard@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bDNixGuJ; spf=pass (google.com: domain of john.hubbard@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.hubbard@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gTxV0aWUbi8aFwYtgG+7uDbNGSrkpXx/JtqQLR1W0X4=; b=bDNixGuJlh/VViGK/IVdrd2Ya6UuePjmCtcsgKK/3jykSPzSHwUVjRr32fbM/h5Eu1 aWG7kNjNxKOjioZ+vW8NhCUe4/AWHvUKE+sTbc3smgAHTt2Mp1w3R3VVwRQwLhQ3upp4 z345xOHYP0aevKOufhDJEUGR/aRHBPJXIruZc5zPLn0NiTAHFetIb+GInBNx5Sked+RL tQmMg7HH66UETFNKv4JaGPH4Qfp2ag0aQwKy08qRSMys5TZw49jJf7/sQ2I6+era5G/Z Xnq3phaDVdsUDxIIQGQBKEDA8pNMdbl423L7RDkgYp5PhTSIB39uPk+cEli7RbXh2qHf 68Vw== X-Google-Smtp-Source: ACcGV63rxOc0Wx8ndnvvnZLm+cbC7UMeUJ/O4wKjbN4LjtpvySOpDGyJ7dXg2lbQNGsJNDt27t9iSg== X-Received: by 2002:a63:531a:: with SMTP id h26-v6mr8070623pgb.441.1538113202538; Thu, 27 Sep 2018 22:40:02 -0700 (PDT) Received: from blueforge.nvidia.com (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id u9-v6sm6569953pfi.104.2018.09.27.22.40.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 22:40:01 -0700 (PDT) From: john.hubbard@gmail.com X-Google-Original-From: jhubbard@nvidia.com To: Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , Al Viro Cc: linux-mm@kvack.org, LKML , linux-rdma , linux-fsdevel@vger.kernel.org, John Hubbard Subject: [PATCH 4/4] goldfish_pipe/mm: convert to the new release_user_pages() call Date: Thu, 27 Sep 2018 22:39:49 -0700 Message-Id: <20180928053949.5381-5-jhubbard@nvidia.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180928053949.5381-1-jhubbard@nvidia.com> References: <20180928053949.5381-1-jhubbard@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: John Hubbard For code that retains pages via get_user_pages*(), release those pages via the new release_user_pages(), instead of calling put_page(). This prepares for eventually fixing the problem described in [1], and is following a plan listed in [2]. [1] https://lwn.net/Articles/753027/ : "The Trouble with get_user_pages()" [2] https://lkml.kernel.org/r/20180709080554.21931-1-jhubbard@nvidia.com Proposed steps for fixing get_user_pages() + DMA problems. CC: Al Viro Signed-off-by: John Hubbard --- drivers/platform/goldfish/goldfish_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index fad0345376e0..1e9455a86698 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -340,8 +340,9 @@ static void __release_user_pages(struct page **pages, int pages_count, for (i = 0; i < pages_count; i++) { if (!is_write && consumed_size > 0) set_page_dirty(pages[i]); - put_page(pages[i]); } + + release_user_pages(pages, pages_count); } /* Populate the call parameters, merging adjacent pages together */