Message ID | 20181017063330.15384-6-aaron.lu@intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D90F112B for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 17 Oct 2018 06:34:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BC042A786 for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 17 Oct 2018 06:34:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0AEBE2A874; Wed, 17 Oct 2018 06:34:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DEC52A76D for <patchwork-linux-mm@patchwork.kernel.org>; Wed, 17 Oct 2018 06:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 267706B0010; Wed, 17 Oct 2018 02:33:50 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 126A86B0269; Wed, 17 Oct 2018 02:33:50 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDF106B0266; Wed, 17 Oct 2018 02:33:49 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id AE2C96B000E for <linux-mm@kvack.org>; Wed, 17 Oct 2018 02:33:49 -0400 (EDT) Received: by mail-pf1-f200.google.com with SMTP id g63-v6so9960796pfc.9 for <linux-mm@kvack.org>; Tue, 16 Oct 2018 23:33:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=e1fGaAEHRld7oLwWuf8wocQSXEQGnFQzFkkW47SU2QE=; b=VSuah5pUOuZtNmrjJvN0gePBav341j81t0/bQUuvdszqXW2+udYnSQwe3gVdIZ1syv PN947qfv3aMka2a9SydKMuWHLGjwsbkV0fLtR6xN73iBClT9e01eLf30PbaEBJTVtItj UzkG1RhnVl3xaXLj0mr3Bi5DMSlxxDg7B54RpNDh73Lw9IxiY7WWDiPf2LzybZGn+EK3 WsumAjNe+qWABDij0TRwgmYo1MkiUGe76o+gxOqx9kvsfUHuoXqdn5bTFLKHBqxSu8q4 cu5fyuJkEwOmpExRBF6/gqmUU4R6ttsjAT38W896V2fQcmueP6mY5OAIzA5x5fNejCLk E1NQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=aaron.lu@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: ABuFfoigFGqr9b/+c3D5PR2rOho5Itb+A/YULpjFxG27fVR1fsWWwcmh Q7FmRJDCaC3MHEGr6PGDd31+Nu+T1+lksknGD3CiS8C6/Ecw6nVgk5xvShIJudJwCGlnXQoOXuV VLlKORw+x0BZC2qr0Dk7FMXRTskdWoEqMncOcUcP6tF0hHMozpJ0Y4hCgcZN19QJakA== X-Received: by 2002:a17:902:1e2:: with SMTP id b89-v6mr25137444plb.296.1539758029430; Tue, 16 Oct 2018 23:33:49 -0700 (PDT) X-Google-Smtp-Source: ACcGV63ISgDlxCR/iik2lflojPBjnOnWWAbFkohrxb9ZUsIZppXduwDHLYe4uF80Hwe7S36Je20N X-Received: by 2002:a17:902:1e2:: with SMTP id b89-v6mr25137414plb.296.1539758028855; Tue, 16 Oct 2018 23:33:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539758028; cv=none; d=google.com; s=arc-20160816; b=I/DQ7Bdm9FpBNcTc/J+y37O4iuyoJwyUC1JZzSaglx4yxuUpqYXJlNFo9LXNVIH/Y2 R3Vwa9Na5KIULIJPePza+0ti8nwTPpKAjyR+Rtd8vPBQ9xycuy/DFbgGcA1svoGJhNKi 6dfdz/vtQGf+upxQ4TLheAljtdROJVmpKhXbr+nD5Sn9HPE9EZRRXRSyJO9gSb90OKnR AXxedLuqPTX/OIFGVng1LN+2yqREH/eDmEJtknoamzxGcnDlLtgTfdipbowewWXRO6cV q0QRWaVi/Wm6F2JPAZOnk/24sB9AqTKOc4fTZw/dVCMMBjGoWEET1v6JwFiVV0SCs4Nz cx6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=e1fGaAEHRld7oLwWuf8wocQSXEQGnFQzFkkW47SU2QE=; b=m6gRItWq4sgClJKTGuXsw/sXW+h6txrK5u8Xsf9GFsKO/UugRNGCyF0nip4aOvFRz+ KpoeTDJftzvOdPLgxvMR5hmlLP/EekDc8RJz0vXwrW9B7a1d2PAaosLQGhnV5ZKvIsty 7nEFcMOH8+W7FkanE69xyO0gcrEmbjNOsoprXF1+Ie9EQjg/JpWYdBvD3LKbkwOmAxZI de3vM0+EuHy+Vo+L3a6/fosoOqIrzNLVQRsf2zY+p0LQfPZ/ut320HoM99uin4xQq2Zp 28gcJylBuQOIJz2CAU65qBa4P/SuDeVJcgEliJaSJNv4VwoEswOPOl9AzJ+9cmSld2bS qgpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=aaron.lu@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga06.intel.com (mga06.intel.com. [134.134.136.31]) by mx.google.com with ESMTPS id v202-v6si1081311pgb.96.2018.10.16.23.33.48 for <linux-mm@kvack.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 23:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.31 as permitted sender) client-ip=134.134.136.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of aaron.lu@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=aaron.lu@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 23:33:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,391,1534834800"; d="scan'208";a="273090138" Received: from aaronlu.sh.intel.com ([10.239.159.44]) by fmsmga006.fm.intel.com with ESMTP; 16 Oct 2018 23:33:45 -0700 From: Aaron Lu <aaron.lu@intel.com> To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org>, Huang Ying <ying.huang@intel.com>, Dave Hansen <dave.hansen@linux.intel.com>, Kemi Wang <kemi.wang@intel.com>, Tim Chen <tim.c.chen@linux.intel.com>, Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@techsingularity.net>, Matthew Wilcox <willy@infradead.org>, Daniel Jordan <daniel.m.jordan@oracle.com>, Tariq Toukan <tariqt@mellanox.com>, Jesper Dangaard Brouer <brouer@redhat.com> Subject: [RFC v4 PATCH 5/5] mm/can_skip_merge(): make it more aggressive to attempt cluster alloc/free Date: Wed, 17 Oct 2018 14:33:30 +0800 Message-Id: <20181017063330.15384-6-aaron.lu@intel.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181017063330.15384-1-aaron.lu@intel.com> References: <20181017063330.15384-1-aaron.lu@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
Eliminate zone->lock contention for will-it-scale/page_fault1 and parallel free
|
expand
|
diff --git a/mm/internal.h b/mm/internal.h index fb4e8f7976e5..309a3f43e613 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -538,10 +538,6 @@ void try_to_merge_page(struct page *page); #ifdef CONFIG_COMPACTION static inline bool can_skip_merge(struct zone *zone, int order) { - /* Compaction has failed in this zone, we shouldn't skip merging */ - if (zone->compact_considered) - return false; - /* Only consider no_merge for order 0 pages */ if (order) return false;
After system runs a long time, it's easy for a zone to have no suitable high order page available and that will stop cluster alloc and free in current implementation due to compact_considered > 0. To make it favour order0 alloc/free, relax the condition to only disallow cluster alloc/free when problem would occur, e.g. when compaction is in progress. Signed-off-by: Aaron Lu <aaron.lu@intel.com> --- mm/internal.h | 4 ---- 1 file changed, 4 deletions(-)