From patchwork Thu Nov 15 15:45:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souptick Joarder X-Patchwork-Id: 10684643 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5109614DB for ; Thu, 15 Nov 2018 15:41:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CA012CAD3 for ; Thu, 15 Nov 2018 15:41:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A4832CB4B; Thu, 15 Nov 2018 15:41:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAA5A2CAD3 for ; Thu, 15 Nov 2018 15:41:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF64B6B03B5; Thu, 15 Nov 2018 10:41:56 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AA5116B03BD; Thu, 15 Nov 2018 10:41:56 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 994E96B03C1; Thu, 15 Nov 2018 10:41:56 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id 526696B03B5 for ; Thu, 15 Nov 2018 10:41:56 -0500 (EST) Received: by mail-pf1-f200.google.com with SMTP id g76-v6so16220892pfe.13 for ; Thu, 15 Nov 2018 07:41:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:mime-version:content-disposition:user-agent; bh=Cg6brz7mYbLRhNFEJEtQAETpRuMNOqibtuUBxg6orP4=; b=GpZlC0TpYgnuDAhjsf5lIYbea4eyauq5UkBRn1LqkdLjwulj1z+Tk+U1ILDYqzIPAe m1wGJqHZZDfjNrVwiuPb2ckldB0mpArzI8Ywl4kAh1H15cBNtMeAaxjM17DPN3d/Bz0i caMsnTXSwQNZTUsNqELJo6QVrQESzEW7vTCB19Liim5EWw/fjJIuyqYa2qdK62iwMEa4 Vx1JBp+GHYa2m/Jt6vB6ZcBlFzsiWOJgjrlRo/ct7EH7cMx0YoJZmEz6Dpr8BNBdzMkj bwkMWI1wyy4/lUDNwkiIVMAFiYLVM+g2c252eoyyyUmDavqW4OKFPBuZgQlN2Abhg0Dy lgxg== X-Gm-Message-State: AGRZ1gLTuyz5iZohmQwfR9gcTHF2Lh67HvAIgPV8KekWUrwYOw/UzMC2 N5VgtZ0+f8eCmsDtw0Fjyrmrwu0VqOsSI8a62uYmjLlMASwlXdjZ+iniTtQA861AckaFg2VQvV6 ixls40LYbx/VQbvGhpIWUYldW/9cGqfQ5ikNO15KBenLFpuBKuE+q9vJN8aBcwGRc/n7pX9laM/ oWI3CRcc/dFSaIL93g/eJZYPETT5Rn3TaG47+u/tsKXmtbxPhhgEPwkoDzfotRZmXNOpXkjTX+D LzxdLhZIyGuBuMg95TiWoRm1fWTRNL1AHgoT+kBQC243dBzLZOJxzQjcK/6GeNMfO90++0ZFiV+ 2Ajh/hq6LfcDMbKwdOQhQ1OEfJaZWViqOLhLshMliZZjQI/cE1N0TCUv5GI+3YqmQi9qEZRb1/2 w X-Received: by 2002:a62:1709:: with SMTP id 9mr6837560pfx.249.1542296515964; Thu, 15 Nov 2018 07:41:55 -0800 (PST) X-Received: by 2002:a62:1709:: with SMTP id 9mr6837514pfx.249.1542296515110; Thu, 15 Nov 2018 07:41:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542296515; cv=none; d=google.com; s=arc-20160816; b=y1kDmKkHih3qiInfZZmYk67G3Sfxaly9LGgQTaPPY8MMFrnuWZ4TJdV9t8Sp3MkRRG Rm2X9kbO731qQct3GxbAPBJG9KLUL6FAEH3O6l2YaUOYs7DK9o4P6ZClwnldHr8btdZW BKP1x06v11iIhqRj4nRJCpqRdYG67ekV9g2hHwgoSUTfr+mMI3G2b5XD0P6tRoQSIu6r 4DWFWvFVnRNTx0d6QQKH7hxJ0KxCnt52c3SjrFShqu/fYzKd3cPpUY4qRwECDzW464uT xKxgYhrTZ9RIJFPis502PFh20Tgp1daDH5CEsgoBmr7mAuDn+CyiCwIJe+s1Jh+f/EG8 m/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:dkim-signature; bh=Cg6brz7mYbLRhNFEJEtQAETpRuMNOqibtuUBxg6orP4=; b=MJxrDtBmQzVrWDTX2DU+Fk2xj3sav2fOSMZFYWEPzf8q0r5KeONyEEBuY4M3OUtnYh fMfllPs4zQHL4Hwet1DkUX0fDTgfmJiSdh7CkB1rrRTQZTBj2E1puSVHqNFxHpiTOJwt BzsihNXoMArywRhhVu3wG8ZdiMycN9CayI7utgrSH8NU6Rs85kCEFWXcfTRoJzy+0BLq PSoIVJqWqWtnKgd7ShJ0fKASoAfuIho69JcKN/FTdOQaBJ9Spjw04Gn5IO6yyhkl1jBI ++dxEDcq80ZIpC2Ks/IsXuUgDq5ekQ9k7IDxOM0SXeT0CPD0eYWbZMTdyX0kHIxLk5EB r/MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Eh6N6bxm; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id d10sor17745415pgo.78.2018.11.15.07.41.54 for (Google Transport Security); Thu, 15 Nov 2018 07:41:55 -0800 (PST) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Eh6N6bxm; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Cg6brz7mYbLRhNFEJEtQAETpRuMNOqibtuUBxg6orP4=; b=Eh6N6bxmBaJCmbCwKW3nWNFuf4BU086XyvkfRs4vTvK36lWMY6cUN0FJX1PSYvywPA imnNfFW8NM5MhtB/HlVZZcHG+VZLG6fwdGA8wfvH3nTVvJ65/UEg8XF5sPJgwcMQ+Hcp 24J7dBDK4YuAeDF1ME0tMs/isqPAtODXkGF+EuEklxGHrwSqW6x5O9XLDxpRfHpmSSvk Sm1Rl+EzeIHqJmV2GbHPGqlz3EsJ6NJzstXHM7D/kaiWLp1iZCgeJ7SAzbxnhLcdmVAD NANa4oTHJ5p9uJkn4VOq7tq40IfMMMlfkFxDrYrG6YazkS00ehOYAi289jFYFozTT7r6 m7Pg== X-Google-Smtp-Source: AJdET5c/4IUsmJbAFLjrppekHCGzB7YBq4feZP6VdbGvFFyn78AfrEs+pTt1JsSRVIRjujxms+LN6A== X-Received: by 2002:a63:5153:: with SMTP id r19mr6195032pgl.281.1542296514745; Thu, 15 Nov 2018 07:41:54 -0800 (PST) Received: from jordon-HP-15-Notebook-PC ([103.227.97.233]) by smtp.gmail.com with ESMTPSA id u127-v6sm28519773pfb.47.2018.11.15.07.41.52 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Nov 2018 07:41:53 -0800 (PST) Date: Thu, 15 Nov 2018 21:15:30 +0530 From: Souptick Joarder To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com, peterz@infradead.org, linux@armlinux.org.uk, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com, keescook@chromium.org, m.szyprowski@samsung.com, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, oleksandr_andrushchenko@epam.com, joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com, mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org Subject: [PATCH 1/9] mm: Introduce new vm_insert_range API Message-ID: <20181115154530.GA27872@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating a new function and use it across the drivers. vm_insert_range is the new API which will be used to map a range of kernel memory/pages to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Tested-by: Heiko Stuebner --- include/linux/mm_types.h | 3 +++ mm/memory.c | 28 ++++++++++++++++++++++++++++ mm/nommu.c | 7 +++++++ 3 files changed, 38 insertions(+) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 5ed8f62..15ae24f 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -523,6 +523,9 @@ extern void tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm, extern void tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end); +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count); + static inline void init_tlb_flush_pending(struct mm_struct *mm) { atomic_set(&mm->tlb_flush_pending, 0); diff --git a/mm/memory.c b/mm/memory.c index 15c417e..da904ed 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1478,6 +1478,34 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, } /** + * vm_insert_range - insert range of kernel pages into user vma + * @vma: user vma to map to + * @addr: target user address of this page + * @pages: pointer to array of source kernel pages + * @page_count: no. of pages need to insert into user vma + * + * This allows drivers to insert range of kernel pages they've allocated + * into a user vma. This is a generic function which drivers can use + * rather than using their own way of mapping range of kernel pages into + * user vma. + */ +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count) +{ + unsigned long uaddr = addr; + int ret = 0, i; + + for (i = 0; i < page_count; i++) { + ret = vm_insert_page(vma, uaddr, pages[i]); + if (ret < 0) + return ret; + uaddr += PAGE_SIZE; + } + + return ret; +} + +/** * vm_insert_page - insert single page into user vma * @vma: user vma to map to * @addr: target user address of this page diff --git a/mm/nommu.c b/mm/nommu.c index 749276b..d6ef5c7 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -473,6 +473,13 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr, } EXPORT_SYMBOL(vm_insert_page); +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count) +{ + return -EINVAL; +} +EXPORT_SYMBOL(vm_insert_range); + /* * sys_brk() for the most part doesn't need the global kernel * lock, except when an application is doing something nasty