From patchwork Mon Dec 3 18:05:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 10710217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13FB71057 for ; Mon, 3 Dec 2018 18:07:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 098D62B47E for ; Mon, 3 Dec 2018 18:07:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0FB12B48F; Mon, 3 Dec 2018 18:07:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E25B72B47E for ; Mon, 3 Dec 2018 18:07:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773C96B6A7A; Mon, 3 Dec 2018 13:07:02 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 723BE6B6A7B; Mon, 3 Dec 2018 13:07:02 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EB0D6B6A7C; Mon, 3 Dec 2018 13:07:02 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by kanga.kvack.org (Postfix) with ESMTP id 3471E6B6A7A for ; Mon, 3 Dec 2018 13:07:02 -0500 (EST) Received: by mail-ot1-f70.google.com with SMTP id t13so5992578otk.4 for ; Mon, 03 Dec 2018 10:07:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=SPE3tkVs7kyyAhNfXdmKVgnugPqRoGsxuJaKhfBQBrk=; b=MokHYOnwerpc42A9yr5jct1nBxz96JRV1j9fyxY2J/zT0ZYgnXjh4DhTD9hZ/A0u8F +9XQKoj8J163EyC3aR3ZIrrNRNoLOIsA0RynVC+m9nGR2/CmuP+hosscyQ/5X3S3FjoD cc6FfOiNYbGghhdtpEq5h/VTVJd/aSrAEtjDRozKdK2t81aPbdd+NdKwoai0meHz1b76 Z0RqvxDn4lB6tK5KYa3F7vCzp8zKsFzHaV0yFsVUytIFlyshUZEGmBiE2Srv6X4oupSq iKDcuK9pLUyLO1Fif3VS/rp2N3tmxtje/eovZ/E51lE3gJ7JRXZq0kvlcwttV0kMSGhh a2Sw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=james.morse@arm.com X-Gm-Message-State: AA+aEWaAxzuwVTlXFywLTCqC8omHSiNm6vW5DyioX0SzX2uZjAz9G88t uoE6/4x+rtjswY16FLgxLFwn7hC1ZBmDzT9foBU2JRkjaSJegzNMpKXEp+jXoMePNhP7SbYIRLz McsAESkeLuHDXkqjEA1S3ZbHwmki+yZIOA/MjHhQK0hWaeyD7Zlzc1Aj+1SHMIWTabw== X-Received: by 2002:a9d:6c3:: with SMTP id 61mr11504591otx.314.1543860421962; Mon, 03 Dec 2018 10:07:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/VLG3c3oVQRfx2IeIXBYZfJ9E14Axi6HqQE37S1wvYPF/hxGTre1UKzA3gb2x+dlPEcBRWc X-Received: by 2002:a9d:6c3:: with SMTP id 61mr11504556otx.314.1543860421148; Mon, 03 Dec 2018 10:07:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543860421; cv=none; d=google.com; s=arc-20160816; b=gbHT3EaGU+nLouBKF2VlEA//reI1ENtUsMC5pKrWaIZ4XSOaTt8lA/WHUcH4dclQwL jg2pnyZu1s2iFXhpvpiJvTjc9YwncQ/lvkW4aPfQrFg3ho3548R884yexbuDAn2Of2LZ LEGtQYyx2/nRTjh9BR6vTTkY6Fv52j2rAKW6Deb4VppfoNnWGLtnygo/jK87+1sapsFN 62pvmXZ2NxccA2IuEbP56rR+frxp9T+4rMVFsQPp6a2ClkqcXk/a5Jww76hGInOkMD92 yvCA0TsgX5gWk1X6vFdEydcD09QdokAdMXPXxNS5B3rFdGOvOPu+mFdzkrv0qRqJMGgR nmpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=SPE3tkVs7kyyAhNfXdmKVgnugPqRoGsxuJaKhfBQBrk=; b=KWdZj/VL/1TOkY4+bEoM+h7hYAcSdVVSsvAKCIEZjkgTVcMNqfXfye++DVZQR2zlk9 LqTHj8z6yqNeiXTMB9rFwt40XGTZrQB8i2oGdsM5sO51WYvrOvCvD1q0eVhYQ8cFCEY1 WQMmx8UYcKNCiGUqnnATeTXQ/TvfnjLzXEb5KsoFh1hT74oJwwDEKcaSoqhRUTeZQGQ7 GAPpI3fl2A3xKV912A2QAIB8A3UQuGwjAODbMatMgaqafiaAN3no8KGWDex9EheWlgtH ANu1D511v+F0eXh0da/PP0+DiXTW6VkRAukIXl8fxwuw3xj7w2q6KWTK73Nt3ikXRD08 8zNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=james.morse@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id e17si6869937oib.145.2018.12.03.10.07.00 for ; Mon, 03 Dec 2018 10:07:01 -0800 (PST) Received-SPF: pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of james.morse@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=james.morse@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 893ED168F; Mon, 3 Dec 2018 10:07:00 -0800 (PST) Received: from eglon.cambridge.arm.com (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B9C2C3F59C; Mon, 3 Dec 2018 10:06:57 -0800 (PST) From: James Morse To: linux-acpi@vger.kernel.org Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Borislav Petkov , Marc Zyngier , Christoffer Dall , Will Deacon , Catalin Marinas , Naoya Horiguchi , Rafael Wysocki , Len Brown , Tony Luck , Dongjiu Geng , Xie XiuQi , Fan Wu , James Morse Subject: [PATCH v7 07/25] ACPI / APEI: Remove spurious GHES_TO_CLEAR check Date: Mon, 3 Dec 2018 18:05:55 +0000 Message-Id: <20181203180613.228133-8-james.morse@arm.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181203180613.228133-1-james.morse@arm.com> References: <20181203180613.228133-1-james.morse@arm.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP ghes_notify_nmi() checks ghes->flags for GHES_TO_CLEAR before going on to __process_error(). This is pointless as ghes_read_estatus() will always set this flag if it returns success, which was checked earlier in the loop. Remove it. Signed-off-by: James Morse Reviewed-by: Borislav Petkov --- drivers/acpi/apei/ghes.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index acf0c37e9af9..f7a0ff1c785a 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -936,9 +936,6 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) __ghes_panic(ghes); } - if (!(ghes->flags & GHES_TO_CLEAR)) - continue; - __process_error(ghes); ghes_clear_estatus(ghes, buf_paddr); }