From patchwork Thu Dec 6 18:39:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souptick Joarder X-Patchwork-Id: 10716601 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 69E8D109C for ; Thu, 6 Dec 2018 18:36:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 576D52F0D6 for ; Thu, 6 Dec 2018 18:36:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A85C2F157; Thu, 6 Dec 2018 18:36:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B28E2F0D6 for ; Thu, 6 Dec 2018 18:36:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CF1C6B7B61; Thu, 6 Dec 2018 13:36:02 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 97EC76B7B62; Thu, 6 Dec 2018 13:36:02 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86F806B7B63; Thu, 6 Dec 2018 13:36:02 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id 43DEE6B7B61 for ; Thu, 6 Dec 2018 13:36:02 -0500 (EST) Received: by mail-pf1-f198.google.com with SMTP id q63so987396pfi.19 for ; Thu, 06 Dec 2018 10:36:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:mime-version:content-disposition:user-agent; bh=Oa/SZo4NTYsdsBTx0P4ctAF7OtbSigl9buobaWrjyts=; b=M5E7NDgG8U4dMC0AyTK0yXGc9lzl5l/sww2bsUwILmzrMadv2Hh4O2E9dqb1ZnYiLL U26mFndWojS1pEi7E2Oj9QVGTSQUnfpyvE7gnNdk2rNZB3gtnrX7X5BfRpg49FfcFv0a FVDVV4bFQHofPAsayPktLKPirW10c+BdDXTfZtI4M5D3v5jFfb6pJrUEdA6drU95Gfic 7vWIeAD5bbo9mKblnu/t7lvHw/pjduc4xoGgaic8K1fhITiwiRsmDL8kS7FwWsgBhKQc MKFWTJaJWWZbQg+3ehK57VR7OFjss9rah7t/nrzdVckLzxirHNNwVqUw/MN8kCGZT+0Z apCQ== X-Gm-Message-State: AA+aEWZ2l0VymXuz+nZRh12RN2dY0ca3p6A5aF7KMfVwl9YYOa/BJ30T EOenBzxu3gCwFgh7akx7/W9U2jdqEPt9n7x9gxQccubTl4taWAZRlxaIrix/Z9sSupJcPgJNZuy ldBh8sj7iIDq+eKwDTVlmPqiOfPBBuNEfLO+1bWxJoUJTcy6XWra0vUcgEnbTc0jOOBG6SVapMW K+TE0oxpJ+ZCBHUBu4FTWlCF3X8TTBinID9f4mD/x62tWVntVxlHoZtYYNu1rFJfw7B91h1/55+ m8vxJ2kJ7ykjEyv7Ssz/aU/Xf66B4zg0MXLfyulM1bGUYImFLCOwcU9vdcneFL3+EYvy+i/qWjk 0plQJEhfA2sEZ7xzj6gC7dHEk1Rh9GAvCJFVrtm9fMqbWwsJULRDZK9GJIqQaGTPKrm+aSMrCvH S X-Received: by 2002:a62:fc86:: with SMTP id e128mr235418pfh.54.1544121361792; Thu, 06 Dec 2018 10:36:01 -0800 (PST) X-Received: by 2002:a62:fc86:: with SMTP id e128mr235370pfh.54.1544121360773; Thu, 06 Dec 2018 10:36:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544121360; cv=none; d=google.com; s=arc-20160816; b=JJWJccrDmeYnojlip+3XnV7k348SoBaHGzgyWNegxWlUqpLJVtiZRkZcfXWCylxOU3 qwREJNhKL3ZQVkjS70jvLMhwK6dbamWSEiymNCRFSUrMsyYZ4GBP1YZ3BfD/hx9DGGqD 2FyOAcGYQZ1/8sWEAJw+yA9TjIOi0d1bS4+ibgfelTOwxmtX/FsAGDuA21R5Wegj02BV Rt75usNNGwQVAqKLgGn4Kzy+g+lM3M8jLuuHJ9+zhZjoaCpKYjDgjHLW/1IvBtBeHvib ZOXD/Bsl+Wvuuij4UahttrvxhOvLK+3FFj5eUimXFvGGclMxsti9rk1JU5q9FyQZhT03 5piw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:dkim-signature; bh=Oa/SZo4NTYsdsBTx0P4ctAF7OtbSigl9buobaWrjyts=; b=ZWE7iGDccBKIig44KAjK2u0/HhWCiIIaqyg0Nlx96HOKeYc1VIdY7E5FAyrTcw6NUu MKiqbfRyhJ8cbc1CdspngQJUzu95v+5xdGKah1wRa9FTMLLt5s0UiLpldRzg+1fTDVuv KN85w+EiVRqeKte/0yAui+Oz2b+gIydP+NlMKczcKAw77/Js/gbhWYRE5q4EdBT5vSBt V0DqDTV2bCy2aRl2xap5IxKtMoE42VdTWP2yRCQ30Sk+xbggOno//HIOaiMW/q2E3PSL wO9lhhGyMvXaNwBO5kIwrFeuy6lY9GTL9DaG9mUTmHe9wosV4YBRuHgBDqh/e3ZKsZIX Vd/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BS5vm9k9; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id q77sor2122398pfi.33.2018.12.06.10.36.00 for (Google Transport Security); Thu, 06 Dec 2018 10:36:00 -0800 (PST) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BS5vm9k9; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=Oa/SZo4NTYsdsBTx0P4ctAF7OtbSigl9buobaWrjyts=; b=BS5vm9k9bGLFTl+LX0bmmM9M5C7OG8qjleVkise2mkPltptK9svVJnzqEXXf1WBbb0 ci1hZudApj6H10+lYEQQczak59IqsTKG/aJp5uqzclWSGzssJ3XjOiOHbRPFUit6aUdw awp6zYPxAzYDEiPUutQH3/PjWXgzkUVgPqHp9qZz98vIUReekHUtzxSlvagqtyAczrCS GXtspLXDM8OX0uBS37pCwnH6jSXou/OORX8gep9Ie9VRObA/sjwgoW41zGJMRAt9I8SZ mn0hCyr5xvp8Bvr9AWCf70gWDWAYR72a4erJSB4QEx6QQg9n+sxzLaqCscuzTD0RhN8l 9s0Q== X-Google-Smtp-Source: AFSGD/WuBSuNZ0j2eI+y3vMK44Xcj2c9zc75ftpku5KoTRQQsbR2V1G34l5r5WGKdNdcPvf31x0YxA== X-Received: by 2002:a62:6ec8:: with SMTP id j191mr29584141pfc.198.1544121360370; Thu, 06 Dec 2018 10:36:00 -0800 (PST) Received: from jordon-HP-15-Notebook-PC ([103.227.99.39]) by smtp.gmail.com with ESMTPSA id d129sm1525051pfc.31.2018.12.06.10.35.56 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Dec 2018 10:35:59 -0800 (PST) Date: Fri, 7 Dec 2018 00:09:45 +0530 From: Souptick Joarder To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com, peterz@infradead.org, linux@armlinux.org.uk, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com, keescook@chromium.org, m.szyprowski@samsung.com, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, oleksandr_andrushchenko@epam.com, joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com, mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org Subject: [PATCH v3 1/9] mm: Introduce new vm_insert_range API Message-ID: <20181206183945.GA20932@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating a new function and use it across the drivers. vm_insert_range is the new API which will be used to map a range of kernel memory/pages to user vma. This API is tested by Heiko for Rockchip drm driver, on rk3188, rk3288, rk3328 and rk3399 with graphics. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Mike Rapoport Tested-by: Heiko Stuebner Reviewed-by: Mauro Carvalho Chehab --- include/linux/mm.h | 2 ++ mm/memory.c | 38 ++++++++++++++++++++++++++++++++++++++ mm/nommu.c | 7 +++++++ 3 files changed, 47 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index fcf9cc9..2bc399f 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2506,6 +2506,8 @@ unsigned long change_prot_numa(struct vm_area_struct *vma, int remap_pfn_range(struct vm_area_struct *, unsigned long addr, unsigned long pfn, unsigned long size, pgprot_t); int vm_insert_page(struct vm_area_struct *, unsigned long addr, struct page *); +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count); vm_fault_t vmf_insert_pfn(struct vm_area_struct *vma, unsigned long addr, unsigned long pfn); vm_fault_t vmf_insert_pfn_prot(struct vm_area_struct *vma, unsigned long addr, diff --git a/mm/memory.c b/mm/memory.c index 15c417e..84ea46c 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1478,6 +1478,44 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, } /** + * vm_insert_range - insert range of kernel pages into user vma + * @vma: user vma to map to + * @addr: target user address of this page + * @pages: pointer to array of source kernel pages + * @page_count: number of pages need to insert into user vma + * + * This allows drivers to insert range of kernel pages they've allocated + * into a user vma. This is a generic function which drivers can use + * rather than using their own way of mapping range of kernel pages into + * user vma. + * + * If we fail to insert any page into the vma, the function will return + * immediately leaving any previously-inserted pages present. Callers + * from the mmap handler may immediately return the error as their caller + * will destroy the vma, removing any successfully-inserted pages. Other + * callers should make their own arrangements for calling unmap_region(). + * + * Context: Process context. Called by mmap handlers. + * Return: 0 on success and error code otherwise + */ +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count) +{ + unsigned long uaddr = addr; + int ret = 0, i; + + for (i = 0; i < page_count; i++) { + ret = vm_insert_page(vma, uaddr, pages[i]); + if (ret < 0) + return ret; + uaddr += PAGE_SIZE; + } + + return ret; +} +EXPORT_SYMBOL(vm_insert_range); + +/** * vm_insert_page - insert single page into user vma * @vma: user vma to map to * @addr: target user address of this page diff --git a/mm/nommu.c b/mm/nommu.c index 749276b..d6ef5c7 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -473,6 +473,13 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr, } EXPORT_SYMBOL(vm_insert_page); +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count) +{ + return -EINVAL; +} +EXPORT_SYMBOL(vm_insert_range); + /* * sys_brk() for the most part doesn't need the global kernel * lock, except when an application is doing something nasty