From patchwork Mon Dec 17 20:21:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souptick Joarder X-Patchwork-Id: 10734247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F1F46924 for ; Mon, 17 Dec 2018 20:17:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE3B72A2DB for ; Mon, 17 Dec 2018 20:17:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD32F2A2E5; Mon, 17 Dec 2018 20:17:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D92A2A2DB for ; Mon, 17 Dec 2018 20:17:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FD1B8E004D; Mon, 17 Dec 2018 15:17:31 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3AB9A8E0033; Mon, 17 Dec 2018 15:17:31 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29B0F8E004D; Mon, 17 Dec 2018 15:17:31 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id DDC328E0033 for ; Mon, 17 Dec 2018 15:17:30 -0500 (EST) Received: by mail-pg1-f199.google.com with SMTP id p4so11538503pgj.21 for ; Mon, 17 Dec 2018 12:17:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:mime-version:content-disposition:user-agent; bh=LP5lsofdni2cSLjgAraOzOMBqzsN96J57RYIndiS9eY=; b=A8XB96OcKUwJc8dooFOdUCdlRtFfC31Xo8RaB7z8bosE440TXOd6zQVtdpnoEirNoX W+Wa0hlhJT5flvrsqbyC6c+ug3/GhKgHWy4jlk6ilcuS86vVmVvC/oVDjwo8BdIwqtso enH/z2/e2aoH5qNHOoUh5ntP+XkG61Xw8LSBBnG01BQiuvcewTJn0L6umbU1r+mkDRIX tEFx0/K7F1oIBYdbXipt6o/ZPOqJteM/na9+IO19bqaCrwW2g2u3W1EdQG26M+53suZA /vDc1cCHD2oY2e5lmkjVtw++vO0tTGhD+PhYye7xnOTXivlKNwQs/z56jZSf1cOe8lJ7 WUug== X-Gm-Message-State: AA+aEWZWcjL4N6gjRlyOF4t++R5btB91JNP6e9i4NSFPbw8DOmBHQqOf SdsBpMhe/ZLwVX3nftlOIi6PSoV+THVO+PqbXoJU1+PrYCDizazFpSSWPA6506uxF7t8+Xd8fE3 3rpnz11dAFXWE5LcR7Ilkb1B2vtFUyCyPNPsknJAlzrHruwnLDzcjb6qcYg12jH9MJdtTvfqAiJ Ix04+qI4mGGrknKR8Oc3e2OTx8tJA1XU5fUh6Q8pL+bTwgtf2J3eaTnT5oiD8wF9mdB4r7dx+n7 zvCw6yq796Ak6NNvayfEUhnd3hAveKRU6br6SKTldkJjHbyBinV81z5U7QjDelFShFO9pY2dyGm zUYbHNEVQvbKCzq/vGCec50LSYWdX0BtTKBqx9gWmM6mMtkfBSHCDRbjOX9HEWwyDD2ehN7AkJ4 k X-Received: by 2002:a17:902:8641:: with SMTP id y1mr13820246plt.159.1545077850480; Mon, 17 Dec 2018 12:17:30 -0800 (PST) X-Received: by 2002:a17:902:8641:: with SMTP id y1mr13820217plt.159.1545077849722; Mon, 17 Dec 2018 12:17:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545077849; cv=none; d=google.com; s=arc-20160816; b=crI3OIOTUHD+wbio1tnBL7XgmxZQQobwnKSmxfeRlNd7Q6uxqpU3ee1DBrsxZtrJlO /IVdsiO4pgvR/WIESkB5/ceXBVBVSlmfiS1eqCKTH12nkL3P5yWSuyBElfck1gLfrPSV 9uta8cBlFGEqhh/em+IXn0IB2WvGePzABcG0ykuisOnmCo/DpAMsGC+fBn7iNbIiZ7Sm dWwfvZiDLG6mUmYQQ8oUuNJq2lt/Lbh0o/GuedDioXRh4I4zK4/ckUqVfSz+CmXgXyHR VM5JnzItfFOX2f+c72WoBjvDPUq9Z5hCZlVKPbFYczCjNjr7uLcqrXRVwEnZqMgYpFmZ McUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:dkim-signature; bh=LP5lsofdni2cSLjgAraOzOMBqzsN96J57RYIndiS9eY=; b=c94FVvRjoU+0qRylyFJEBNmnTiQkeBuI9yUfBfz1wrET813iLRo/fYAqMPVXbU+mUk 1lCfYl7zlU1lKkAiFJrAow4t/+DqnkJ+xnnhd6M6alb+Gcn8o8BSktVkkZBpHI2B8x4h njsMRol0xa4JBma5nmUT5RfF9NOM1azGcGgF+yF3/wFT8fRUi9co+lB7AtlX225w6MKX 6/NbZXyOceYtDfkwGtRFN9ESwnltlfzuaE1z/kPETUkw4v/+dDwHh/hx6IjJPoDWs8gU Nx2zmDQSIMzIbvWnVpsdqHx9OA3/KtHKW0/0Q0SqRHBdRBlrX46pisBcnN50Y3Eo39k4 HYdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="p/e9LBg0"; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id n11sor22331768pfk.44.2018.12.17.12.17.29 for (Google Transport Security); Mon, 17 Dec 2018 12:17:29 -0800 (PST) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="p/e9LBg0"; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=LP5lsofdni2cSLjgAraOzOMBqzsN96J57RYIndiS9eY=; b=p/e9LBg09urJWLaio2BVun4A6kGUQCG7HWz9LLsvx7iRIBvbaKonR5S0UKsIOc35I7 SSVLxSCuJqmJlEbu5QtUruzWvMTPabWv1I6cmgAzPKZ+UoKGTtflhdKlyvEmf9RpxgjJ jgZlhJTMJQ8243EIkKtQ6gL1JidxGUbiNWT4LYKMyzoJouaLP3bUfsgcbYxIQkBi+g7L 73YRfXK3iBDh/kpNWD7HgQ1vG55H+CgsVYjWo0In+Jx/SeF7VmnhMlECM2b7QHQ0chbv +xri/+GSpBZqI9ExlEHam5pX5MDN3BwJ1Gb9xJmzHrzKGNoTgpVbEglFsGdjNrLD9aeH t2VQ== X-Google-Smtp-Source: AFSGD/X4Uak/TI8ZYtxtZsFEKfKGnP+/T22Np31XBV/bP6gFwwiKErESpa4F78Q5JQiA2M4ia/MNlw== X-Received: by 2002:a62:33c1:: with SMTP id z184mr13951345pfz.104.1545077849354; Mon, 17 Dec 2018 12:17:29 -0800 (PST) Received: from jordon-HP-15-Notebook-PC ([103.227.98.208]) by smtp.gmail.com with ESMTPSA id h129sm18659195pfb.110.2018.12.17.12.17.27 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Dec 2018 12:17:28 -0800 (PST) Date: Tue, 18 Dec 2018 01:51:21 +0530 From: Souptick Joarder To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com, peterz@infradead.org, linux@armlinux.org.uk, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com, keescook@chromium.org, m.szyprowski@samsung.com, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, oleksandr_andrushchenko@epam.com, joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com, mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org Subject: [PATCH v4 1/9] mm: Introduce new vm_insert_range API Message-ID: <20181217202121.GA4335@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating a new function and use it across the drivers. vm_insert_range is the new API which will be used to map a range of kernel memory/pages to user vma. This API is tested by Heiko for Rockchip drm driver, on rk3188, rk3288, rk3328 and rk3399 with graphics. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Mike Rapoport Reviewed-by: Mauro Carvalho Chehab Tested-by: Heiko Stuebner --- include/linux/mm.h | 2 ++ mm/memory.c | 41 +++++++++++++++++++++++++++++++++++++++++ mm/nommu.c | 7 +++++++ 3 files changed, 50 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index fcf9cc9..2bc399f 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2506,6 +2506,8 @@ unsigned long change_prot_numa(struct vm_area_struct *vma, int remap_pfn_range(struct vm_area_struct *, unsigned long addr, unsigned long pfn, unsigned long size, pgprot_t); int vm_insert_page(struct vm_area_struct *, unsigned long addr, struct page *); +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count); vm_fault_t vmf_insert_pfn(struct vm_area_struct *vma, unsigned long addr, unsigned long pfn); vm_fault_t vmf_insert_pfn_prot(struct vm_area_struct *vma, unsigned long addr, diff --git a/mm/memory.c b/mm/memory.c index 15c417e..d44d4a8 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1478,6 +1478,47 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, } /** + * vm_insert_range - insert range of kernel pages into user vma + * @vma: user vma to map to + * @addr: target user address of this page + * @pages: pointer to array of source kernel pages + * @page_count: number of pages need to insert into user vma + * + * This allows drivers to insert range of kernel pages they've allocated + * into a user vma. This is a generic function which drivers can use + * rather than using their own way of mapping range of kernel pages into + * user vma. + * + * If we fail to insert any page into the vma, the function will return + * immediately leaving any previously-inserted pages present. Callers + * from the mmap handler may immediately return the error as their caller + * will destroy the vma, removing any successfully-inserted pages. Other + * callers should make their own arrangements for calling unmap_region(). + * + * Context: Process context. Called by mmap handlers. + * Return: 0 on success and error code otherwise + */ +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count) +{ + unsigned long uaddr = addr; + int ret = 0, i; + + if (page_count > vma_pages(vma)) + return -ENXIO; + + for (i = 0; i < page_count; i++) { + ret = vm_insert_page(vma, uaddr, pages[i]); + if (ret < 0) + return ret; + uaddr += PAGE_SIZE; + } + + return ret; +} +EXPORT_SYMBOL(vm_insert_range); + +/** * vm_insert_page - insert single page into user vma * @vma: user vma to map to * @addr: target user address of this page diff --git a/mm/nommu.c b/mm/nommu.c index 749276b..d6ef5c7 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -473,6 +473,13 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr, } EXPORT_SYMBOL(vm_insert_page); +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, + struct page **pages, unsigned long page_count) +{ + return -EINVAL; +} +EXPORT_SYMBOL(vm_insert_range); + /* * sys_brk() for the most part doesn't need the global kernel * lock, except when an application is doing something nasty