| Message ID | 20181218162307.10518-1-mhocko@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory_hotplug: add missing newlines to debugging output | expand |
On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine") > Signed-off-by: Michal Hocko <mhocko@suse.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> > --- > drivers/base/memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 0e5985682642..b5ff45ab7967 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn) > return false; > > if (!present_section_nr(section_nr)) { > - pr_warn("section %ld pfn[%lx, %lx) not present", > + pr_warn("section %ld pfn[%lx, %lx) not present\n", > section_nr, pfn, pfn + PAGES_PER_SECTION); > return false; > } else if (!valid_section_nr(section_nr)) { > - pr_warn("section %ld pfn[%lx, %lx) no valid memmap", > + pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n", > section_nr, pfn, pfn + PAGES_PER_SECTION); > return false; > } else if (online_section_nr(section_nr)) { > - pr_warn("section %ld pfn[%lx, %lx) is already online", > + pr_warn("section %ld pfn[%lx, %lx) is already online\n", > section_nr, pfn, pfn + PAGES_PER_SECTION); > return false; > } > -- > 2.19.2 >
On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote: >From: Michal Hocko <mhocko@suse.com> > >pages_correctly_probed is missing new lines which means that the line is >not printed rightaway but it rather waits for additional printks. > >Add \n to all three messages in pages_correctly_probed. > >Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine") >Signed-off-by: Michal Hocko <mhocko@suse.com> Reviewed-by: Wei Yang <richard.weiyang@gmail.com> >--- > drivers/base/memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/base/memory.c b/drivers/base/memory.c >index 0e5985682642..b5ff45ab7967 100644 >--- a/drivers/base/memory.c >+++ b/drivers/base/memory.c >@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn) > return false; > > if (!present_section_nr(section_nr)) { >- pr_warn("section %ld pfn[%lx, %lx) not present", >+ pr_warn("section %ld pfn[%lx, %lx) not present\n", > section_nr, pfn, pfn + PAGES_PER_SECTION); > return false; > } else if (!valid_section_nr(section_nr)) { >- pr_warn("section %ld pfn[%lx, %lx) no valid memmap", >+ pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n", > section_nr, pfn, pfn + PAGES_PER_SECTION); > return false; > } else if (online_section_nr(section_nr)) { >- pr_warn("section %ld pfn[%lx, %lx) is already online", >+ pr_warn("section %ld pfn[%lx, %lx) is already online\n", > section_nr, pfn, pfn + PAGES_PER_SECTION); > return false; > } >-- >2.19.2
diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 0e5985682642..b5ff45ab7967 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn) return false; if (!present_section_nr(section_nr)) { - pr_warn("section %ld pfn[%lx, %lx) not present", + pr_warn("section %ld pfn[%lx, %lx) not present\n", section_nr, pfn, pfn + PAGES_PER_SECTION); return false; } else if (!valid_section_nr(section_nr)) { - pr_warn("section %ld pfn[%lx, %lx) no valid memmap", + pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n", section_nr, pfn, pfn + PAGES_PER_SECTION); return false; } else if (online_section_nr(section_nr)) { - pr_warn("section %ld pfn[%lx, %lx) is already online", + pr_warn("section %ld pfn[%lx, %lx) is already online\n", section_nr, pfn, pfn + PAGES_PER_SECTION); return false; }