From patchwork Wed Dec 26 18:09:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 10743269 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9F3A746 for ; Wed, 26 Dec 2018 18:10:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C6012858F for ; Wed, 26 Dec 2018 18:10:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7731F285FD; Wed, 26 Dec 2018 18:10:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 452372858F for ; Wed, 26 Dec 2018 18:10:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D5228E0004; Wed, 26 Dec 2018 13:10:08 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6835C8E0001; Wed, 26 Dec 2018 13:10:08 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 572958E0004; Wed, 26 Dec 2018 13:10:08 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by kanga.kvack.org (Postfix) with ESMTP id 2C1AA8E0001 for ; Wed, 26 Dec 2018 13:10:08 -0500 (EST) Received: by mail-io1-f72.google.com with SMTP id d20so13641087iom.0 for ; Wed, 26 Dec 2018 10:10:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=Mjkli9qEz3XfIBVSkjFrEei2gi2+0gsWC4P+mtUqZuE=; b=NCP4m/xQg4v2aEaW2+NvqBMXeCJ5mzX5v4BEFJV81spHttkVdy67pGpAmGbmFXdnTB UJWZk4e3ZeNycTDVtuMhcFQSMqCGJxtiH8HAOoj9HVIXuNbMoNINPAsnab8cRgisIoXe 2G+n4T3Gtn+2uKhBpSHXQXy6FFD8uaC4xmQKRoIpMQSSKniGBU0ttmi1etg3Ks5dVoWj +YKzNrhpeb9gAGnDYt4CJmUzu8DJ0w5/EWw/LdYYsfVxC45/YGaUulRJNdjSfF5sMHt1 mHd8llCLIzIWfvgH1pGNaMagwnyEzATpU+efcOz5DAN3rpo0OxZkgmKb5gXLT91S+uK/ ZTRg== X-Gm-Message-State: AA+aEWY0azuHwly4+rzpWqZWhwx9Hhs0ZFbfSR4HKNivhHBithq5FENy /+lqKXAO5gR37onkZ0DjVGOb+/ReOiZGrortxVqajyN1wlWYQJINQ/XsrxxB1H8/hcPX6w1UA45 qk8BR8bFyaIjzvVaPlm7AtCDaillI3Y7NKD6oK+rZt/KVyrmcRm/1z2jihgbbD2wJZ7tq+UqXhx nIhVteRvn3RofYbYPsQ+peTc9SiZZ0ihO3csT+sVUhgDWCpPfNdOj63s8GHKdAHQ+PxoSVMvLwD hxH+OGNbVIuN5E6fTxdyXHAKmwEHJB/cgKihKj3714eUrIngLoCUUi8/X2+sHkLJM1/LMSLrVy4 Er6TKdKCoqtk6umNAHauJKqE8vLLUAOPfj+czDXk3iPhN9hdu5LyhO9QFjKaGE6ZWrHEiI9R914 k139fuecnPN2G1y0UpJ01JEfN6zUFS9lhfw8F/o1s4m61Kdkn3z4wFPqs86+fP15h8d/ldEpT83 H1e980hjGeb5eG9RriHCFCP5W/yTgDP8MxZxr/dnsR9VYlN1b+V+9e7eSG5qqsHnz+B88l/k2ld a/pns5G7rLNs29u4bHzsS9ZPpQULMuKD5Kmf4qL+iwMEVzG X-Received: by 2002:a24:3a09:: with SMTP id m9mr12089628itm.98.1545847807800; Wed, 26 Dec 2018 10:10:07 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wk8Tq8kP2kGZ6U6+KCvj1lEygGBzzVF2rQXhkyTQKl2TLWnah9YTu1cjL0442Z5nj75drr X-Received: by 2002:a24:3a09:: with SMTP id m9mr12089598itm.98.1545847806850; Wed, 26 Dec 2018 10:10:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545847806; cv=none; d=google.com; s=arc-20160816; b=0REiq3x1GhUrYo9IojmDoBvXagrAyCIAucBBJ2ORUEEBYUmQZL69mcjQXZP3NAPKPE Weu0ZuH04+fb/V1+Fz7FvqUql27cUpCX+6WgJrDLnVe3M1ULnCu4VFuytSQ/i2HvL2v4 8TLyX3j/qN2WcXAeinRZiJvDZXXy0yBCCAu6m3di7ylXrJQpYfx3V4EpHyz3kzKReITO dWqdRLla8OM5rPa5WlILI0o4Zf0Z4HzaA6eiDxsRhxJ5mLEwmnIFPKys4OXGQTXIAXHg ufGjpDMbxOeitJXI8ixJLNtBF9yFx9M6EcoVRmGSbnEp+QA7O2ZJ6GnfLw7WBwH3R+9Q XtPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=Mjkli9qEz3XfIBVSkjFrEei2gi2+0gsWC4P+mtUqZuE=; b=kaBJnd7eFcEkCM3IPtuelZiCbPy1c2TC3W/qe93Z34fuR1ifIXtsdEzro1q5BJaUm1 MBXn+oxa6bCLYG89jXYIHWaYaAi270dAui1vGRmcPb7NGLQc8wr40zeKq4mqKf2stwd0 w36cPpT/lyze4CQq5uXrwjeSZfb4HfEWP+IB2NPu7Zcy/NtNEPh3ZbmzCxjKlcz94JMI 6hwdmkkP3xZn0WZuy+8KneyBA4x7VF+At7H9im3Y2lvHx04plQehc3vIe/zMrJaDmnUi ae+1DyjIQfADHPHF5FFok0j9X0QH/qs/DATz3/tkU3oUuuKkscjCsubyJW9Wik8S9WdM w/JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=oCQPHEd8; spf=pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) smtp.mailfrom=pakki001@umn.edu; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: from mta-p5.oit.umn.edu (mta-p5.oit.umn.edu. [134.84.196.205]) by mx.google.com with ESMTPS id h9si7219145iom.72.2018.12.26.10.10.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 10:10:06 -0800 (PST) Received-SPF: pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) client-ip=134.84.196.205; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=oCQPHEd8; spf=pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) smtp.mailfrom=pakki001@umn.edu; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 8A7C178 for ; Wed, 26 Dec 2018 18:10:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IFzsRNzLvc6m for ; Wed, 26 Dec 2018 12:10:06 -0600 (CST) Received: from mail-it1-f200.google.com (mail-it1-f200.google.com [209.85.166.200]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id 5EDD869 for ; Wed, 26 Dec 2018 12:10:06 -0600 (CST) Received: by mail-it1-f200.google.com with SMTP id p66so19153534itc.0 for ; Wed, 26 Dec 2018 10:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=Mjkli9qEz3XfIBVSkjFrEei2gi2+0gsWC4P+mtUqZuE=; b=oCQPHEd8KXwAYC35UO7b9tYfMwYvWLyOk7+DO08nXRDT2JzjXrJZKbYrl8A/sYxacx zqiMTBukE5C/XiEjHeuf7Lj6Q5pqU7F1i0sr9SsoJVkaQ1Yf43CudIZppkl3gVmjxv9U kaQc2ji7cTq4z2f16FRgR1HhDQxXdDunW7HRhBVBm09jNB7WMuHh5y52C7iSos+cv3nL AcS3BNpMnU8gBI09D8BDcC88zAknZvunFm5o2s2K3ntkXmeW5pTbW2dSIao6RaCQurht XKSQp7M8dzCNEVD6zX70o7kor2nJ7m/zLrNOGyPGTuu3mBP9gUFX245h3V9LxHD64krM Ld0g== X-Received: by 2002:a6b:e20a:: with SMTP id z10mr13160134ioc.208.1545847805931; Wed, 26 Dec 2018 10:10:05 -0800 (PST) X-Received: by 2002:a6b:e20a:: with SMTP id z10mr13160124ioc.208.1545847805711; Wed, 26 Dec 2018 10:10:05 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id t1sm17944513iol.85.2018.12.26.10.10.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 10:10:05 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] hmm: Warn on devres_release failure Date: Wed, 26 Dec 2018 12:09:04 -0600 Message-Id: <20181226180904.8193-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002109, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP devres_release can return -ENOENT if the device is not freed. The fix throws a warning consistent with other invocations. Signed-off-by: Aditya Pakki Reviewed-by: Jérôme Glisse --- mm/hmm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index 90c34f3d1243..b06e3f092fbf 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -1183,8 +1183,12 @@ static int hmm_devmem_match(struct device *dev, void *data, void *match_data) static void hmm_devmem_pages_remove(struct hmm_devmem *devmem) { - devres_release(devmem->device, &hmm_devmem_release, - &hmm_devmem_match, devmem->resource); + int rc; + + rc = devres_release(devmem->device, &hmm_devmem_release, + &hmm_devmem_match, devmem->resource); + if (rc) + WARN_ON(rc); } /*