From patchwork Wed Dec 26 19:42:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 10743283 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 639801399 for ; Wed, 26 Dec 2018 19:43:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 547DD2871C for ; Wed, 26 Dec 2018 19:43:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4870828737; Wed, 26 Dec 2018 19:43:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3BBE2871C for ; Wed, 26 Dec 2018 19:43:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C34028E0007; Wed, 26 Dec 2018 14:43:09 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id BE2E28E0001; Wed, 26 Dec 2018 14:43:09 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF9458E0007; Wed, 26 Dec 2018 14:43:09 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-it1-f199.google.com (mail-it1-f199.google.com [209.85.166.199]) by kanga.kvack.org (Postfix) with ESMTP id 892F38E0001 for ; Wed, 26 Dec 2018 14:43:09 -0500 (EST) Received: by mail-it1-f199.google.com with SMTP id k133so20618249ite.4 for ; Wed, 26 Dec 2018 11:43:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=Yukg6b4y64c8KSBao2PH5s3zw4SW0jWagPInPwmkaHA=; b=QiHUvWOsUoclUd7VA8GAg1WWQdRuhmOnt92dN1OsLwYQrOWQNmeoPVQCkfXLnIo1Ts 88TeSygFfwQAvxGxxLsro91OVoNHQFFifUUdV1heH9PzVOt9ZkcKD/ePLl+2GYW3eHSU rRrG6S9vRDGs+fpNmMiU4EZAb7ajI1plyU5EaYJJAB02C/eWX+hndQtef9lOxqlIeFG9 Cy73k5TSvQQ8QlVAdp7cE6N0A6wBKGE6ORBw49V6bb4pcQEVEA/K6Zf+gx8EysHDpi/u W6uSJ6KXsLd0L7VDothCF1Jylf6i7mkcL7LNl9PaVdjhbmneiV4EiTkrh7Jg/nAclMZD Efkg== X-Gm-Message-State: AJcUukdgSIsx/Mge/6XduIlzTa/TnvlDsKnYsT8UjnsWU6XE51CN1gqX ydq8uXcu3x5dkiiIpocWyJNdUBp+wOr64jqtpOV1PKJSa/YxRx+ca7w2enm+PFP8qwIe3qiIGN2 2/u/tZV7Xe4I3EMm/SIzbEjCNyzD5LT90vCD4jrzIIeVjWt9fu5V/OnEpcryc5qXJ6uQKA3xJX5 yf7zg1d68NI1fnpw6hqQMntuUO3sZ6D1ZMYBsShX2eBSArsgwZOmuDELSQSu4ASa71h5LdMYAa9 Zx2YYuSfH6SIiyVBwncq3WPH5tn7K96QoxWaKbZytnCdBqOxZVlq9JdA+2RK+AFzFEWOCaGynvv 19duAv5hXnIydB455BsZ/7KzBMiFyMfNUnKpjwOHJorwyXJMYrP51E/iv5skqfuZUP1YGEQmwFb D/WUhoKxMz+HQeaVHR+zV4mKmX43xMcEn836+8PYW7d3r11QFoylO5nHkMQJATcTL5qr5ViPUdD 4jMXIwu0HIArCBbjFsGmEpyCyW2Y77J4Vv+aCl8/NhBmOeI0gLaL8s25Xh3KesB49tuv8/aJuaF Ryq6debpIMhFQXgXk451f5oINFGpUwW9nZN099PVeZJH3tG X-Received: by 2002:a24:d4c2:: with SMTP id x185mr13961573itg.34.1545853389274; Wed, 26 Dec 2018 11:43:09 -0800 (PST) X-Google-Smtp-Source: AFSGD/XNdym0mUvlTEbYReYKZYP2MoQF3JPaDa124yg8SF/0PLxSaCVQkvNvsC/THV4xd6ASxaKx X-Received: by 2002:a24:d4c2:: with SMTP id x185mr13961547itg.34.1545853388210; Wed, 26 Dec 2018 11:43:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545853388; cv=none; d=google.com; s=arc-20160816; b=HSfhKMn7av2VjLV2kXXQxQ50LXkGkAZygEInWbvxkQR4yMKSnrGj7EQSM1WH/p4c1O xqOrVQuLXm10rJ1wXlEtAMLRhqZRcLashh5g7UzJQv33s5k2iMiRfGlzmSulJzn77FtU g0jXj46lCozM4D7uSO0Y5wQJTZbF3gSRHLdOWUyTo18Gy4FCvEsmcgFmzPeAyX2qX1xe W2ci6VbzGDLCZdEFvRQ08rwT9f+suRS3sTUMFnetWEgvqnXOOi7OE6xCR4m1UqWFawfM cRlF9Fn01mWfmVjgJelTLH3e3F0Zvf0OWo+iFfWqzrhugYKI+fRMGWQ/dpBzIztC8UIP SgoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=Yukg6b4y64c8KSBao2PH5s3zw4SW0jWagPInPwmkaHA=; b=LRfqHSdmy6v0NDsq9FjAUzlPzFXb5NQXZLP9sYWillHbi/bnenUSBhvIO471vTHGd5 sIrEWdmz89ArTBCdsIcjPPuwUaC9bF51MlLyX5NwCApBSHr0Ta7KAzMCewB75F6nACJJ uLav+D4gFjmUfmFCfYpo285cRVtIHBmwHCTkoz/3ZhijLGydKUb5D1ftcOtEaQ3kDTYO Tr1HevFMYu7TGL06bBr/NEGSqHBraZ88AKmQQjPLCXzyZnA5x5t3eUg8WRz3CXTEPJKN 3M/SDmilUYwY99vBbJ7SNRf8rCdNR5YqwGGzTUQNiGMn7ChE/Fh5CWt6QDfg5FIrw7v/ Bnew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=RofPxRvK; spf=pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) smtp.mailfrom=pakki001@umn.edu; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: from mta-p5.oit.umn.edu (mta-p5.oit.umn.edu. [134.84.196.205]) by mx.google.com with ESMTPS id q23si19798666jak.80.2018.12.26.11.43.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 11:43:08 -0800 (PST) Received-SPF: pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) client-ip=134.84.196.205; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=RofPxRvK; spf=pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) smtp.mailfrom=pakki001@umn.edu; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id DF8A4C4D for ; Wed, 26 Dec 2018 19:43:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m2tCTIzEzPwx for ; Wed, 26 Dec 2018 13:43:07 -0600 (CST) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id B8171C41 for ; Wed, 26 Dec 2018 13:43:07 -0600 (CST) Received: by mail-io1-f72.google.com with SMTP id r7so433351iom.22 for ; Wed, 26 Dec 2018 11:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=Yukg6b4y64c8KSBao2PH5s3zw4SW0jWagPInPwmkaHA=; b=RofPxRvKoEh6WqNyov5/t7AACnJ3fsdmQTVMNY4Dk/Uo9/hJO3Dl6Ex731mLii54rf 1R6h3pFd767vc5CygWQXG9idF/gg12zZHqAH7kuMKvYar9dJoN1hXa0AzWmLlAzX9kfQ fzT4V5k6qtS+c8GiZbTsImfbtPA4YgEF1ovRZZMEE+wmSOhN8ilFnbEV17lFXcmn7Ij2 w4MwibNTIaQxmQnT5P+6Br9dt42SP222WmmhHP+IQyIRn3bIiYOlHEC2gUW38uv1tZSQ A/LjBnBxel49NVzpKpY5bKTlPdd2ZS7bBiPRQhsrpB25DU43X3giCa0RA3P9F/CLYPmm X1AA== X-Received: by 2002:a24:76d0:: with SMTP id z199mr12624067itb.165.1545853387289; Wed, 26 Dec 2018 11:43:07 -0800 (PST) X-Received: by 2002:a24:76d0:: with SMTP id z199mr12624056itb.165.1545853387054; Wed, 26 Dec 2018 11:43:07 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id x128sm13391996itb.8.2018.12.26.11.43.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 11:43:06 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Andrew Morton , Michal Hocko , Vlastimil Babka , Joonsoo Kim , David Rientjes , Yang Shi , Johannes Weiner , Joe Perches , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: compaction.c: Propagate return value upstream Date: Wed, 26 Dec 2018 13:42:56 -0600 Message-Id: <20181226194257.11038-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP In sysctl_extfrag_handler(), proc_dointvec_minmax() can return an error. The fix propagates the error upstream in case of failure. Signed-off-by: Aditya Pakki Acked-by: Mel Gorman --- mm/compaction.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 7c607479de4a..d108974d0867 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1879,9 +1879,7 @@ int sysctl_compaction_handler(struct ctl_table *table, int write, int sysctl_extfrag_handler(struct ctl_table *table, int write, void __user *buffer, size_t *length, loff_t *ppos) { - proc_dointvec_minmax(table, write, buffer, length, ppos); - - return 0; + return proc_dointvec_minmax(table, write, buffer, length, ppos); } #if defined(CONFIG_SYSFS) && defined(CONFIG_NUMA)