From patchwork Fri Jan 11 11:01:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Lei X-Patchwork-Id: 10757647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4E84F1399 for ; Fri, 11 Jan 2019 11:02:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DC6029B18 for ; Fri, 11 Jan 2019 11:02:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31E2229C07; Fri, 11 Jan 2019 11:02:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 644C329B1C for ; Fri, 11 Jan 2019 11:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AAEB8E0005; Fri, 11 Jan 2019 06:02:31 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 659E88E0001; Fri, 11 Jan 2019 06:02:31 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 521F28E0005; Fri, 11 Jan 2019 06:02:31 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by kanga.kvack.org (Postfix) with ESMTP id 29D5D8E0001 for ; Fri, 11 Jan 2019 06:02:31 -0500 (EST) Received: by mail-qt1-f198.google.com with SMTP id p24so16249875qtl.2 for ; Fri, 11 Jan 2019 03:02:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=SN4quS8rBSk+7OkD/UQdCM5DjNZfyv3PfpiunvnHKgo=; b=t+BTlWLqMmyjJtKnGADUiwLK70Gt2SAKLTVU9U2hurxXa9CvfnNIDNtjbeYqkMGrAG iznlgxrnacbEoF38m01XQrnF6HwksmgDcskSHP5xCiFdDVLTX4c3PcaRkScGipGNTyEu 65+MElPGoEjz6y0isxd15cgmh4ze1W1AA9zqdkEGfi+UsrpoSQ/2HuoOMSgdwBrFvYgW DWA0QvahaBPaHyo6E4bwMUFnFZz+OyyeFqBL6YekDwsNkYjYllFOH+Az14oREDn+cPQ6 HpVf8pMwLC/brnCwL9FpKZBl1UvV7Qj98CuBqEepWHh2omZkEbnDmurlEp2a/fyDNzJB gnDw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: AJcUukfXl5coNH/crQOvde8dV0LI5pt/HRQ/qEAm3oahx4UUiO1jiYcf iWlbvoM1YgyWSmqW26PqiqTIDjlN/KWXTpynlNcS74r6MktcHGm753bUsVC9Id1lLR46hOxkjpf Uf2Z2+UITV9YD5TpLq9lW1Q9bojH8UM2us/cb1SPN9Br+jCCF+Bcn7T7SkdL2GNnfyQ== X-Received: by 2002:aed:314b:: with SMTP id 69mr13537489qtg.247.1547204550964; Fri, 11 Jan 2019 03:02:30 -0800 (PST) X-Google-Smtp-Source: ALg8bN4eVdldhdqMItlnwjrFKpOG4Uhw9DbddO2a3CGMyUrb2fsJcEUq3A06mvSMzBjmHivWQNde X-Received: by 2002:aed:314b:: with SMTP id 69mr13537462qtg.247.1547204550485; Fri, 11 Jan 2019 03:02:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547204550; cv=none; d=google.com; s=arc-20160816; b=PfGy4Cg1yKBMWnUAzbTsR57s+cuKVxzuL0LBosJopVy724L7zwF6nL4xs9rB4Whd7/ IzlTz6DJS1+fpKMFUYTjfTbjSUzEO+SHWn7UaXwL5UXpmyHYzAEYa3kmFmGQyKgPuBCm 1ppXv5fnEnKRCVE2e7gF0AM9ztr6kKh2NEYqOp4ndwbRDiTWJIAPXQ/BEUFLVNT8rYYH HnUu6dlyWKNc/pHSpIa/UmIU+m3Eyn8EosrvlPea/AlfEhN0VyL9f/ShnHFRVzz9mH12 zFvWyZnpt0uFeftDyig4tVCUOI5Qx6uuqs8X7yws7BljBNCoZCZB9vIMXHcvjS8nALNb 1pyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=SN4quS8rBSk+7OkD/UQdCM5DjNZfyv3PfpiunvnHKgo=; b=c+KWi9mqmE0hm/69oe0yhHdM3AXtsbKfU43E4wkVR5Jg9UweGZoNpC6YbbDJk9zR6g LI22BFRykIa/GnXM9BedzPUpMyDynvznPEox/3E8Jba1MRJRsLD+duOwyNoIe6GFKbNs mVvn5H+c2+5w8kkB7AB4yVAx2R71rimck1/8GZjq6wkY7oJowomZoUSF2VIums2PKV6Y poTRXHejMFwhYBwSVvScQnC/VeeFqVeZt8HMFTeqlC46SciNu2FQLbCKwtLIn+YdLQQ+ 8ioIU3NvHLCUfiK231wRRMrEZ4y/tbhx9p2eD0KYjMogVnDgOvrKUJOgDoZEJDHPWX5Y jzyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id v2si5352213qtf.321.2019.01.11.03.02.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 03:02:30 -0800 (PST) Received-SPF: pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ming.lei@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=ming.lei@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F62237EEF; Fri, 11 Jan 2019 11:02:29 +0000 (UTC) Received: from localhost (ovpn-8-28.pek2.redhat.com [10.72.8.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CE26600C4; Fri, 11 Jan 2019 11:02:27 +0000 (UTC) From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com, Ming Lei Subject: [PATCH V13 03/19] block: remove bvec_iter_rewind() Date: Fri, 11 Jan 2019 19:01:11 +0800 Message-Id: <20190111110127.21664-4-ming.lei@redhat.com> In-Reply-To: <20190111110127.21664-1-ming.lei@redhat.com> References: <20190111110127.21664-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 11 Jan 2019 11:02:29 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Commit 7759eb23fd980 ("block: remove bio_rewind_iter()") removes bio_rewind_iter(), then no one uses bvec_iter_rewind() any more, so remove it. Reviewed-by: Omar Sandoval Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- include/linux/bvec.h | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/include/linux/bvec.h b/include/linux/bvec.h index 02c73c6aa805..ba0ae40e77c9 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -92,30 +92,6 @@ static inline bool bvec_iter_advance(const struct bio_vec *bv, return true; } -static inline bool bvec_iter_rewind(const struct bio_vec *bv, - struct bvec_iter *iter, - unsigned int bytes) -{ - while (bytes) { - unsigned len = min(bytes, iter->bi_bvec_done); - - if (iter->bi_bvec_done == 0) { - if (WARN_ONCE(iter->bi_idx == 0, - "Attempted to rewind iter beyond " - "bvec's boundaries\n")) { - return false; - } - iter->bi_idx--; - iter->bi_bvec_done = __bvec_iter_bvec(bv, *iter)->bv_len; - continue; - } - bytes -= len; - iter->bi_size += len; - iter->bi_bvec_done -= len; - } - return true; -} - #define for_each_bvec(bvl, bio_vec, iter, start) \ for (iter = (start); \ (iter).bi_size && \