From patchwork Wed Feb 27 17:06:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Price X-Patchwork-Id: 10831973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B427715AC for ; Wed, 27 Feb 2019 17:08:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D4002E306 for ; Wed, 27 Feb 2019 17:08:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 917B02E328; Wed, 27 Feb 2019 17:08:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2752A2E306 for ; Wed, 27 Feb 2019 17:08:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70EB58E001D; Wed, 27 Feb 2019 12:08:10 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6BEDA8E0001; Wed, 27 Feb 2019 12:08:10 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5876E8E001D; Wed, 27 Feb 2019 12:08:10 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id F38148E0001 for ; Wed, 27 Feb 2019 12:08:09 -0500 (EST) Received: by mail-ed1-f71.google.com with SMTP id i22so7224300eds.20 for ; Wed, 27 Feb 2019 09:08:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=NXbLxkVEjkUC98nDqbwMu9XwBnfr8Fy+W9xUz87hsi8=; b=ZSbXrLHDP63ELwuM8yaZH7NwGfaGt/Ny//QdjAnPUMZ5yq1vQSwv/UBixbSEhYglkw AFolupFomjEB9JRkj++opQ8U56FR3OJKsLhSnHfTh8G2FycTXcQHYuWBTUWjxWrGG0DB d4jPTlJkVW4bY/I/sI1KdqvSnJ9QoYLOevUHCesFB6/X0Vy3OoYYIn67A2bOIe8b4Cg2 NvWRZYxKDEHd+ILvzwcncs10AFj6/LaGzmarVlIsjLvh4F9NliwH8GR80WI4RSdGf6i2 OiHOp7dgi0bgBiK9MMMjcDroRogOgVA8cKx6O+d6pmKYWRzlZzSs5EGw0iUzoN50SLyS ybzg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=steven.price@arm.com X-Gm-Message-State: AHQUAube9SNd6t/AbevwEjTZ5Ja6skqSxebCBJwS4oh+mCZXyRxXNlO3 1PY7AS0PSXQecFu6sM6iCRct/ZgCu2+cRQfqrkO0gGdTu53BFWT54v2vfAZsjs65kkT31jQZZo6 XmovtVrWuwPNRvM1Npc6G7BKK5QVCKrOTOh581QnpQ0DfZTz8p3Y4MsfbCS7RRc4FQQ== X-Received: by 2002:a50:89bc:: with SMTP id g57mr3064730edg.89.1551287289499; Wed, 27 Feb 2019 09:08:09 -0800 (PST) X-Google-Smtp-Source: AHgI3Iasr/11+Uuq8o8/MuoN/ti5klNYw6F1myrbe4+ES3gBmQM1iIUDOwVbFayd106ZPkweNyH4 X-Received: by 2002:a50:89bc:: with SMTP id g57mr3064669edg.89.1551287288483; Wed, 27 Feb 2019 09:08:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551287288; cv=none; d=google.com; s=arc-20160816; b=Vw1JYIOpxbfOCgGUVrLhAJX1rsWkk5bmMmmPKTMf4/lFTnTzmHKLh3e+6/TNrDdkCT TS6Ib1CnFjVWgukYdBsVaFl0fTw5Jhr5q6RYx86d4DHk8Vsoa5X/PByfEStFVKSQdOhb 0fJ+v9BX+qz0hi+k+hoPwJZBZTmN+synIiG+aFTLoF31+g5M5XcIQhdYlHlZexLQxd0B Ge57xWPy7/SHuaEO/qyNo7gTp3tW+Db7GolcWQKLScefR5HhdTlaoTkCI27ChzdnlqQs +RuaqoT8SZvUyShe0XdmP6w5+Z1jd/DZ63yPSqzTF0aKpjHUmEwNnsKmyxXV8FtUckqs d78g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=NXbLxkVEjkUC98nDqbwMu9XwBnfr8Fy+W9xUz87hsi8=; b=vgAzj1kFgoskds/pkYJb1wq3vPybn9S0WMJ/9oSNXvYnRId4tVXOsNbua7BQYTND1j eo5un/xczmWnU+CJxeLWoaR8tByny+B58UEOqja/gO8ssMGpDXxviPu+dT/4Sbi2lhOc vmjlN7Gb2o5VUR7VGQSq7aiKX90lJJFoP6btrgQt7jqpfgvzpDPqXjO3i+FeIqqzhFZw W8+ZUe/qO56hFcwUgi53VC163Bsuk5/sZnBqdHjNSHcNN/ug+wLivB5qn9xjks0Fan6A YHW34BSldCbu+tUQQZSilxAQY5Z4U+ILJ0FbYLVWqtq43EsNOfHNinJ/DkL6fKCajtM4 v7JA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=steven.price@arm.com Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id r15si5665733eji.31.2019.02.27.09.08.08 for ; Wed, 27 Feb 2019 09:08:08 -0800 (PST) Received-SPF: pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) client-ip=217.140.101.70; Authentication-Results: mx.google.com; spf=pass (google.com: domain of steven.price@arm.com designates 217.140.101.70 as permitted sender) smtp.mailfrom=steven.price@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98305174E; Wed, 27 Feb 2019 09:08:07 -0800 (PST) Received: from e112269-lin.arm.com (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5D15D3F738; Wed, 27 Feb 2019 09:08:04 -0800 (PST) From: Steven Price To: linux-mm@kvack.org Cc: Steven Price , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Peter Zijlstra , Thomas Gleixner , Will Deacon , x86@kernel.org, "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , "Liang, Kan" Subject: [PATCH v3 26/34] mm: pagewalk: Allow walking without vma Date: Wed, 27 Feb 2019 17:06:00 +0000 Message-Id: <20190227170608.27963-27-steven.price@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190227170608.27963-1-steven.price@arm.com> References: <20190227170608.27963-1-steven.price@arm.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Since 48684a65b4e3: "mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)", page_table_walk() will report any kernel area as a hole, because it lacks a vma. This means each arch has re-implemented page table walking when needed, for example in the per-arch ptdump walker. Remove the requirement to have a vma except when trying to split huge pages. Signed-off-by: Steven Price --- mm/pagewalk.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 98373a9f88b8..dac0c848b458 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -36,7 +36,7 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, do { again: next = pmd_addr_end(addr, end); - if (pmd_none(*pmd) || !walk->vma) { + if (pmd_none(*pmd)) { if (walk->pte_hole) err = walk->pte_hole(addr, next, walk); if (err) @@ -59,9 +59,14 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, if (!walk->pte_entry) continue; - split_huge_pmd(walk->vma, pmd, addr); - if (pmd_trans_unstable(pmd)) - goto again; + if (walk->vma) { + split_huge_pmd(walk->vma, pmd, addr); + if (pmd_trans_unstable(pmd)) + goto again; + } else if (pmd_large(*pmd)) { + continue; + } + err = walk_pte_range(pmd, addr, next, walk); if (err) break; @@ -81,7 +86,7 @@ static int walk_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, do { again: next = pud_addr_end(addr, end); - if (pud_none(*pud) || !walk->vma) { + if (pud_none(*pud)) { if (walk->pte_hole) err = walk->pte_hole(addr, next, walk); if (err) @@ -95,9 +100,13 @@ static int walk_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, break; } - split_huge_pud(walk->vma, pud, addr); - if (pud_none(*pud)) - goto again; + if (walk->vma) { + split_huge_pud(walk->vma, pud, addr); + if (pud_none(*pud)) + goto again; + } else if (pud_large(*pud)) { + continue; + } if (walk->pmd_entry || walk->pte_entry) err = walk_pmd_range(pud, addr, next, walk);