| Message ID | 20190329122649.28404-1-david@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] mm: balloon: drop unused function stubs | expand |
On 3/29/2019 5:56 PM, David Hildenbrand wrote: > These are leftovers from the pre-"general non-lru movable page" era. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > include/linux/balloon_compaction.h | 15 --------------- > 1 file changed, 15 deletions(-) Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index f111c780ef1d..f31521dcb09a 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page) > list_del(&page->lru); > } > > -static inline bool __is_movable_balloon_page(struct page *page) > -{ > - return false; > -} > - > -static inline bool balloon_page_movable(struct page *page) > -{ > - return false; > -} > - > -static inline bool isolated_balloon_page(struct page *page) > -{ > - return false; > -} > - > static inline bool balloon_page_isolate(struct page *page) > { > return false;
On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote: > These are leftovers from the pre-"general non-lru movable page" era. > > Signed-off-by: David Hildenbrand <david@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > include/linux/balloon_compaction.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index f111c780ef1d..f31521dcb09a 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page) > list_del(&page->lru); > } > > -static inline bool __is_movable_balloon_page(struct page *page) > -{ > - return false; > -} > - > -static inline bool balloon_page_movable(struct page *page) > -{ > - return false; > -} > - > -static inline bool isolated_balloon_page(struct page *page) > -{ > - return false; > -} > - > static inline bool balloon_page_isolate(struct page *page) > { > return false; > -- > 2.17.2
> > These are leftovers from the pre-"general non-lru movable page" era. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > include/linux/balloon_compaction.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/include/linux/balloon_compaction.h > b/include/linux/balloon_compaction.h > index f111c780ef1d..f31521dcb09a 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page > *page) > list_del(&page->lru); > } > > -static inline bool __is_movable_balloon_page(struct page *page) > -{ > - return false; > -} > - > -static inline bool balloon_page_movable(struct page *page) > -{ > - return false; > -} > - > -static inline bool isolated_balloon_page(struct page *page) > -{ > - return false; > -} > - > static inline bool balloon_page_isolate(struct page *page) > { > return false; > -- > 2.17.2 Looks good to me. Acked-by: Pankaj Gupta <pagupta@redhat.com> > >
On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote: > These are leftovers from the pre-"general non-lru movable page" era. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > include/linux/balloon_compaction.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index f111c780ef1d..f31521dcb09a 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page) > list_del(&page->lru); > } > > -static inline bool __is_movable_balloon_page(struct page *page) > -{ > - return false; > -} > - > -static inline bool balloon_page_movable(struct page *page) > -{ > - return false; > -} > - > -static inline bool isolated_balloon_page(struct page *page) > -{ > - return false; > -} > - > static inline bool balloon_page_isolate(struct page *page) > { > return false; > -- > 2.17.2 > Acked-by: Rafael Aquini <aquini@redhat.com>
diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index f111c780ef1d..f31521dcb09a 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page) list_del(&page->lru); } -static inline bool __is_movable_balloon_page(struct page *page) -{ - return false; -} - -static inline bool balloon_page_movable(struct page *page) -{ - return false; -} - -static inline bool isolated_balloon_page(struct page *page) -{ - return false; -} - static inline bool balloon_page_isolate(struct page *page) { return false;
These are leftovers from the pre-"general non-lru movable page" era. Signed-off-by: David Hildenbrand <david@redhat.com> --- include/linux/balloon_compaction.h | 15 --------------- 1 file changed, 15 deletions(-)