From patchwork Thu Apr 18 08:41:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 10906821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 548F1161F for ; Thu, 18 Apr 2019 09:07:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A825289DA for ; Thu, 18 Apr 2019 09:07:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BA3F28AC4; Thu, 18 Apr 2019 09:07:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D334289DA for ; Thu, 18 Apr 2019 09:07:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 640076B028D; Thu, 18 Apr 2019 05:07:01 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5C9486B028F; Thu, 18 Apr 2019 05:07:01 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46E386B028E; Thu, 18 Apr 2019 05:07:01 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by kanga.kvack.org (Postfix) with ESMTP id EB11A6B028F for ; Thu, 18 Apr 2019 05:07:00 -0400 (EDT) Received: by mail-wr1-f72.google.com with SMTP id s3so360167wrw.21 for ; Thu, 18 Apr 2019 02:07:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:message-id :user-agent:date:from:to:cc:subject:references:mime-version; bh=/5xTOz92ynxAhyjYrdXulLIkXELWdxy++vIO1sJln64=; b=fTEFMGcOuFRrEof4YQOyFScsG0uG9sX4T//9lobQqEnRPqbpz3EvvymoweikYXIT7X iVsn0hArLdMPFwjQc94nmlvxfnd0gHr5bvVH+qxNas7zuazNpt3GEdBQ6rXtfI/oa9Ma LY0DEYqfk/t0GhMGXVROE9tjAq9Y1Gs5FIqCiAIIgRrpxvg5HKgeLrC7M3aZZHBryE2I qB08bAxzaF3OPVQBwGutVFMozQh+rZA0d9VCuWRjmcAfPZqtd6XGC6a1J60AKb9uYPB0 AhMGMpHwFfow8CUj83NdEzgPf/lEKEA07CR6r1p/vxxzclJ9VzC6pg3ysBOkoYzeZ02Q Dx2g== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de X-Gm-Message-State: APjAAAXqR9dBpSrbHFIw/kts+6043B67JqU85OxqyY+6O32oDgYsa0Gy PFwOhBimJMic4YpqGLFO13G4KDywTxeN43SRaiXrn/Q82wY+4MzJACtZ1jKjT/4Qm32oFxbENJ3 VatyXSPIbZ3jHgz2x/LmuMJmcG2AUz6q+PN8/xiykzYOOfb1le45zRQUy26Cc14g2uQ== X-Received: by 2002:a1c:c18d:: with SMTP id r135mr2174492wmf.112.1555578420480; Thu, 18 Apr 2019 02:07:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyKi/hRAcb97ak3fZOVtzgXnq/SWSnJ3WFaxqq2c43JsYp1Is4sIoUA1sqIWNSUy9BkWiD X-Received: by 2002:a1c:c18d:: with SMTP id r135mr2174453wmf.112.1555578419701; Thu, 18 Apr 2019 02:06:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555578419; cv=none; d=google.com; s=arc-20160816; b=hhoYjMYI8/0Ds5sXGdK0VAZUP9pVcVHOiRCvMALYkV8wd6K8PVt01OX6GVI3/93Oaj HmrbstGe3sjdMVkZucexm48TepxhKEBxpLfvIi0IG8h2hco0T19khDYT3L67jnDL+txG 61gbGk5pz3w36TPT8bGPQ+yO4KE2R5mu6lcsib+0zC19U8VCpbDQNFj9jLvKjwrtwCyt Y1bFdTGzdqiCBjHoeX+RpMkULq5Hj5JJGeFaW/uL/n+F0bmfO3nkLW3f9r7XfeULKbF3 2SQydx5lTyiZ2OeMnoZ4pEknQYSvxn2NV8AuA2mBJgxbpxcGYh4CS4ZEwc4s/nz6KJUx g2FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:references:subject:cc:to:from:date:user-agent :message-id; bh=/5xTOz92ynxAhyjYrdXulLIkXELWdxy++vIO1sJln64=; b=fsA9ykMv5yh2tzFLo6o9YQRVlysbdzjrscKPA4jAmxKp8JYHNB7RIgH1vlX/y3WdNI rsr+wruVKZn9aEe7nxJnscGdJOSFIhajzcgReZzArvrSpZQeRkStlpQYmPyVpuFVS9Ke S0bNnRuZEss5pW66b7TmastaAiE19cq1zVcNLq7dsLHglyTPzB9wh1km+acwNFqeQyut rTRxKA3jdC6E9sqJLgFxpI6pHF8esqGFFKoK39QA5PHvpFIYk+R0kPCMa1DzDxrIF6JN inJWbaRRyz1MROpfsQr09oCsfueaXvP0YnMLNDv5YpkZsgFAgWEORvx4ihsw96xlbO+N 3/+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id v10si1226069wrt.101.2019.04.18.02.06.59 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 18 Apr 2019 02:06:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Received: from localhost ([127.0.0.1] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1hH30R-0001y0-Gu; Thu, 18 Apr 2019 11:06:55 +0200 Message-Id: <20190418084255.471038924@linutronix.de> User-Agent: quilt/0.65 Date: Thu, 18 Apr 2019 10:41:45 +0200 From: Thomas Gleixner To: LKML Cc: Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Steven Rostedt , Alexander Potapenko , Alexey Dobriyan , Andrew Morton , Pekka Enberg , linux-mm@kvack.org, David Rientjes , Christoph Lameter , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Mike Rapoport , Akinobu Mita , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Daniel Vetter , Rodrigo Vivi , linux-arch@vger.kernel.org Subject: [patch V2 26/29] stacktrace: Remove obsolete functions References: <20190418084119.056416939@linutronix.de> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP No more users of the struct stack_trace based interfaces. Remove them. Remove the macro stubs for !CONFIG_STACKTRACE as well as they are pointless because the storage on the call sites is conditional on CONFIG_STACKTRACE already. No point to be 'smart'. Signed-off-by: Thomas Gleixner --- include/linux/stacktrace.h | 17 ----------------- kernel/stacktrace.c | 14 -------------- 2 files changed, 31 deletions(-) --- a/include/linux/stacktrace.h +++ b/include/linux/stacktrace.h @@ -36,24 +36,7 @@ extern void save_stack_trace_tsk(struct struct stack_trace *trace); extern int save_stack_trace_tsk_reliable(struct task_struct *tsk, struct stack_trace *trace); - -extern void print_stack_trace(struct stack_trace *trace, int spaces); -extern int snprint_stack_trace(char *buf, size_t size, - struct stack_trace *trace, int spaces); - -#ifdef CONFIG_USER_STACKTRACE_SUPPORT extern void save_stack_trace_user(struct stack_trace *trace); -#else -# define save_stack_trace_user(trace) do { } while (0) -#endif - -#else /* !CONFIG_STACKTRACE */ -# define save_stack_trace(trace) do { } while (0) -# define save_stack_trace_tsk(tsk, trace) do { } while (0) -# define save_stack_trace_user(trace) do { } while (0) -# define print_stack_trace(trace, spaces) do { } while (0) -# define snprint_stack_trace(buf, size, trace, spaces) do { } while (0) -# define save_stack_trace_tsk_reliable(tsk, trace) ({ -ENOSYS; }) #endif /* CONFIG_STACKTRACE */ #if defined(CONFIG_STACKTRACE) && defined(CONFIG_HAVE_RELIABLE_STACKTRACE) --- a/kernel/stacktrace.c +++ b/kernel/stacktrace.c @@ -30,12 +30,6 @@ void stack_trace_print(unsigned long *en } EXPORT_SYMBOL_GPL(stack_trace_print); -void print_stack_trace(struct stack_trace *trace, int spaces) -{ - stack_trace_print(trace->entries, trace->nr_entries, spaces); -} -EXPORT_SYMBOL_GPL(print_stack_trace); - /** * stack_trace_snprint - Print the entries in the stack trace into a buffer * @buf: Pointer to the print buffer @@ -70,14 +64,6 @@ int stack_trace_snprint(char *buf, size_ } EXPORT_SYMBOL_GPL(stack_trace_snprint); -int snprint_stack_trace(char *buf, size_t size, - struct stack_trace *trace, int spaces) -{ - return stack_trace_snprint(buf, size, trace->entries, - trace->nr_entries, spaces); -} -EXPORT_SYMBOL_GPL(snprint_stack_trace); - /* * Architectures that do not implement save_stack_trace_*() * get these weak aliases and once-per-bootup warnings