| Message ID | 20190425201300.75650-1-cai@lca.pw (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-mmotm] mm: fix SHUFFLE_PAGE_ALLOCATOR help texts | expand |
On Thu, Apr 25, 2019 at 1:13 PM Qian Cai <cai@lca.pw> wrote: > > The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that > a page size is 4KB everywhere. > > Signed-off-by: Qian Cai <cai@lca.pw> > --- > > Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch. > > init/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/init/Kconfig b/init/Kconfig > index b050890f69dc..d96a910369c7 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR > the presence of a memory-side-cache. There are also incidental > security benefits as it reduces the predictability of page > allocations to compliment SLAB_FREELIST_RANDOM, but the > - default granularity of shuffling on 4MB (MAX_ORDER) pages is > - selected based on cache utilization benefits. > + default granularity of shuffling on the "MAX_ORDER - 1" i.e, > + 10th order of pages is selected based on cache utilization > + benefits on x86. > > While the randomization improves cache utilization it may > negatively impact workloads on platforms without a cache. For Looks good, Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/init/Kconfig b/init/Kconfig index b050890f69dc..d96a910369c7 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1764,8 +1764,9 @@ config SHUFFLE_PAGE_ALLOCATOR the presence of a memory-side-cache. There are also incidental security benefits as it reduces the predictability of page allocations to compliment SLAB_FREELIST_RANDOM, but the - default granularity of shuffling on 4MB (MAX_ORDER) pages is - selected based on cache utilization benefits. + default granularity of shuffling on the "MAX_ORDER - 1" i.e, + 10th order of pages is selected based on cache utilization + benefits on x86. While the randomization improves cache utilization it may negatively impact workloads on platforms without a cache. For
The help texts for SHUFFLE_PAGE_ALLOCATOR makes a wrong assumption that a page size is 4KB everywhere. Signed-off-by: Qian Cai <cai@lca.pw> --- Fix mm-shuffle-initial-free-memory-to-improve-memory-side-cache-utilization.patch. init/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)