diff mbox series

mm/vmalloc: fix a compile warning in mm

Message ID 20190624050937.6977-1-houweitaoo@gmail.com (mailing list archive)
State New, archived
Headers show
Series mm/vmalloc: fix a compile warning in mm | expand

Commit Message

Weitao Hou June 24, 2019, 5:09 a.m. UTC
mm/vmalloc.c: In function ‘pcpu_get_vm_areas’:
mm/vmalloc.c:976:4: warning: ‘lva’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
insert_vmap_area_augment(lva, &va->rb_node,

Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Uladzislau Rezki June 24, 2019, 9:41 a.m. UTC | #1
Hello, Hou.

It has already been fixed. Please have a look at:

https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning.patch
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning-fix.patch

--
Vlad Rezki

On Mon, Jun 24, 2019 at 7:09 AM Weitao Hou <houweitaoo@gmail.com> wrote:
>
> mm/vmalloc.c: In function ‘pcpu_get_vm_areas’:
> mm/vmalloc.c:976:4: warning: ‘lva’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> insert_vmap_area_augment(lva, &va->rb_node,
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 4c9e150e5ad3..78c5617fdf3f 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -913,7 +913,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
>         unsigned long nva_start_addr, unsigned long size,
>         enum fit_type type)
>  {
> -       struct vmap_area *lva;
> +       struct vmap_area *lva = NULL;
>
>         if (type == FL_FIT_TYPE) {
>                 /*
> --
> 2.18.0
>
diff mbox series

Patch

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 4c9e150e5ad3..78c5617fdf3f 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -913,7 +913,7 @@  adjust_va_to_fit_type(struct vmap_area *va,
 	unsigned long nva_start_addr, unsigned long size,
 	enum fit_type type)
 {
-	struct vmap_area *lva;
+	struct vmap_area *lva = NULL;
 
 	if (type == FL_FIT_TYPE) {
 		/*