diff mbox series

[RFC,v3,17/36] kmsan: x86: disable UNWINDER_ORC under KMSAN

Message ID 20191122112621.204798-18-glider@google.com (mailing list archive)
State New, archived
Headers show
Series Add KernelMemorySanitizer infrastructure | expand

Commit Message

Alexander Potapenko Nov. 22, 2019, 11:26 a.m. UTC
KMSAN doesn't currently support UNWINDER_ORC, causing the kernel to
freeze at boot time.
See http://github.com/google/kmsan/issues/48.

Signed-off-by: Alexander Potapenko <glider@google.com>
Cc: Qian Cai <cai@lca.pw>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: linux-mm@kvack.org

---
This patch is part of "kmsan: Kconfig changes to disable options
incompatible with KMSAN", which was split into smaller pieces.

Change-Id: I9cb6ebbaeb9a38e9e1d015c68ab77d40420a7ad0
---
 arch/x86/Kconfig.debug | 3 +++
 1 file changed, 3 insertions(+)

Comments

Marco Elver Dec. 2, 2019, 1:30 p.m. UTC | #1
On Fri, 22 Nov 2019 at 12:27, <glider@google.com> wrote:
>
> KMSAN doesn't currently support UNWINDER_ORC, causing the kernel to
> freeze at boot time.
> See http://github.com/google/kmsan/issues/48.

The Github issues doesn't mention much else -- it might be useful for
future people to elaborate why it doesn't work? If it is unclear why
it doesn't work, then it's fine to mention this in commit message as
well I suppose.

> Signed-off-by: Alexander Potapenko <glider@google.com>
> Cc: Qian Cai <cai@lca.pw>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Vegard Nossum <vegard.nossum@oracle.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: linux-mm@kvack.org
>
> ---
> This patch is part of "kmsan: Kconfig changes to disable options
> incompatible with KMSAN", which was split into smaller pieces.
>
> Change-Id: I9cb6ebbaeb9a38e9e1d015c68ab77d40420a7ad0
> ---
>  arch/x86/Kconfig.debug | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index bf9cd83de777..db3cd6147829 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -292,6 +292,9 @@ choice
>  config UNWINDER_ORC
>         bool "ORC unwinder"
>         depends on X86_64
> +       # KMSAN doesn't support UNWINDER_ORC yet,
> +       # see https://github.com/google/kmsan/issues/48.
> +       depends on !KMSAN
>         select STACK_VALIDATION
>         ---help---
>           This option enables the ORC (Oops Rewind Capability) unwinder for
> --
> 2.24.0.432.g9d3f5f5b63-goog
>
diff mbox series

Patch

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index bf9cd83de777..db3cd6147829 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -292,6 +292,9 @@  choice
 config UNWINDER_ORC
 	bool "ORC unwinder"
 	depends on X86_64
+	# KMSAN doesn't support UNWINDER_ORC yet,
+	# see https://github.com/google/kmsan/issues/48.
+	depends on !KMSAN
 	select STACK_VALIDATION
 	---help---
 	  This option enables the ORC (Oops Rewind Capability) unwinder for