From patchwork Thu Nov 28 14:35:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Song X-Patchwork-Id: 11266095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 69C1A13A4 for ; Thu, 28 Nov 2019 14:35:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 356B321774 for ; Thu, 28 Nov 2019 14:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=aliyun.com header.i=@aliyun.com header.b="VUi62e0i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 356B321774 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=aliyun.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5DBF66B053B; Thu, 28 Nov 2019 09:35:50 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 565B16B053C; Thu, 28 Nov 2019 09:35:50 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 453E06B053D; Thu, 28 Nov 2019 09:35:50 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 2B9296B053B for ; Thu, 28 Nov 2019 09:35:50 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id CF5B1181AEF21 for ; Thu, 28 Nov 2019 14:35:49 +0000 (UTC) X-FDA: 76205935218.25.cover23_6cdc32fc4261e X-Spam-Summary: 2,0,0,2c1d17e2dd4bdea5,d41d8cd98f00b204,fishland@aliyun.com,:akpm@linux-foundation.org:mhocko@suse.com:hannes@cmpxchg.org:daniel.m.jordan@oracle.com:laoar.shao@gmail.com:yang.shi@linux.alibaba.com:aryabinin@virtuozzo.com:mgorman@techsingularity.net::linux-kernel@vger.kernel.org:liu.song11@zte.com.cn,RULES_HIT:41:355:379:541:800:960:968:973:988:989:1260:1261:1311:1314:1345:1437:1515:1534:1540:1711:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3871:5007:6261:6653:7576:9592:10004:11026:11658:11914:12043:12048:12296:12297:12438:12555:12679:12895:13069:13161:13229:13311:13357:13894:14096:14181:14384:14394:14721:21080:21627:30054,0,RBL:115.124.30.50:@aliyun.com:.lbl8.mailshell.net-62.18.2.100 64.100.201.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: cover23_6cdc32fc4261e X-Filterd-Recvd-Size: 2633 Received: from out30-50.freemail.mail.aliyun.com (out30-50.freemail.mail.aliyun.com [115.124.30.50]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 14:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aliyun.com; s=s1024; t=1574951745; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=1lo7y5xVS/ROINE2Dk8+IB2THUKSego8tWg2Ob1Ko6M=; b=VUi62e0iFdwYM9Y/bclh22yUq6t9lnSB7CWZXLAbbAeBSBS4liqPsYu/zbptoSOPSbLbSXSX9fxhsVUKTGLgsN5suWiyBJ1ldmuyapECe2H7v4gdHqnmu0U6IaYDCskd+Jgo+iOlC75LCWC1a0hZAGc3O3nEnlmqMf/jLiKs9Nk= X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1010683|-1;CH=green;DM=CONTINUE|CONTINUE|true|0.18297-0.0189225-0.798107;DS=CONTINUE|ham_system_inform|0.00708449-0.00159668-0.991319;FP=0|0|0|0|0|-1|-1|-1;HT=e01e07487;MF=fishland@aliyun.com;NM=1;PH=DS;RN=11;RT=11;SR=0;TI=SMTPD_---0TjJa3hc_1574951733; Received: from localhost.localdomain(mailfrom:fishland@aliyun.com fp:SMTPD_---0TjJa3hc_1574951733) by smtp.aliyun-inc.com(127.0.0.1); Thu, 28 Nov 2019 22:35:44 +0800 From: Liu Song To: akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, daniel.m.jordan@oracle.com, laoar.shao@gmail.com, yang.shi@linux.alibaba.com, aryabinin@virtuozzo.com, mgorman@techsingularity.net Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, liu.song11@zte.com.cn Subject: [PATCH] mm/vmscan.c: remove unused return value of shrink_node Date: Thu, 28 Nov 2019 22:35:24 +0800 Message-Id: <20191128143524.3223-1-fishland@aliyun.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Liu Song The return value of shrink_node is not used, so remove unnecessary operations. Signed-off-by: Liu Song Reviewed-by: David Hildenbrand --- mm/vmscan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 44df66a98f2a..fd282d86f4ad 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2652,7 +2652,7 @@ static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup *memcg) (memcg && memcg_congested(pgdat, memcg)); } -static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) +static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) { struct reclaim_state *reclaim_state = current->reclaim_state; unsigned long nr_reclaimed, nr_scanned; @@ -2818,8 +2818,6 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc) */ if (reclaimable) pgdat->kswapd_failures = 0; - - return reclaimable; } /*