| Message ID | 20200110025516.23996-1-richardw.yang@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/huge_memory.c: reduce critical section protected by split_queue_lock | expand |
On Fri, Jan 10, 2020 at 10:55:16AM +0800, Wei Yang wrote: > split_queue_lock protects data in struct deferred_split. We can release > the lock after delete the page from deferred_split_queue. > > This patch moves the THP accounting out of the lock protection, which is > introduced in commit 65c453778aea ("mm, rmap: account shmem thp pages"). > > Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3c745d298a27..88c541bf44c7 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2810,6 +2810,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) ds_queue->split_queue_len--; list_del(page_deferred_list(head)); } + spin_unlock(&ds_queue->split_queue_lock); if (mapping) { if (PageSwapBacked(head)) __dec_node_page_state(head, NR_SHMEM_THPS); @@ -2817,7 +2818,6 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) __dec_node_page_state(head, NR_FILE_THPS); } - spin_unlock(&ds_queue->split_queue_lock); __split_huge_page(page, list, end, flags); if (PageSwapCache(head)) { swp_entry_t entry = { .val = page_private(head) };
split_queue_lock protects data in struct deferred_split. We can release the lock after delete the page from deferred_split_queue. This patch moves the THP accounting out of the lock protection, which is introduced in commit 65c453778aea ("mm, rmap: account shmem thp pages"). Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)