diff mbox series

[1/2] mm/huge_memory.c: use head to check huge zero page

Message ID 20200110032610.26499-1-richardw.yang@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] mm/huge_memory.c: use head to check huge zero page | expand

Commit Message

Wei Yang Jan. 10, 2020, 3:26 a.m. UTC 
The page could be a tail page, if this is the case, this BUG_ON will
never be triggered.

Fixes: e9b61f19858a ("thp: reintroduce split_huge_page()")

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 mm/huge_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kirill A . Shutemov Jan. 10, 2020, 11:50 p.m. UTC | #1 
On Fri, Jan 10, 2020 at 11:26:09AM +0800, Wei Yang wrote:
> The page could be a tail page, if this is the case, this BUG_ON will
> never be triggered.
> 
> Fixes: e9b61f19858a ("thp: reintroduce split_huge_page()")
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
diff mbox series

Patch

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 168d8a1a9bac..90165f68cf13 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2696,7 +2696,7 @@  int split_huge_page_to_list(struct page *page, struct list_head *list)
 	unsigned long flags;
 	pgoff_t end;
 
-	VM_BUG_ON_PAGE(is_huge_zero_page(page), page);
+	VM_BUG_ON_PAGE(is_huge_zero_page(head), head);
 	VM_BUG_ON_PAGE(!PageLocked(page), page);
 	VM_BUG_ON_PAGE(!PageCompound(page), page);